[tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion?

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion?
--+
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal|   Keywords:  bridgedb-dist moat
Actual Points:|  Parent ID:
   Points:  1 |   Reviewer:
  Sponsor:  SponsorM  |
--+
 Pearl Crescent reported that moat isn't returning bridges upon successful
 CAPTCHA completion.  This needs to be debugged/investigated.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion?

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion?
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bridgedb-dist moat|  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorM
--+--
Changes (by isis):

 * status:  new => needs_review


Comment:

 Aha, there was a bug in the `test-moat` script, because the server
 requires (in order to create and check the CAPTCHA) that it has some
 notion of what the client's IP is.  Added an "X-Forwarded-For" header to
 the curl command fixed it.  I've also made it somewhat easier to pass the
 latest challenge and the solution (always "Tvx74PMy" since that's the only
 CAPTCHA in the `bridgedb.git/captchas` directory):

 {{{
 (bdb)∃!isisⒶwintermute:(develop *$>)~/code/torproject/bridgedb ∴ ./scripts
 /test-moat fetch
 {"data": [{"challenge": "QSPBFMxqGi-
 mlxwPcjWJ7FJqY0FW0wx60B5zTM4LMWDda8VwRzKtClAsBCdVP-
 q8WDYD5sRj6PzDXF1hAdsOJu0M-
 
AWokcF6nxfOg0ZadpINW3QHqtdu9Veg0j2GBjQVquyLi5LrZ2R1hNi17igQdm1xgtrLsnWbu_Ts4SCSRxBy9W6nXYkWRqnbzU2BQgbvkIKrDhbqAdhSQsWDr25tWYYRVK6k_GBSJOblJ_vRBYZdIuCC-
 BZVQicJM2c3j_5aj0ClApe_EacqN6CL-
 
nk6yR9Ukw8gNQelIewvREkqbdxR6Rhiwfc059pIt9wyMQL6_yMODSpmtocui_5ecNDvSXPxE5qZiV9f-
 Rsg_Bh3ccFRFNpw", "id": 1, "version": "0.1.0", "type": "moat-challenge",
 "image":
 
"/9j/4AAQSkZJRgABAQEASABIAAD/2wBDAAEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/2wBDAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQEBAQH/wAARCAB9AZADASIAAhEBAxEB/8QAHwAAAQUBAQEBAQEAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUFBAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkKFhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWmp6ipqrKztLW2t7i5usLDxMXGx8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEAAwEBAQEBAQEBAQECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAECAxEEBSExBhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRomJygpKjU2Nzg5OkNERUZHSElKU1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOEhYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3uLm6wsPExcbHyMnK0tPU1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwD+lv8AZ8/Zy0z4H6/aaLreofDjxXqGn27RahoMGt2/jWbw58P/ABTq3iq2110k8UWsninUE8X6haq93b6XdWFpNr2o3kCWl5aWCQPV8f8AhcN4Y8Y3fwR8Faj4MvbfWtWi0u7n8I6z4g16Ww1/xl4Z8Mvc6bb6V9hm8Baf
 
ptn4Ztru3bRZrvVdH8M2Fpr7aYt9GkRreDPFnw41vwd4X+Ifi34c3fgDx1AdD8N6Z4o8PeLNV0bwnBb6PqF14V1fV9A0yy8Y2V3ffDjwR4ne8uLY60dAsLXw54iWPS5JL3Untrr6A8BWnw+079pLXPHWv+PZIfEev61ZeFLDw3ptn4a07TNd8bXngOEy6feKtmfFun6suneEtW1TT01jWbnSL7TtWsJrDUrxnURgHQ+Jta0PQbxv+ER1uaKb4o6Fcw31pqV81hDPH4RsxYeMvFq6P4lGhS67e6jbWfhjQoNVvvEEhmtZk1GxjtolvJrvyX4faD8O/C3iDVrC9bWrnXfGHgLVfBF9qvh6/wDEfjjxhbNqGoWl/qEf/CR3l/rOn+F3E2pvqP2O81zWr+a2vdItor21SwsbR7Xxo8R3XxD1e+Hhr4X6BFo+h+Ftb8+21CaCy8b3Os3XiXQrPxnodve6Zqc1pp6xRvqUMesBL3Shrulz3F5qWkwaWl7La8XfDPwx4l+F02rXPivxt4f0+98JJ4k8Vy+G/EdjqfxI8IabqUi3E8GlfZNB8V3Gr6k8+iWlrJqI1RYRHpS/2RcW+n2qwxACeOvAOhWPgPw5Y6ZYa9pXhz4VjRZfClpfXWuabrGhS+FTpvhc6nq3h/Xda0XSH0eyt9O1G1bxLY6pcmEalZa5p6kRjUT5p4z8KfDH4f33jW/8P+GvCGjeO/2ifHtlZ6np2peBfFWtW/xe8PJovh+fx6bEaClg2haPqV2VZtR1y41zw+JUvNQ1Sa8Gr3sp6eLWta/aF8aa1Y6g2qeOvhssdx8P/F3hXwx4hbw74q8PReEPGBOheI9StL97Wy002r/bT44Sz8T3sniS003w5eQ6WLO/uNNX1PxXrfwqliubLxJq/wAS7mx8JaX4T1OS68Q+Jbrwb4W8JeK59ZuobF9Z8d6bqOl2mrw6xe601rqWl6Rf6voUUfhs6ZDaLdRWtpKAeXeBofElt
 
8NvCfhLxIPGHwT1L4ZeIvClrYeOvDsVuLjVvD2uXsHhzRpvEkutOLbUL7W9Q8ReJ7qKyWTWtP0toGvr+zF+9pBXY+K/H3w71qGXw/4L8ba38RNT1zUvCFlFr3hfxfa+GNX8ST+NPEd9YSX1pJ4AsLPUZNe8MDRpv7YM+mRLa+HrOSV72SJdUtpu+0DTNQ0Cz0lND0my+JmqeJ9Iutf8UeHtB8W3Gp/DO7urSwh8QbgfET62NOlvfFfiGO50iLR4bOefS3jnkF39htbU+E3uqeFdVlsL7xN8O9Y+HPhXwtrdz448E+ED40tdH8cP4l8VJdanqPiDXvDGiaG/iLTZbbxNrsvhHw7pVlquptez6rJeNpEUltazqAfQHh3x38NfB/jK08I2UnxIvPFOjXHiabw7Dq2sxXVrZajeXGhLqNtq3hiy1nT7+/kMfieDxAt/4p04XUOlzXuoSX9vAoK+G2fjkx+Or7w7H4U8Qf8ACPa54r+KVj4g+JXh6DxdrVz4GuNQ1/VdH0rTpPFOj6pY2eoad4g1W/tdROg+HZp5/C09uF1LTWkFzrFi6w+IllqNv/wk99ZXemeLPF+kaj4Gg1PxP4Pl12x1DwpDp19Bpml+MrefWNKfwx4pPiXT9W8OQrqniaebVL+CRbpYRf6fFa6Hx3j1u38P/CfS/A2uePvDCeDI9O1bWfHOsavo2k2X27xzqGm2Gkadb6t4h1j/AIQvxFqc+pagttdQpo/iuK30Z77TrCWz1W901pgDmvDngL4aaFo9xoVt4h8Yan/wqC2nmg1DxHd+IIfiV4MtNG8TeIrvUfG/hmI3tzfeID4tv5ZGtEjuLeDXdAtrSJ4tbk09rZ+s8SR3TeHbO70bRbr4jaX4t0HTde8Wav4WtdAh1HWvGOtPo1pF4k1r4b2Ed9PqN/4RsnhvtR1kQajdaSl3o7/2Hrs9mj2XP/HLw5pB+IPwt+Gfi200u98O3+mXekz+FFbSbG28ZXOr2e
 
oy350jw3o/w68T3QfwZZ6XNr2gXUfiXSZrWTX/ACdVvAt0gat8MPjDaeJ/EiXvw4istK02w8CeMblPhpovhs2OreD9Xg1XVLPVNCvtZi8M2PiXS4tR1nwssXiq00TS/EetHXr6xjVLBRp8uogHs9r4D02+1rwV4N0HW/Eeu3Xwp8QQ6h4nstG8SwRX8d5e2812U8TQaHPokEemTQ+IbiN7i7sdN8T6hNpJFxZazbXV248m8D678KfhH4y8Z/Dzxr4V0vUrZL3xd8S/CV9BYnU/JUzXum6VbzeL

Re: [tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion?

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion?
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bridgedb-dist moat|  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorM
--+--

Comment (by isis):

 Actually, heh. From the above output, there's another bug (although it
 shouldn't stop testing). It's giving a QR when we said we didn't need one.
 I guess it's nice to know the server is enthusiastic about sending images
 anyway (and that it works). I've made #24443 for that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bridgedb-dist moat|  Actual Points:  .5
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorM
--+--
Changes (by isis):

 * actualpoints:   => .5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bridgedb-dist moat|  Actual Points:  .5
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorM
--+--

Comment (by mcs):

 It looks like this is working when I use the test-moat script now. Yay!
 I assume that "X-Forwarded-For" will be automatically inserted by the
 front server. For now, to proceed with integration, we can add it manually
 like you did in test-moat.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bridgedb-dist moat|  Actual Points:  .5
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorM
--+--

Comment (by mcs):

 Kathy and I worked on integration some more and noticed the following
 issues (please let is know if you want us to open new tickets):
 * The spec in README.rst needs to be updated. General issues are that
 single quotes should be replaced with double quotes and that all JSON
 values should be enclosed in quotes (e.g., the `id` value is not).
 * For the `/fetch` request, the `type` is specified as `moat-transports`
 but the implementation uses `client-transports`. For consistency with the
 other `type` values you may want to use `moat-transports`.
 * The `data` payload is specified as an object but the implementation uses
 an array. This is permitted by the JSON API specification but seems
 unnecessary for the moat protocol (since each request and response only
 includes one JSON object).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bridgedb-dist moat|  Actual Points:  .5
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorM
--+--
Changes (by intrigeri):

 * cc: anonym, intrigeri (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bridgedb-dist moat|  Actual Points:  .5
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorM
--+--

Comment (by isis):

 Replying to [comment:6 mcs]:
 > Kathy and I worked on integration some more and noticed the following
 issues (please let is know if you want us to open new tickets):

 Hi! Thanks for the review!

 > * The spec in README.rst needs to be updated. General issues are that
 single quotes should be replaced with double quotes and that all JSON
 values should be enclosed in quotes (e.g., the `id` value is not).

 Fixed in
 
[https://gitweb.torproject.org/user/isis/bridgedb.git/commit/?h=develop&id=8d8db4a06d3dff5e9f82adcb4e0e921fe3577098
 8d8db4a0]

 > * For the `/fetch` request, the `type` is specified as `moat-transports`
 but the implementation uses `client-transports`. For consistency with the
 other `type` values you may want to use `moat-transports`.

 
[https://gitweb.torproject.org/user/isis/bridgedb.git/commit/?h=develop&id=50a9321fadcfd0e9a4f30bc1919c1bf46d27d8e1
 50a9321f]

 > * The `data` payload is specified as an object but the implementation
 uses an array. This is permitted by the JSON API specification but seems
 unnecessary for the moat protocol (since each request and response only
 includes one JSON object).

 We can change it back to a single object if you think that's better. My
 reasoning was:

 1. I totally read the spec wrong and I thought it said they had to be
 arrays, and
 2. future-compatibility, in case we decided at some point that providing
 the user with more messages/errors might be helpful (e.g. if there is some
 non-fatal error which we might want to return/log/display on the client-
 side, but we're still also going to return bridges/captchas).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  bridgedb-dist moat|  Actual Points:  1
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorM
--+--
Changes (by isis):

 * status:  needs_review => closed
 * resolution:   => fixed
 * actualpoints:  .5 => 1


Comment:

 Replying to [comment:8 isis]:
 > Replying to [comment:6 mcs]:
 > > * For the `/fetch` request, the `type` is specified as `moat-
 transports` but the implementation uses `client-transports`. For
 consistency with the other `type` values you may want to use `moat-
 transports`.
 >
 >
 
[https://gitweb.torproject.org/user/isis/bridgedb.git/commit/?h=develop&id=50a9321fadcfd0e9a4f30bc1919c1bf46d27d8e1
 50a9321f]

 Oops, I believe the original behaviour was actually correct: the client,
 when requesting /fetch, sends a `"type": "client-transports"`. The server,
 when responding to that request, iff there was no overlap in which
 transports are supported, sends `"type": "moat-transports"` to let the
 client software know which types it ''does'' have available.

 I've reverted 50a9321f.

 Closing as fixed; fingers crossed nothing else is broken.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  bridgedb-dist moat|  Actual Points:  1
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorM
--+--

Comment (by mcs):

 Replying to [comment:8 isis]:
 > > * The `data` payload is specified as an object but the implementation
 uses an array. This is permitted by the JSON API specification but seems
 unnecessary for the moat protocol (since each request and response only
 includes one JSON object).
 >
 > We can change it back to a single object if you think that's better. My
 reasoning was:
 >
 > 1. I totally read the spec wrong and I thought it said they had to be
 arrays, and
 > 2. future-compatibility, in case we decided at some point that providing
 the user with more messages/errors might be helpful (e.g. if there is some
 non-fatal error which we might want to return/log/display on the client-
 side, but we're still also going to return bridges/captchas).

 My argument is that using arrays just makes the code a little more
 complicated, and on the client side we are always going to send a one-
 element array for requests and we are going to use data[0] when handling
 each response. But let's just use arrays since that is what is already
 implemented.

 Please update the spec when you have time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  bridgedb-dist moat|  Actual Points:  1
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorM
--+--

Comment (by mcs):

 Replying to [comment:9 isis]:
 > Oops, I believe the original behaviour was actually correct: the client,
 when requesting /fetch, sends a `"type": "client-transports"`. The server,
 when responding to that request, iff there was no overlap in which
 transports are supported, sends `"type": "moat-transports"` to let the
 client software know which types it ''does'' have available.
 >
 > I've reverted 50a9321f.

 Ah, that makes sense. Sorry for the false alarm.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24433 [Obfuscation/BridgeDB]: moat isn't returning bridges on successful CAPTCHA completion (was: moat isn't returning bridges on successful CAPTCHA completion?)

[Tor Bug Tracker & Wiki]

#24433: moat isn't returning bridges on successful CAPTCHA completion
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:
 Keywords:  bridgedb-dist moat|  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorM
--+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs