Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
--+--
 Reporter:  isabela   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  snowflake, tbb-rbm, tbb-easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 There is no GCC involved anymore in compiling dependencies for snowflake.
 Thus, I think with the purely Go-based version we have right now (see:
 #25483). This bug is gone, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
--+
 Reporter:  isabela   |  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake, tbb-rbm, tbb-easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * keywords:  snowflake, tbb-rbm => snowflake, tbb-rbm, tbb-easy


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
--+
 Reporter:  isabela   |  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake, tbb-rbm|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  snowflake, tbb-rbm, TorBrowserTeam201811R => snowflake, tbb-
   rbm


Comment:

 If just snowflake requires `libatomic.so` then let's make sure the library
 does not get unconditionally included but only if we are actually building
 and distributing snowflake (which is not the case for the current release
 series and might still not be the case for the coming one). We have
 `var/snowflake` for that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  TorBrowserTeam201811R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  snowflake, tbb-rbm, TorBrowserTeam201809 => snowflake, tbb-
 rbm, TorBrowserTeam201811R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sukhbir):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:19 gk]:
 > Replying to [comment:18 sukhbir]:
 > > For review:
 > >
 > > https://github.com/azadi/tor-browser-build-1/tree/bug-24465
 >
 > IIRC this was a 64but-only problem but you are copying the lib for 32bit
 as well which seems to be not needed (if I got the history of this bug
 right).

 The original logs had expired (the share.riseup.net link) so I decided to
 check and it seems like this issue affects both the 32- and 64-bit
 versions.

 The branch with the rebased changes is at https://github.com/azadi/tor-
 browser-build-1/tree/bug-24465-rev1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:18 sukhbir]:
 > For review:
 >
 > https://github.com/azadi/tor-browser-build-1/tree/bug-24465

 IIRC this was a 64but-only problem but you are copying the lib for 32bit
 as well which seems to be not needed (if I got the history of this bug
 right).

 > Note that this simply copies the library from `gcc/libs`. Perhaps we can
 do something similar for #25485, where we first try to run `snowflake-
 client` and if it fails, then only we add it `libatomic.so` to
 `LD_LIBRARY_PATH`. Is that preferred?

 We could do that. But we eventually want to get rid of `LD_LIBRARY_PATH` I
 think and not add another workaround to this workaround if possible. So, I
 wonder if this bug would be a good start to look into compiling with a
 relative `-rpath`. See: #13373 and #13359 where I did some initial work
 some years ago.

 > I reproduced and tested this on Lubuntu 17.10.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sukhbir):

 * status:  new => needs_review


Comment:

 For review:

 https://github.com/azadi/tor-browser-build-1/tree/bug-24465

 Note that this simply copies the library from `gcc/libs`. Perhaps we can
 do something similar for #25485, where we first try to run `snowflake-
 client` and if it fails, then only we add it `libatomic.so` to
 `LD_LIBRARY_PATH`. Is that preferred?

 I reproduced and tested this on Lubuntu 17.10.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  TorBrowserTeam201805   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dcf):

 * cc: dcf (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  snowflake, tbb-rbm,  |  Actual Points:
  TorBrowserTeam201805   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * keywords:  ux-team, snowflake, tbb-rbm, TorBrowserTeam201805 =>
 snowflake, tbb-rbm, TorBrowserTeam201805


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, snowflake, tbb-rbm, |  Actual Points:
  TorBrowserTeam201805   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  needs_information => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, snowflake,  |  Actual Points:
  TorBrowserTeam201804, tbb-rbm  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:8 gk]:
 > boklm: Could you test (using steps in #25087) whether the GCC update in
 #25304 solves this issue?

 After the gcc update, `snowflake-client` is still linked to
 `libatomic.so.1`, so it seems it didn't solve the issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, snowflake,  |  Actual Points:
  TorBrowserTeam201804, tbb-rbm  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: boklm (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team, snowflake,  |  Actual Points:
  TorBrowserTeam201804, tbb-rbm  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  ux-team, snowflake, TorBrowserTeam201803 => ux-team,
 snowflake, TorBrowserTeam201804, tbb-rbm
 * status:  assigned => needs_information
 * parent:  #24371 =>


Comment:

 boklm: Could you test (using steps in #25087) whether the GCC update in
 #25304 solves this issue?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team snowflake|  Actual Points:
  TorBrowserTeam201802   |
Parent ID:  #24371   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arlolra):

 * cc: arlolra (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host (was: 'missing pluggable transport ' error when trying to connect to Tor using snowflake)

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-+-
 Reporter:  isabela  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team snowflake|  Actual Points:
  TorBrowserTeam201802   |
Parent ID:  #24371   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * keywords:  ux-team snowflake => ux-team snowflake TorBrowserTeam201802
 * owner:  brade => tbb-team
 * status:  needs_information => assigned
 * component:  Applications/Tor Launcher => Applications/Tor Browser


Comment:

 The issue seems to be reproducible per the info provided in #25087.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs