Re: [tor-bugs] #24486 [Core Tor/Tor]: Mark all bridges as up on application activity

[Tor Bug Tracker & Wiki]

#24486: Mark all bridges as up on application activity
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:  not a
 Keywords:  regression, tor-bridge-client,   |  bug
  s8-errors  |  Actual Points:
Parent ID:  #24367   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => closed
 * resolution:   => not a bug


Comment:

 We are now handling this case better, and the code has been merged. It
 turns out it was a redundant condition, so this ticket can close.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24486 [Core Tor/Tor]: Mark all bridges as up on application activity

[Tor Bug Tracker & Wiki]

#24486: Mark all bridges as up on application activity
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  regression, tor-bridge-client,   |  Actual Points:
  s8-errors  |
Parent ID:  #24367   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 I think we found the issue in #24392. But let's check.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24486 [Core Tor/Tor]: Mark all bridges as up on application activity

[Tor Bug Tracker & Wiki]

#24486: Mark all bridges as up on application activity
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  regression, tor-bridge-client,   |  Actual Points:
  s8-errors  |
Parent ID:  #24367   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Oh, ok, so arma is half-right here. We need to count the number of
 configured bridges in this code, because the other choices don't do what
 we want:
 * using any_bridge_descriptors_known() is wrong because it counts cached
 bridges, and we might not have any cached descriptors, or we might have
 some of the wrong type
 * using num_bridges_usable() > 0 is wrong because it counts usable
 bridges, and we might not have any marked as usable

 Now I understand this issue, I'm going to review all my changes in #24392
 to make sure I chose the right function out of these three different
 functions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24486 [Core Tor/Tor]: Mark all bridges as up on application activity (was: Retry bridge descriptor downloads on application activity)

[Tor Bug Tracker & Wiki]

#24486: Mark all bridges as up on application activity
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  regression, tor-bridge-client,   |  Actual Points:
  s8-errors  |
Parent ID:  #24367   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Old description:

> If circuit_get_open_circ_or_launch() or its callers don't already retry
> bridge descriptor downloads, we should make them do so.
>
> A good way to do this is to:
> * modify the bridge state so we're using the bootstrapping schedule, then
> * reset the download statuses on all bridges.

New description:

 If circuit_get_open_circ_or_launch() or its callers don't already mark all
 bridges as up, we should make them do so.

 A good way to do this is to:
 * modify the bridge state so we're using the bootstrapping schedule, then
 * reset the download statuses on all bridges, and
 * reset the guard state on all the bridges (?).

--

Comment (by teor):

 Fixed the description and title.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs