Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Onionoo 1.11.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Moving the specification part to #25476 and closing this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Onionoo 1.11.0
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+
Changes (by karsten):

 * milestone:   => Onionoo 1.11.0


Comment:

 This will be part of the next milestone.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+-
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+-

Comment (by karsten):

 Great! Pushed to master together with another commit that bumps the
 protocol version to 5.1. Not closing yet, because we'll still need to
 merge the metrics-web patch when we put out the next Onionoo release.
 Leaving as merge_ready.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+-
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+-
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Onionoo changes look fine and pass all tests and checks.  The protocol
 description makes sense.
 Always good to simplify things when possible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+--
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+--
Changes (by irl):

 * reviewer:   => iwakeh


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+--
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * reviewer:  iwakeh =>


Comment:

 Relay Search is now assuming that nicknames are always present.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+--
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+--
Changes (by karsten):

 * reviewer:   => iwakeh


Comment:

 Okay, that leaves the Onionoo branch for review, which is probably
 iwakeh's part. Setting them as reviewer.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+--
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 The patch for metrics-web looks to be what I was expecting.

 Relay Search does not actually use the summary documents anymore, and
 instead only makes one fetch for the details document (instead of the
 summary document followed by n fetches of details documents).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+--
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 Please review
 
[https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-24494&id=81c72b0531ecc474bfc92afcb62e4fb78348d2d8
 commit 81c72b0 in my Onionoo task-24494 branch] and
 [https://gitweb.torproject.org/karsten/metrics-
 web.git/commit/?h=task-24494&id=d2178c350256563cb72d6c802be6285d8c2b5d7c
 commit d2178c3 in my metrics-web task-24494 branch]. Yet untested, except
 for unit tests.

 irl, if these reviews go through, you can safely assume that nickname will
 always be present for Relay Search. In fact, you can already do that for
 details documents, just not for summary documents. But feel free to wait
 for this change and new protocol version 5.1 to be deployed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+--
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Don't assume it just yet. But I'll take that question as a request and
 will try to make it so.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+--
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 Can I safely assume that nickname will always be present for Relay Search?
 This means I get to strip out a conditional and make the results table a
 little faster.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+--
 Reporter:  irl  |  Owner:  karsten
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * owner:  metrics-team => karsten
 * status:  new => accepted


Comment:

 I'll look into this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+--
 Reporter:  irl  |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Agreed, we should take out that optimization. It seemed like a good idea
 to save some bandwidth at the beginning, but we added so many more fields
 that this one doesn't really matter anymore. Reducing complexity seems
 more important. Let's do it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24494 [Metrics/Onionoo]: Specification says nickname is optional in documents but it's always there

[Tor Bug Tracker & Wiki]

#24494: Specification says nickname is optional in documents but it's always 
there
-+--
 Reporter:  irl  |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 Example:

 https://onionoo.torproject.org/details?search=Unnamed&limit=4&fields=nickname

 Specification says:

 > Relay nickname consisting of 1–19 alphanumerical characters. Omitted if
 the relay nickname is "Unnamed".

 I think I would prefer to fix the specification than to fix the Onionoo
 behaviour, as it's useful to have only one code path in Relay Search
 instead of more code paths depending on whether or not the field is
 present.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs