Re: [tor-bugs] #24608 [Core Tor/Tor]: Update our Cargo.lock file to remove the deprecated and removed [root] section

[Tor Bug Tracker & Wiki]

#24608: Update our Cargo.lock file to remove the deprecated and removed [root]
section
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.6-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  rust, cargo, rust-pilot, tor-ci  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by isis):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 This was fixed upstream and appears to no longer be necessary. Patches for
 updating dependencies (and maintaining them) are in #25310.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24608 [Core Tor/Tor]: Update our Cargo.lock file to remove the deprecated and removed [root] section

[Tor Bug Tracker & Wiki]

#24608: Update our Cargo.lock file to remove the deprecated and removed [root]
section
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.6-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, cargo, rust-pilot, tor-ci  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-

Comment (by isis):

 Carol Nichols and Alex Crichton seemed to have tracked down the
 regression, which was in part triggered by our use of `$CARGO_HOME` being
 ''inside'' the cargo workspace (trying very hard to not make a "THE BUGS
 ARE COMING FROM INSIDE THE `$HOME`" joke and failing). The issue for that
 is [https://github.com/rust-lang/cargo/issues/4815 here]. It should be in
 a nightly soon.

 In the meantime, Alex suggested we remove the `CARGO_HOME` portion of the
 `src/rust/target/release/@TOR_RUST_STATIC_NAME@` directive in
 `src/rust/tor_rust/include.am`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24608 [Core Tor/Tor]: Update our Cargo.lock file to remove the deprecated and removed [root] section

[Tor Bug Tracker & Wiki]

#24608: Update our Cargo.lock file to remove the deprecated and removed [root]
section
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.6-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, cargo, rust-pilot, tor-ci  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-

Comment (by Sebastian):

 One of the original goals was to build with 1.14 (because that's available
 in Debian). Did we lose that along the way? Maybe we can provide both
 Cargo files and switch them out depending on the toolchain?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24608 [Core Tor/Tor]: Update our Cargo.lock file to remove the deprecated and removed [root] section

[Tor Bug Tracker & Wiki]

#24608: Update our Cargo.lock file to remove the deprecated and removed [root]
section
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.6-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, cargo, rust-pilot, tor-ci  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-

Comment (by isis):

 Replying to [comment:1 nickm]:
 > fwiw, I am generally not backporting rust stuff, on the theory that
 anybody who wants rust experience should really be sticking with the
 latest and greatest.
 >
 > (Edited to add: That is to say, I'm not treating "rust won't build" as a
 must-fix bug in anything older than 0.3.2.)

 Understood. This means that, in order to build the 0.3.1.x and 0.3.0.x
 series, from now on, you'll need to get ''an older'' nightly rust
 compiler.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24608 [Core Tor/Tor]: Update our Cargo.lock file to remove the deprecated and removed [root] section

[Tor Bug Tracker & Wiki]

#24608: Update our Cargo.lock file to remove the deprecated and removed [root]
section
-+-
 Reporter:  isis |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.6-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, cargo, rust-pilot, tor-ci  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by isis):

 * keywords:   => rust, cargo, rust-pilot, tor-ci


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24608 [Core Tor/Tor]: Update our Cargo.lock file to remove the deprecated and removed [root] section

[Tor Bug Tracker & Wiki]

#24608: Update our Cargo.lock file to remove the deprecated and removed [root]
section
--+
 Reporter:  isis  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.6-alpha
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor8-can
--+

Comment (by nickm):

 fwiw, I am generally not backporting rust stuff, on the theory that
 anybody who wants rust experience should really be sticking with the
 latest and greatest

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24608 [Core Tor/Tor]: Update our Cargo.lock file to remove the deprecated and removed [root] section

[Tor Bug Tracker & Wiki]

#24608: Update our Cargo.lock file to remove the deprecated and removed [root]
section
--+
 Reporter:  isis  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.6-alpha
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:  Sponsor8-can  |
--+
 This is [https://travis-ci.org/tlyu/tor/jobs/315398995 causing build
 errors on Travis], which picked up the newest cargo nightly a week ago. As
 pointed out by Sebastian, the error appears to be due to
 [https://github.com/rust-lang/cargo/issues/4563 cargo issue #4563], which
 completely removed the `[root]` section of Cargo.lock files. Often,
 historically, the `[root]` section was used with an arbitrary non-existent
 crate, before cargo workspaces were implemented. However, our Cargo.lock
 file contains not only a `[root]`, but one which points to a non-arbitrary
 crate, `tor_util`. IIUC, we'll just need to remove that section.

 (While we're at it, we may want to update to the newest libc dependency.)

 I think we'll need to backport this to 0.3.0.x, since no newer cargos will
 build something with a `[root]` section.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs