Re: [tor-bugs] #24725 [Core Tor/Fallback Scripts]: Add a format version number to the fallback file

2018-01-03 Thread Tor Bug Tracker & Wiki
#24725: Add a format version number to the fallback file
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  merge_ready
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.3.x-final
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:
 Keywords:  fallback, review-group-28  |  Actual Points:
Parent ID:  #22271 | Points:  0.2
 Reviewer: |Sponsor:
---+---
Changes (by pastly):

 * status:  needs_review => merge_ready


Comment:

 Version number is added. LGTM, but make sure all `fallback-format-2-v4`
 tickets are merge_ready.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24725 [Core Tor/Fallback Scripts]: Add a format version number to the fallback file

2018-01-03 Thread Tor Bug Tracker & Wiki
#24725: Add a format version number to the fallback file
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.3.x-final
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:
 Keywords:  fallback, review-group-28  |  Actual Points:
Parent ID:  #22271 | Points:  0.2
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * keywords:  fallback => fallback, review-group-28
 * status:  assigned => needs_review


Comment:

 Oops, this was meant to be in needs review with the other tickets on this
 branch.
 Sticking it in review-group-28, because they'll be reviewed together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24725 [Core Tor/Fallback Scripts]: Add a format version number to the fallback file

2017-12-23 Thread Tor Bug Tracker & Wiki
#24725: Add a format version number to the fallback file
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.3.x-final
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal | Resolution:
 Keywords:  fallback   |  Actual Points:
Parent ID:  #22271 | Points:  0.2
 Reviewer: |Sponsor:
---+---

Comment (by teor):

 See fallback-format-2-v2, which also adds a delimiter at the end of every
 entry.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #24725 [Core Tor/Fallback Scripts]: Add a format version number to the fallback file

2017-12-23 Thread Tor Bug Tracker & Wiki
#24725: Add a format version number to the fallback file
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.3.x-final
Component:  Core Tor/Fallback Scripts  |Version:
 Severity:  Normal |   Keywords:  fallback
Actual Points: |  Parent ID:  #22271
   Points:  0.2|   Reviewer:
  Sponsor: |
---+---
 atagar asked for this, and it's a good idea.

 Let's use semantic versioning:
 * major versions are for incompatible changes, like removing non-optional
 fields
 * minor versions are for compatible changes, like adding fields
 * patch versions are for bug fixes, like changing an incorrectly-formatted
 header comment

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs