Re: [tor-bugs] #25008 [Core Tor/Tor]: Call protocol_list_supports_protocol less often to save time and allocation

[Tor Bug Tracker & Wiki]

#25008: Call protocol_list_supports_protocol less often to save time and 
allocation
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  032-backport?, malloc, performance,  |  implemented
  protover, review-group-31  |  Actual Points:
Parent ID:  #23777   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-

Comment (by teor):

 This patch triggers a crash on authorities when a relay stops advertising
 a protocol list (#25415).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25008 [Core Tor/Tor]: Call protocol_list_supports_protocol less often to save time and allocation

[Tor Bug Tracker & Wiki]

#25008: Call protocol_list_supports_protocol less often to save time and 
allocation
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  032-backport?, malloc, performance,  |  implemented
  protover, review-group-31  |  Actual Points:
Parent ID:  #23777   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25008 [Core Tor/Tor]: Call protocol_list_supports_protocol less often to save time and allocation

[Tor Bug Tracker & Wiki]

#25008: Call protocol_list_supports_protocol less often to save time and 
allocation
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  032-backport?, malloc, performance,  |  Actual Points:
  protover, review-group-31  |
Parent ID:  #23777   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 lgtm!

 Good stuff.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25008 [Core Tor/Tor]: Call protocol_list_supports_protocol less often to save time and allocation

[Tor Bug Tracker & Wiki]

#25008: Call protocol_list_supports_protocol less often to save time and 
allocation
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  032-backport?, malloc, performance,  |  Actual Points:
  protover, review-group-31  |
Parent ID:  #23777   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I've fixed that issue, and added a fix for #25105.  (See also #25105).
 I've also added a fix for a unit test that wasn't passing any more.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25008 [Core Tor/Tor]: Call protocol_list_supports_protocol less often to save time and allocation

[Tor Bug Tracker & Wiki]

#25008: Call protocol_list_supports_protocol less often to save time and 
allocation
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  032-backport?, malloc, performance,  |  Actual Points:
  protover, review-group-31  |
Parent ID:  #23777   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * reviewer:   => dgoulet


Comment:

 Oh hello wonderful patch! I very much like this! It adds a nice semantic
 to the code and optimize it at the same time.

 I may ask if we can get the documentation of which protocol version value
 each member of `protover_summary_flags_t` is for. For instance,
 `supports_ed25519_hs_intro` requires ` HSIntro=4` but half of them aren't
 documented. And easy map with the spec would rock.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25008 [Core Tor/Tor]: Call protocol_list_supports_protocol less often to save time and allocation

[Tor Bug Tracker & Wiki]

#25008: Call protocol_list_supports_protocol less often to save time and 
allocation
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  032-backport? malloc performance |  Actual Points:
  protover   |
Parent ID:  #23777   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 Proposed change in branch `bug25008`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25008 [Core Tor/Tor]: Call protocol_list_supports_protocol less often to save time and allocation

[Tor Bug Tracker & Wiki]

#25008: Call protocol_list_supports_protocol less often to save time and 
allocation
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.3.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  032-backport? malloc performance
 Severity:  Normal   |  protover
Actual Points:   |  Parent ID:  #23777
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 This function appeared on the heap profile of #23777, and there's no
 reason it should have done so.  It appears to have been getting called by
 circuit_extend(), which suggests that we have some dodgy logic somewhere.
 I blame node_supports_ed25519_link_allocation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs