Re: [tor-bugs] #25089 [Applications/Tor Launcher]: Tor bundle: Special characters not escaped in proxy password

[Tor Bug Tracker & Wiki]

#25089: Tor bundle: Special characters not escaped in proxy password
-+-
 Reporter:  ro0ter   |  Owner:  brade
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  TorBrowserTeam201802R, tbb-  |  Actual Points:
  backported |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201802R, tbb-backport => TorBrowserTeam201802R,
 tbb-backported


Comment:

 That's commit fa8590a497b492f6da62bbf7009735a17e17ec21 on `maint-0.2.14.4`
 and will be available in 7.5.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25089 [Applications/Tor Launcher]: Tor bundle: Special characters not escaped in proxy password

[Tor Bug Tracker & Wiki]

#25089: Tor bundle: Special characters not escaped in proxy password
-+
 Reporter:  ro0ter   |  Owner:  brade
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Launcher|Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  TorBrowserTeam201802R, tbb-backport  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by gk):

 * keywords:  TorBrowserTeam201802R => TorBrowserTeam201802R, tbb-backport


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25089 [Applications/Tor Launcher]: Tor bundle: Special characters not escaped in proxy password

[Tor Bug Tracker & Wiki]

#25089: Tor bundle: Special characters not escaped in proxy password
---+
 Reporter:  ro0ter |  Owner:  brade
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Major  | Resolution:  fixed
 Keywords:  TorBrowserTeam201802R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by ro0ter):

 The `extensions.torlauncher.prompt_at_startup` inside the `prefs.js` file
 is what I was missing, thank you mcs :)

 I hereby validate the fix as well, now I won't have to ask colleagues for
 their proxy usr/pwd anymore :)

 Good work! Thank you very much!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25089 [Applications/Tor Launcher]: Tor bundle: Special characters not escaped in proxy password

[Tor Bug Tracker & Wiki]

#25089: Tor bundle: Special characters not escaped in proxy password
---+
 Reporter:  ro0ter |  Owner:  brade
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Major  | Resolution:  fixed
 Keywords:  TorBrowserTeam201802R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by mcs):

 Replying to [comment:13 ro0ter]:
 > mcs, I can`t make it work since the tor launcher detects my change and
 does not agree... I`d rather not attach a screenshot, not useful, but
 here`s the text:
 > ...

 I forgot that you will be prompted (since you have not previously
 connected). To avoid the prompt, set
 `extensions.torlauncher.prompt_at_startup` to `false` by ensuring that the
 following line in present in your `prefs.js` file:
  user_pref("extensions.torlauncher.prompt_at_startup", false);
 The `prefs.js` file is located in your browser profile. The path is
 `Browser\TorBrowser\Data\Browser\profile.default\prefs.js.

 Replying to [comment:14 ro0ter]:
 > One more question: what about password containing both double quotes and
 pound?
 Our code already knew how to escape double quotes. You can use `\"` to
 include them in your torrc, e.g.,
  HTTPSProxyAuthenticator "mcs:secret\"quote\"#1"

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25089 [Applications/Tor Launcher]: Tor bundle: Special characters not escaped in proxy password

[Tor Bug Tracker & Wiki]

#25089: Tor bundle: Special characters not escaped in proxy password
---+
 Reporter:  ro0ter |  Owner:  brade
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Major  | Resolution:  fixed
 Keywords:  TorBrowserTeam201802R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by ro0ter):

 One more question: what about password containing both double quotes and
 pound?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25089 [Applications/Tor Launcher]: Tor bundle: Special characters not escaped in proxy password

[Tor Bug Tracker & Wiki]

#25089: Tor bundle: Special characters not escaped in proxy password
---+
 Reporter:  ro0ter |  Owner:  brade
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Major  | Resolution:  fixed
 Keywords:  TorBrowserTeam201802R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by ro0ter):

 mcs, I can`t make it work since the tor launcher detects my change and
 does not agree... I`d rather not attach a screenshot, not useful, but
 here`s the text:

 :: Connect to Tor ::
 Tor|Browser

 You have configured Tor bridges or you have entered local proxy settings.
 To make a direct connection to the Tor network, these settings must be
 removed.

 [ < Back ] [ Remove Settings and Connect ]

 For assistance, visit torproject.org/about/contact.html#support
 --
   [ Exit ]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25089 [Applications/Tor Launcher]: Tor bundle: Special characters not escaped in proxy password

[Tor Bug Tracker & Wiki]

#25089: Tor bundle: Special characters not escaped in proxy password
---+
 Reporter:  ro0ter |  Owner:  brade
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Major  | Resolution:  fixed
 Keywords:  TorBrowserTeam201802R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks. Merge to `master` (commit
 fa8590a497b492f6da62bbf7009735a17e17ec21). I think the change is small
 enough that we'll include it directly in the next stable as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25089 [Applications/Tor Launcher]: Tor bundle: Special characters not escaped in proxy password

[Tor Bug Tracker & Wiki]

#25089: Tor bundle: Special characters not escaped in proxy password
---+--
 Reporter:  ro0ter |  Owner:  brade
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Major  | Resolution:
 Keywords:  TorBrowserTeam201802R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by mcs):

 * keywords:   => TorBrowserTeam201802R
 * status:  assigned => needs_review


Comment:

 Here is a fix:
 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug25089-01&id=fa8590a497b492f6da62bbf7009735a17e17ec21

 ro0ter, you can work around this bug by editing the torrc file that is
 part of your Tor Browser installation. You will want to ensure that your
 torrc includes lines that look like the following:
  HTTPSProxy 1.2.3.4:80
  HTTPSProxyAuthenticator "mcs:secret#1"
 The `HTTPSProxy` value should be `host:port` and the value for
 `HTTPSProxyAuthenticator` should be `"username:password"`.

 Note that if you later use our GUI to make changes, your manual changes
 will be overwritten.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25089 [Applications/Tor Launcher]: Tor bundle: Special characters not escaped in proxy password

[Tor Bug Tracker & Wiki]

#25089: Tor bundle: Special characters not escaped in proxy password
---+--
 Reporter:  ro0ter |  Owner:  brade
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Major  | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gk):

 * cc: brade (removed)
 * status:  new => assigned
 * owner:  tbb-team => brade


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25089 [Applications/Tor Launcher]: Tor bundle: Special characters not escaped in proxy password

[Tor Bug Tracker & Wiki]

#25089: Tor bundle: Special characters not escaped in proxy password
---+--
 Reporter:  ro0ter |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Major  | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gk):

 * component:  Core Tor/Tor => Applications/Tor Launcher


Comment:

 Looking at
 {{{
 const kSafeCharRE = /^[\x21\x23-\x7E]*$/;
 }}}
 in `_strEscape()` we should try to see if that's a TorLauncher bug first,
 I guess.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs