Re: [tor-bugs] #25397 [Metrics/Website]: Cut off lower number of expected clients at 0

[Tor Bug Tracker & Wiki]

#25397: Cut off lower number of expected clients at 0
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+--
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks for checking! Merged and deployed. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25397 [Metrics/Website]: Cut off lower number of expected clients at 0

[Tor Bug Tracker & Wiki]

#25397: Cut off lower number of expected clients at 0
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+--
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Looks fine and the second commit is very useful, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25397 [Metrics/Website]: Cut off lower number of expected clients at 0

[Tor Bug Tracker & Wiki]

#25397: Cut off lower number of expected clients at 0
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:  iwakeh   |Sponsor:
-+--
Changes (by karsten):

 * reviewer:   => iwakeh


Comment:

 Optimistically assigning to iwakeh's review queue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25397 [Metrics/Website]: Cut off lower number of expected clients at 0

[Tor Bug Tracker & Wiki]

#25397: Cut off lower number of expected clients at 0
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  new => needs_review


Comment:

 Please review [https://gitweb.torproject.org/karsten/metrics-
 web.git/commit/?h=task-25397=ec26e2a77fcbb5da16eb7d7d77c1f773d2b83ce2
 commit ec26e2a in my task-25397 branch] with a trivial fix. And while
 we're at it, please also review [https://gitweb.torproject.org/karsten
 /metrics-
 web.git/commit/?h=task-25397=9441c6b91e764052b1c167bc614274f283acd4bd
 subsequent commit 9441c6b in the same branch] which removes code that we
 don't use.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25397 [Metrics/Website]: Cut off lower number of expected clients at 0

[Tor Bug Tracker & Wiki]

#25397: Cut off lower number of expected clients at 0
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 We should avoid negative numbers in clients.csv and in per-graph CSV files
 based on it.

 Take this graph as example:

 https://metrics.torproject.org/userstats-relay-
 country.html?start=2013-08-15=2013-08-31=dk=on

 The corresponding CSV file is:

 {{{
 date,users,downturns,upturns,lower,upper
 2013-08-15,2419,FALSE,FALSE,1509,3400
 2013-08-16,2417,FALSE,FALSE,1530,3526
 2013-08-17,2583,FALSE,FALSE,1888,3593
 2013-08-18,2625,FALSE,FALSE,2099,3451
 2013-08-19,2631,FALSE,FALSE,1950,3865
 2013-08-20,2998,FALSE,FALSE,-307,8058
 2013-08-21,3429,FALSE,FALSE,-2158,12097
 2013-08-22,4161,FALSE,FALSE,-5815,19493
 2013-08-23,4910,FALSE,FALSE,-11092,29505
 2013-08-24,5387,FALSE,FALSE,-14669,35722
 2013-08-25,5899,FALSE,FALSE,-16103,38944
 2013-08-26,6115,FALSE,FALSE,-18394,42370
 2013-08-27,6486,FALSE,FALSE,-8958,29056
 2013-08-28,7213,FALSE,FALSE,-4772,23752
 2013-08-29,7950,FALSE,FALSE,-,19506
 2013-08-30,8844,FALSE,FALSE,1660,17111
 2013-08-31,9966,FALSE,FALSE,2088,19165
 }}}

 We can just cut the lower number at 0. Like in the graph.

 We could do it in write_userstats_relay_country() or in the clients
 module. The first is at lot easier to fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs