[tor-bugs] #25449 [Applications/Tor Browser]: Bump snowflake/go-webrtc for trac 21312

[Tor Bug Tracker & Wiki]

#25449: Bump snowflake/go-webrtc for trac 21312
--+---
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  snowflake
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+---
 Please see the attached.

 Incidentally, this should also fix,
 https://trac.torproject.org/projects/tor/ticket/24203#comment:11

 However, note that this now means there won't be a `snowflake.log`
 anymore, unless we provide a path to `-log` in the `torrc-defaults-
 appendix`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25449 [Applications/Tor Browser]: Bump snowflake/go-webrtc for trac 21312

[Tor Bug Tracker & Wiki]

#25449: Bump snowflake/go-webrtc for trac 21312
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by arlolra):

 * Attachment "0001-Bump-snowflake-go-webrtc-for-trac-21312.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25449 [Applications/Tor Browser]: Bump snowflake/go-webrtc for trac 21312

[Tor Bug Tracker & Wiki]

#25449: Bump snowflake/go-webrtc for trac 21312
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Replying to [ticket:25449 arlolra]:
 > However, note that this now means there won't be a `snowflake.log`
 anymore, unless we provide a path to `-log` in the `torrc-defaults-
 appendix`

 I think that's fine or do you think we should make it easier for debugging
 for now and add that flag?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25449 [Applications/Tor Browser]: Bump snowflake/go-webrtc for trac 21312

[Tor Bug Tracker & Wiki]

#25449: Bump snowflake/go-webrtc for trac 21312
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arlolra):

 Given #21304 is still open, it's probably prudent to leave it off for the
 time being.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25449 [Applications/Tor Browser]: Bump snowflake/go-webrtc for trac 21312

[Tor Bug Tracker & Wiki]

#25449: Bump snowflake/go-webrtc for trac 21312
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by dcf):

 I'm fine with no logging by default. If someone has a problem, hopefully
 we can ask them to turn on logging.

 My removal of default logging in [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=12922a232ba63bd8d94c92ced32e23aa2fb055ed
 12922a232b] was arguably rash: while obviously eventually we would have to
 stop logging by default, requiring a `-log` option with a path prevents
 writing to a log file that's inside the `pt_state` directory, which, in
 sandbox situations, may be the only place the transport plugin is allowed
 to write. obfs4proxy just has a boolean option `-enableLogging` that
 doesn't take a path, unconditionally writing to `pt_state/obfs4proxy.log`.
 Perhaps something like that would be better, even if it's less convenient
 for development.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25449 [Applications/Tor Browser]: Bump snowflake/go-webrtc for trac 21312

[Tor Bug Tracker & Wiki]

#25449: Bump snowflake/go-webrtc for trac 21312
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arlolra):

 > Perhaps something like that would be better, even if it's less
 convenient for development.

 Maybe just add another flag, `-logToStateDir` or the like

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25449 [Applications/Tor Browser]: Bump snowflake/go-webrtc for trac 21312

[Tor Bug Tracker & Wiki]

#25449: Bump snowflake/go-webrtc for trac 21312
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arlolra):

 {{{
 --- a/client/snowflake.go
 +++ b/client/snowflake.go
 @@ -10,6 +10,7 @@ import (
 "net"
 "os"
 "os/signal"
 +   "path"
 "strings"
 "sync"
 "syscall"
 @@ -126,12 +127,22 @@ func main() {
 brokerURL := flag.String("url", "", "URL of signaling broker")
 frontDomain := flag.String("front", "", "front domain")
 logFilename := flag.String("log", "", "name of log file")
 +   logToStateDir := flag.Bool("logToStateDir", false, "supersedes log
 file")
 max := flag.Int("max", DefaultSnowflakeCapacity,
 "capacity for number of multiplexed WebRTC peers")
 flag.Parse()

 webrtc.SetLoggingVerbosity(1)
 log.SetFlags(log.LstdFlags | log.LUTC)
 +
 +   if *logToStateDir {
 +   stateDir, err := pt.MakeStateDir()
 +   if err != nil {
 +   log.Fatal(err)
 +   }
 +   *logFilename = path.Join(stateDir, "snowflake.log")
 +   }
 +
 if *logFilename != "" {
 logFile, err := os.OpenFile(*logFilename,
 os.O_CREATE|os.O_APPEND|os.O_WRONLY, 0600)
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25449 [Applications/Tor Browser]: Bump snowflake/go-webrtc for trac 21312

[Tor Bug Tracker & Wiki]

#25449: Bump snowflake/go-webrtc for trac 21312
--+-
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by dcf):

 * status:  new => merge_ready


Comment:

 Replying to [comment:4 arlolra]:
 > > Perhaps something like that would be better, even if it's less
 convenient for development.
 >
 > Maybe just add another flag, `-logToStateDir` or the like

 I opened #25471 to talk about the logging issue separately.

 Per comment:2, I think we're fine to go ahead with disabled logging for
 now. attachment:0001-Bump-snowflake-go-webrtc-for-trac-21312.patch looks
 good to me.

 People are going to like this change. I'm using it right now and it's
 light years better than it was.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25449 [Applications/Tor Browser]: Bump snowflake/go-webrtc for trac 21312

[Tor Bug Tracker & Wiki]

#25449: Bump snowflake/go-webrtc for trac 21312
--+
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  defect| Status:
  |  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  snowflake, TorBrowserTeam201803R  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * status:  merge_ready => needs_review
 * keywords:  snowflake => snowflake, TorBrowserTeam201803R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25449 [Applications/Tor Browser]: Bump snowflake/go-webrtc for trac 21312

[Tor Bug Tracker & Wiki]

#25449: Bump snowflake/go-webrtc for trac 21312
--+--
 Reporter:  arlolra   |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  snowflake, TorBrowserTeam201803R  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Applied to `master` with commit 42720c512520ecef5437d23e405d8ce011764661,
 thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs