Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe, tor-  |
  bwauth |
Parent ID:  #25925   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by juga):

 * keywords:
 fast-fix, 034-backport-maybe, 033-backport-maybe, 032-backport-maybe,
 031-backport-maybe, 029-backport-maybe, tor-dirauth
 =>
 fast-fix, 034-backport-maybe, 033-backport-maybe, 032-backport-maybe,
 031-backport-maybe, 029-backport-maybe, tor-bwauth


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe, tor-  |
  dirauth|
Parent ID:  #25925   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 All directory authorities that vote on bandwidths are running 0.3.3 or
 later. torflow and sbws do not produce lines with node_id at the end. (And
 all other generators should be able to obey this constraint.)

 So I don't think we need to backport this fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe, tor-  |
  dirauth|
Parent ID:  #25925   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe, tor-  |
  dirauth|
Parent ID:  #25925   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe, tor-  |
  dirauth|
Parent ID:  #25925   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.3.x-final


Comment:

 I've squashed this as `bug26004_029_squashed`, and merged it to master.
 Marking for possible backport!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe, tor-  |
  dirauth|
Parent ID:  #25925   | Points:
 Reviewer:  nickm|Sponsor:
-+-

Comment (by juga):

 Feel free to squash, if needed for the log to looks better

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe, tor-  |
  dirauth|
Parent ID:  #25925   | Points:
 Reviewer:  nickm|Sponsor:
-+-

Comment (by juga):

 Thanks for the review. Maybe log_warn should be lower, since in the spec
 we have so far we would allow files with empty bw lines?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe, tor-  |
  dirauth|
Parent ID:  #25925   | Points:
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Two changes needed here:

   * If the input to this function is the empty string, `strlen(line) - 1`
 will underflow.
   * This branch needs a changes file.

 I've made both of these changes in my own branch (with the same name as
 yours) -- please let me know if you agree with them, and I'll merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe, tor-  |
  dirauth|
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by juga):

 Changed what you suggested.
 Yes, i meant to based in maint-0.2.9, isn't based on?
 I haven't renamed the branch, since probably should create another
 squashing commits.
 Opened PR following the naming proposed in the wiki
 (org/process/TorOnTrac).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe, tor-  |
  dirauth|
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by juga):

 * keywords:
 fast-fix, 034-backport-maybe, 033-backport-maybe, 032-backport-maybe,
 031-backport-maybe, 029-backport-maybe
 =>
 fast-fix, 034-backport-maybe, 033-backport-maybe, 032-backport-maybe,
 031-backport-maybe, 029-backport-maybe, tor-dirauth
 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe|
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => needs_revision


Comment:

 That looks like it will work, and it seems like it passes the tests.
 The checks are in a weird order, but we can fix that in a rewrite.

 In our code style, we use character constants instead of integers. So 10
 is '\n' and 0 is '\0'.

 When we name branches, we call them after the tor branch they are based
 on.
 This branch is based on master, so it should not have "maint-0.2.9" in the
 name.
 Did you mean to base it on maint-0.2.9?

 You can use "029" in branch names rather than "maint-0.2.9" if you want.

 When you want a review on a ticket, you can put it in "needs_review".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe|
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by juga):

 Could this be a solution?
 
https://github.com/torproject/tor/compare/master...juga0:bug26004_maint-0.2.9_bw_newline

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, 034-backport-maybe, 033|  Actual Points:
  -backport-maybe, 032-backport-maybe, 031   |
  -backport-maybe, 029-backport-maybe|
Parent ID:  #25925   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  fast-fix =>
 fast-fix, 034-backport-maybe, 033-backport-maybe, 032-backport-maybe,
 031-backport-maybe, 029-backport-maybe


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26004 [Core Tor/Tor]: Allow Tor to accept node_id at the end of a bandwidth file line

[Tor Bug Tracker & Wiki]

#26004: Allow Tor to accept node_id at the end of a bandwidth file line
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  fast-fix
Actual Points:|  Parent ID:  #25925
   Points:|   Reviewer:
  Sponsor:|
--+
 Tor doesn't accept node_id at the end of a line, because the trailing
 newline is part of the string at the end of the line. To fix this issue,
 we should make newline one of the separators in the string token list.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs