Re: [tor-bugs] #26054 [Applications/Tor Browser]: Make sure to create incrementals from previously signed MAR files

[Tor Bug Tracker & Wiki]

#26054: Make sure to create incrementals from previously signed MAR files
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805R, tbb-backported  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, boklm201805, TorBrowserTeam201805R => tbb-rbm,
 boklm201805, TorBrowserTeam201805R, tbb-backported


Comment:

 Backported to `maint-7.5` as commit
 6df6be50faee48c807e8ca257e9179998aa8bc61.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26054 [Applications/Tor Browser]: Make sure to create incrementals from previously signed MAR files

[Tor Bug Tracker & Wiki]

#26054: Make sure to create incrementals from previously signed MAR files
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good! Cherry-picked to `master` (commit
 0bfae091fa18b6bca05de2cac42bacac47381876).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26054 [Applications/Tor Browser]: Make sure to create incrementals from previously signed MAR files

[Tor Bug Tracker & Wiki]

#26054: Make sure to create incrementals from previously signed MAR files
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm => tbb-rbm, boklm201805, TorBrowserTeam201805R
 * status:  new => needs_review


Comment:

 There is a patch for this in branch `bug_26054`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26054=b2de50ce48755190259c7d274c6ce65317ccb0b1

 This branch is based on the commit for #26059, so it will have to be
 rebased if #26059 needs some revision.

 I checked that if one of the osx64 mar files from the previous version is
 not code-signed, it fails with an error.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26054 [Applications/Tor Browser]: Make sure to create incrementals from previously signed MAR files

[Tor Bug Tracker & Wiki]

#26054: Make sure to create incrementals from previously signed MAR files
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Description changed by gk:

Old description:

> When creating incremental files we check right now only that MAR files
> from previous versions specified in `torbrowser_incremental_from` are
> *available*. However, this can happen if one only has built those
> previous versions with MAR files still locally available. In that case,
> though, we'll create the wrong MAR files for macOS as those previously
> built MAR files do not contain the content signing bits.
>
> We could be smarter and check whether the previously built MAR files are
> signed and only use them in that case for generating the incremental MAR
> files. Otherwise we would discard them and download the signed ones, as
> we do if no previously built MAR files are available locally.

New description:

 When creating incremental MAR files we check right now only that MAR files
 from previous versions specified in `torbrowser_incremental_from` are
 *available*. However, this can happen if one only has built those previous
 versions with MAR files still locally available. In that case, though,
 we'll create the wrong MAR files for macOS as those previously built MAR
 files do not contain the content signing bits.

 We could be smarter and check whether the previously built MAR files are
 signed and only use them in that case for generating the incremental MAR
 files. Otherwise we would discard them and download the signed ones, as we
 do if no previously built MAR files are available locally.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26054 [Applications/Tor Browser]: Make sure to create incrementals from previously signed MAR files

[Tor Bug Tracker & Wiki]

#26054: Make sure to create incrementals from previously signed MAR files
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-rbm
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 When creating incremental files we check right now only that MAR files
 from previous versions specified in `torbrowser_incremental_from` are
 *available*. However, this can happen if one only has built those previous
 versions with MAR files still locally available. In that case, though,
 we'll create the wrong MAR files for macOS as those previously built MAR
 files do not contain the content signing bits.

 We could be smarter and check whether the previously built MAR files are
 signed and only use them in that case for generating the incremental MAR
 files. Otherwise we would discard them and download the signed ones, as we
 do if no previously built MAR files are available locally.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs