Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201901R,  |  Actual Points:
  boklm201901|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good, thanks! Merge to `master` (commit
 5631b327ab3654af5f2b329cf46fd67921004f41).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901R,  |  Actual Points:
  boklm201901|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201901, boklm201901 => tbb-rbm,
 TorBrowserTeam201901R, boklm201901
 * status:  needs_revision => needs_review


Comment:

 There is a new version of the patch in branch `bug_26148_v7`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26148_v7=5631b327ab3654af5f2b329cf46fd67921004f41

 With the following changes:
 - we are now using the patch from the GCC commit
 - there is now a comment about the relocation patch pointing to
 https://sourceware.org/bugzilla/show_bug.cgi?id=17321
 - we use the tar.xz instead of tar.bz2
 - the sed line for #10102 is removed as it is not needed since
 https://sourceware.org/git/?p=binutils-
 gdb.git;a=commit;h=8d5c4b7bfdfa5f2b40fa056132823c8e9497dc72

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  boklm201901|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, TorBrowserTeam201901R, boklm201901 => tbb-rbm,
 TorBrowserTeam201901, boklm201901


Comment:

 Replying to [comment:11 boklm]:
 > In branch `bug_26148_v6` we update binutils to 2.31.1:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26148_v6=f804709d68e9c4b3c7b606b89a8f555f21fe3e09
 >
 > I checked that the linux and windows builds are reproductible on two
 machines, and the bundles created are running correctly.

 Thanks! Testing shows this works for me. What we could do is including the
 landed libtool patch instead of the mail. The patch is at least on GCC
 master (commit 494c17dc2bf45b8155fb9a14178ab48f01bc12a8) but not in any
 release yet.

 One request: could you add
 https://sourceware.org/bugzilla/show_bug.cgi?id=17321 to the comment for
 the relocation patch so that we know this is on file at least?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901R,  |  Actual Points:
  boklm201901|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201901, boklm201811 => tbb-rbm,
 TorBrowserTeam201901R, boklm201901
 * status:  new => needs_review


Comment:

 In branch `bug_26148_v6` we update binutils to 2.31.1:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26148_v6=f804709d68e9c4b3c7b606b89a8f555f21fe3e09

 I checked that the linux and windows builds are reproductible on two
 machines, and the bundles created are running correctly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901R,  |  Actual Points:
  boklm201901|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by ld):

 ticket:16472#comment:60?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  boklm201811|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:9 ld]:
 > Replying to [comment:8 boklm]:
 > > with previous versions of binutils, the order of objects inside a `.a`
 file did not affect the output, but it is not the case anymore with more
 recent versions of binutils.
 > Bug or feature for you?
 > > I am now testing a patch to update binutils to 2.31.1.
 > Please test with the master branch instead, because of
 https://sourceware.org/ml/binutils/2019-01/msg00013.html and to avoid
 issues like https://sourceware.org/bugzilla/show_bug.cgi?id=23600.

 No, 2.31.1 is fine for now I think (if nothing explodes). We'll want to
 switch to a newer binutils before 2.32 gets released if possible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  boklm201811|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by ld):

 Replying to [comment:8 boklm]:
 > with previous versions of binutils, the order of objects inside a `.a`
 file did not affect the output, but it is not the case anymore with more
 recent versions of binutils.
 Bug or feature for you?
 > I am now testing a patch to update binutils to 2.31.1.
 Please test with the master branch instead, because of
 https://sourceware.org/ml/binutils/2019-01/msg00013.html and to avoid
 issues like https://sourceware.org/bugzilla/show_bug.cgi?id=23600.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  boklm201811|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 I have been building using `-Wl,-t` two times on one machine, and one time
 on an other one. The builds from the same machine were identical, but
 different on the second machine.

 Comparing the logs from the non maching builds, the main difference was
 the order of `.o` files included inside `libstdc++.a`. It seems that with
 previous versions of binutils, the order of objects inside a `.a` file did
 not affect the output, but it is not the case anymore with more recent
 versions of binutils.

 The reason why `libstdc++.a` is including objects in random order is that
 gcc is using an old version of libtool:
 https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01115.html

 With the libtool patch sorting the output of `find`, I am now able to get
 matching builds on different machines.

 I am now testing a patch to update binutils to 2.31.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201901,   |  Actual Points:
  boklm201811|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201805, boklm201811 => tbb-rbm,
 TorBrowserTeam201901, boklm201811
 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201805,   |  Actual Points:
  boklm201809|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 I will try a build using `-Wl,-t` to see if this can help understand the
 issue (as suggested in
 https://sourceware.org/bugzilla/show_bug.cgi?id=23466#c1).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201805,   |  Actual Points:
  boklm201807|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 I filled an upstream binutils ticket for this issue:
 https://sourceware.org/bugzilla/show_bug.cgi?id=23466

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26148 [Applications/Tor Browser]: Update binutils to a version more recent than 2.26.1

[Tor Bug Tracker & Wiki]

#26148: Update binutils to a version more recent than 2.26.1
-+-
 Reporter:  boklm|  Owner:  tbb-team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-rbm, boklm201805,
 Severity:  Normal   |  TorBrowserTeam201805
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 In #16472 we are updating binutils to 2.26.1. We are not updating it to a
 more recent version due to an issue with reproducible builds on Windows
 with later binutils versions.

 The issue seems to be caused by binutils commit
 `13e570f80cbfb299a8858ce6830e91a6cb40ab7b` (which we revert in #16472).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs