Re: [tor-bugs] #26439 [Core Tor/Tor]: Use the "commands" element of AC_CONFIG_FILES to make generated scripts executable

[Tor Bug Tracker & Wiki]

#26439: Use the "commands" element of AC_CONFIG_FILES to make generated scripts
executable
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  wontfix
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  reopened => closed
 * resolution:   => wontfix


Comment:

 Since our previous (ugly) approach worked, and this approach (though
 supported!) didn't, I'm going to call this wontfix -- but please reopen if
 you know a way around the windows issues noted above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26439 [Core Tor/Tor]: Use the "commands" element of AC_CONFIG_FILES to make generated scripts executable

[Tor Bug Tracker & Wiki]

#26439: Use the "commands" element of AC_CONFIG_FILES to make generated scripts
executable
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  reopened
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  closed => reopened
 * resolution:  implemented =>


Comment:

 Reverted this with 0742b387253f25: it seems to break appveyor, which
 produces lots of messages like:
 {{{
 chmod
 : cannot access 'link_rust.sh': No such file or directory
 chmod
 : cannot access 'contrib/dist/tor.sh': No such file or directory
 chmod
 : cannot access 'contrib/dist/torctl': No such file or directory
 chmod
 : cannot access 'scripts/maint/checkOptionDocs.pl': No such file or
 directory
 chmod
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26439 [Core Tor/Tor]: Use the "commands" element of AC_CONFIG_FILES to make generated scripts executable

[Tor Bug Tracker & Wiki]

#26439: Use the "commands" element of AC_CONFIG_FILES to make generated scripts
executable
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26439 [Core Tor/Tor]: Use the "commands" element of AC_CONFIG_FILES to make generated scripts executable

[Tor Bug Tracker & Wiki]

#26439: Use the "commands" element of AC_CONFIG_FILES to make generated scripts
executable
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Only commit `56c1fbf33f34e010` currently applies to master since the rest
 has been merged upstream I believe through another ticket.

 This lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26439 [Core Tor/Tor]: Use the "commands" element of AC_CONFIG_FILES to make generated scripts executable

[Tor Bug Tracker & Wiki]

#26439: Use the "commands" element of AC_CONFIG_FILES to make generated scripts
executable
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26439 [Core Tor/Tor]: Use the "commands" element of AC_CONFIG_FILES to make generated scripts executable

[Tor Bug Tracker & Wiki]

#26439: Use the "commands" element of AC_CONFIG_FILES to make generated scripts
executable
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+

Comment (by nickm):

 I think it was based on a bad master.  Hang on a second... I just force-
 pushed a replacement.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26439 [Core Tor/Tor]: Use the "commands" element of AC_CONFIG_FILES to make generated scripts executable

[Tor Bug Tracker & Wiki]

#26439: Use the "commands" element of AC_CONFIG_FILES to make generated scripts
executable
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * reviewer:   => dgoulet


Comment:

 This branch is failing to build on Travis. Also there are merge commit in
 it?...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26439 [Core Tor/Tor]: Use the "commands" element of AC_CONFIG_FILES to make generated scripts executable

[Tor Bug Tracker & Wiki]

#26439: Use the "commands" element of AC_CONFIG_FILES to make generated scripts
executable
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  fast-fix  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:   => fast-fix
 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26439 [Core Tor/Tor]: Use the "commands" element of AC_CONFIG_FILES to make generated scripts executable

[Tor Bug Tracker & Wiki]

#26439: Use the "commands" element of AC_CONFIG_FILES to make generated scripts
executable
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Implementation in branch `ticket26439`; PR at
 https://github.com/torproject/tor/pull/166

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26439 [Core Tor/Tor]: Use the "commands" element of AC_CONFIG_FILES to make generated scripts executable

[Tor Bug Tracker & Wiki]

#26439: Use the "commands" element of AC_CONFIG_FILES to make generated scripts
executable
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Hello71 pointed this out to me on a code review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs