Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
-+--
 Reporter:  arthuredelstein  |  Owner:  antonela
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff60-esr, TorBrowserTeam201808R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by gk):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks! Merged to `master` (commit
 e9b4af29d8acf595bd0da4253336db0783ad5b24).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
-+-
 Reporter:  arthuredelstein  |  Owner:  antonela
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  needs_review => merge_ready


Comment:

 I built and tested it and it looks good to me. Thanks, antonela and gk!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
-+-
 Reporter:  arthuredelstein  |  Owner:  antonela
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_revision => needs_review
 * keywords:  ff60-esr, TorBrowserTeam201808 => ff60-esr,
 TorBrowserTeam201808R


Comment:

 Okay, `bug_26655_v2`
 
(https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_26655_v2=e9b4af29d8acf595bd0da4253336db0783ad5b24)
 has both icons now. FWIW: I picked the grey variants in both cases (I
 already used it for the regular Torbutton icon in my `bug_26655`).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
+--
 Reporter:  arthuredelstein |  Owner:  antonela
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by antonela):

 Sorry for the delay! Tor Icon with update status here
 
https://trac.torproject.org/projects/tor/attachment/ticket/26655/26655-update.zip

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
+--
 Reporter:  arthuredelstein |  Owner:  antonela
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by antonela):

 * Attachment "26655-update.zip" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
+--
 Reporter:  arthuredelstein |  Owner:  antonela
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  ff60-esr, TorBrowserTeam201808R => ff60-esr,
 TorBrowserTeam201808


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
-+-
 Reporter:  arthuredelstein  |  Owner:  antonela
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  assigned => needs_revision


Comment:

 Replying to [comment:6 gk]:
 > Replying to [comment:4 antonela]:
 > > Hi arthur!
 > > I used the default Firefox's Photon assets to build this icon.
 > > https://design.firefox.com/icons/viewer/
 > >
 > > But seems like they are setting colors for icons elsewhere (not at the
 SVG). See this
 https://design.firefox.com/photon/visuals/iconography.html#color
 > >
 > > Anyways, I exported the Tor Button Icon again with no borders. And,
 also I included a version using `Grey 90 a80`. .zip attached here Arthur.
 Let me know!
 >
 > Looks better for me now. I pushed a branch for review:`bug_26655`
 
(https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_26655=046aab60950553764504ea2d300a2a734f96fec8).

 The icon looks good. But we also need a new version of the icon with the
 yellow warning triangle overlaid (for when
 `extensions.torbutton.updateNeeded` is true).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
-+--
 Reporter:  arthuredelstein  |  Owner:  antonela
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201807R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by gk):

 Replying to [comment:4 antonela]:
 > Hi arthur!
 > I used the default Firefox's Photon assets to build this icon.
 > https://design.firefox.com/icons/viewer/
 >
 > But seems like they are setting colors for icons elsewhere (not at the
 SVG). See this
 https://design.firefox.com/photon/visuals/iconography.html#color
 >
 > Anyways, I exported the Tor Button Icon again with no borders. And, also
 I included a version using `Grey 90 a80`. .zip attached here Arthur. Let
 me know!

 Looks better for me now. I pushed a branch for review:`bug_26655`
 
(https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_26655=046aab60950553764504ea2d300a2a734f96fec8).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
-+--
 Reporter:  arthuredelstein  |  Owner:  antonela
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201807R  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by gk):

 * keywords:  ff60-esr => ff60-esr, TorBrowserTeam201807R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
--+--
 Reporter:  arthuredelstein   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff60-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 11:23 AM Ticket #26665 (Allow searching for relays with no known
 AS/country) updated by irl
 I also now have a git.tpo repository, so the changes for Onionoo are …
 11:22 AM Ticket #26734 (Please add irl as git maintainer) created by hiro
 Irl has volunteered to help out with git issues. Can you please add …
 11:17 AM Ticket #26665 (Allow searching for relays with no known
 AS/country) updated by irl
 Status changed
 Small patch for spec: …
 6:53 AM Ticket #26367 (Consider removing tor2web mode) updated by teor
 Status changed
 ENABLE_TOR2WEB_MODE sets NON_ANONYMOUS_MODE_ENABLED. I don't think …
 6:48 AM Ticket #26712 (EVP_PKEY_HKDF not defined in libressl,
 src/lib/crypt_ops/crypto_hkdf.c ...) updated by teor
 Keywords changed
 6:47 AM Ticket #26715 (Tor 85d6b41 on FreeBSD 12-CURRENT: error: use of
 undeclared identifier ...) updated by teor
 Keywords changed
 4:52 AM Ticket #26712 (EVP_PKEY_HKDF not defined in libressl,
 src/lib/crypt_ops/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
--+--
 Reporter:  arthuredelstein   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff60-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by antonela):

 Hi arthur!
 I used the default Firefox's Photon assets to build this icon.
 https://design.firefox.com/icons/viewer/

 But seems like they are setting colors for icons elsewhere (not at the
 SVG). See this
 https://design.firefox.com/photon/visuals/iconography.html#color

 Anyways, I exported the Tor Button Icon again with no borders. And, also I
 included a version using `Grey 90 a80`. .zip attached here Arthur. Let me
 know!

 About colors, I commented at #25693.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
--+--
 Reporter:  arthuredelstein   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff60-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by antonela):

 * Attachment "26655.zip" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
--+--
 Reporter:  arthuredelstein   |  Owner:  antonela
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  ff60-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by cypherpunks):

 * status:  assigned => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
--+--
 Reporter:  arthuredelstein   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff60-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: Dbryrtfbcbhgf (added)


Comment:

 comment:23:ticket:25693 has some proposal on how to deal with the missing
 color.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
--+--
 Reporter:  arthuredelstein   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff60-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 It looks okay with Hamburger Menu > Customize > Density > Compact (which I
 think should be the default). Good observation with the color of Reload
 button vs Onion icon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
--+--
 Reporter:  arthuredelstein   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff60-esr  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: tbb-team (added)
 * keywords:   => ff60-esr


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26655 [Applications/Tor Browser]: onion button is wrong size and color

[Tor Bug Tracker & Wiki]

#26655: onion button is wrong size and color
--+--
 Reporter:  arthuredelstein   |  Owner:  antonela
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 For some reason the onion button is looking too small. We are using an
 SVG, so maybe it has some extra margin we can remove? Also, the onion
 button looks black, while the Home and Reload buttons are dark gray. On
 the other hand, some users are requesting a more colorful button so they
 can see it in their peripheral vision. (see
 https://trac.torproject.org/projects/tor/ticket/25693#comment:20)

 Here's how the button looks now:
 [[Image(https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/26237/toolbar_26237.png)]]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs