Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Applied to `master` (commit 51aae94ab13e575ddbcba0cff4dbb9c69c4a612e),
 thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201810 => tbb-rbm, tbb-
 mobile, TorBrowserTeam201810R
 * status:  needs_revision => needs_review


Comment:

 Commit `483f8fc5880aeb8b42695fe5008e29c230b86994` looks good to me. I
 think we can merge it after #27441.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Removed trailing white spaces from rbm.conf:  https://github.com/sisbell
 /tor-browser-build/commits/android-1017

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 sisbell: could you remove the trailing whitespaces here as well, please?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201810   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Commit `4abb076a83ff509125fe75bcd3d17ad51181c5a2` looks like a good start.
 I think we can merge it after #27441, and update the definition in
 following commits if needed.

 Note: creating a new branch for new revisions of the patches (instead of
 force pushing on the same branch) would make it easier to see what
 changed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:7 sisbell]:
 > I fixed these issues. Also broke out the run version spec into separate
 commit (this commit is already on master build)
 This should be rebased on master, so we don't need to include this runc
 spec patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 The commits can be found at


 !https://github.com/sisbell/tor-browser-build/commits/android-rebased

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 I fixed these issues. Also broke out the run version spec into separate
 commit (this commit is already on master build)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 The line changing the `runc version spec` line does not seem to be related
 to the android build. So it should be done in a separate commit/ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201809R => tbb-rbm, tbb-
 mobile, TorBrowserTeam201809


Comment:

 Replying to [comment:3 sisbell]:
 > commit: https://github.com/sisbell/tor-browser-
 build/commit/f0f57154e87ec271d90fd6b82ba2d12e0ae0f468

 Some first comments about this commit:
 - targets should be named `torbrowser-android-armv7` and `android-armv7`,
 as we might add support for other android architectures later.
 - `var/osname` should be `android-armv7`.
 - `var/compiler` should be set to `android-toolchain` instead of `gcc`.
 - `snowflake` and `fteproxy` should be set to `0` as I don't think they
 can be built for android yet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201809R  |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, tbb-mobile, TorBrowserTeam201808 => tbb-rbm, tbb-
 mobile, TorBrowserTeam201809R
 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 commit: https://github.com/sisbell/tor-browser-
 build/commit/f0f57154e87ec271d90fd6b82ba2d12e0ae0f468

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-mobile, |  implemented
  TorBrowserTeam201807   |  Actual Points:
Parent ID:  #26693   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  new => closed
 * resolution:   => implemented


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26696 [Applications/Tor Browser]: Add definition for new platform in rbm.conf

[Tor Bug Tracker & Wiki]

#26696: Add definition for new platform in rbm.conf
-+-
 Reporter:  boklm|  Owner:  tbb-team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-rbm, tbb-mobile,
 Severity:  Normal   |  TorBrowserTeam201807
Actual Points:   |  Parent ID:  #26693
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 In order to be able to integrate Tor Browser for Android into tor-browser-
 build, we need to add a definition for the new platform into `rbm.conf`.

 To do that we need to decide:

 - which OS we want to use inside the build containers. Probably Debian
 Stable, unless we have a reason for using something else.

 - how we want to name this new tor browser platform in `tor-browser-
 build/rbm.conf`. Currently we have: `linux-x86_64`, `linux-i686`,
 `windows-i686`, `windows-x86_64` and `osx-x86_64`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs