[tor-bugs] #26703 [Core Tor/Tor]: Lower log level of "Scheduler type KIST has been enabled"

[Tor Bug Tracker & Wiki]

#26703: Lower log level of "Scheduler type KIST has been enabled"
--+
 Reporter:  pastly|  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.9
 Severity:  Trivial   |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 I like seeing it, but that doesn't mean everyone should have to see it.
 Tor doesn't log about EWMA vs RR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26703 [Core Tor/Tor]: Lower log level of "Scheduler type KIST has been enabled"

[Tor Bug Tracker & Wiki]

#26703: Lower log level of "Scheduler type KIST has been enabled"
--+
 Reporter:  pastly|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.9
 Severity:  Trivial   | Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by dgoulet):

 * keywords:   => easy
 * type:  enhancement => defect


Comment:

 In the early days of KIST, having that line was SO useful. I propose we
 put it in the summary line (if we can or in a new type of summary line)
 like this one:

 {{{
 [notice] Tor 0.3.4.0-alpha-dev (git-facde43b0e0ad3ea) running on Linux
 with Libevent 2.1.8-stable, OpenSSL 1.0.2n, Zlib 1.2.11, Liblzma 5.2.2,
 and Libzstd N/A.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26703 [Core Tor/Tor]: Lower log level of "Scheduler type KIST has been enabled"

[Tor Bug Tracker & Wiki]

#26703: Lower log level of "Scheduler type KIST has been enabled"
--+
 Reporter:  pastly|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.9
 Severity:  Trivial   | Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by pastly):

 See https://gitweb.torproject.org/user/pastly/tor.git/log/?h=issue26703
 for changing it to INFO.

 I would support moving it to the summary.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26703 [Core Tor/Tor]: Lower log level of "Scheduler type KIST has been enabled"

[Tor Bug Tracker & Wiki]

#26703: Lower log level of "Scheduler type KIST has been enabled"
--+
 Reporter:  pastly|  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Very Low  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.9
 Severity:  Trivial   | Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by pastly):

 * status:  new => needs_review


Comment:

 FWIW, I gave 5 minutes of effort to adding the scheduler type to the
 summary. It not as easy as `log_info` because the required stuff
 (`get_scheduler_type_string()` and `the_scheduler`) is static. Furthermore
 (and actually importantly), I don't think we've initialized the scheduler
 at the point the summary is logged.

 Working off the assumption that we don't want to overcome these
 challenges, I'm moving this to needs_review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26703 [Core Tor/Tor]: Lower log level of "Scheduler type KIST has been enabled"

[Tor Bug Tracker & Wiki]

#26703: Lower log level of "Scheduler type KIST has been enabled"
-+
 Reporter:  pastly   |  Owner:  (none)
 Type:  defect   | Status:  needs_review
 Priority:  Very Low |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.2.9
 Severity:  Trivial  | Resolution:
 Keywords:  easy kist tor-scheduler  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by asn):

 * keywords:  easy => easy kist tor-scheduler


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26703 [Core Tor/Tor]: Lower log level of "Scheduler type KIST has been enabled"

[Tor Bug Tracker & Wiki]

#26703: Lower log level of "Scheduler type KIST has been enabled"
-+-
 Reporter:  pastly   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.9
 Severity:  Trivial  | Resolution:
 Keywords:  easy, kist, tor-scheduler, 035   |  Actual Points:
  -triaged-in-20180711   |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26703 [Core Tor/Tor]: Lower log level of "Scheduler type KIST has been enabled"

[Tor Bug Tracker & Wiki]

#26703: Lower log level of "Scheduler type KIST has been enabled"
-+-
 Reporter:  pastly   |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.9
 Severity:  Trivial  | Resolution:  fixed
 Keywords:  easy, kist, tor-scheduler, 035   |  Actual Points:
  -triaged-in-20180711   |
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Trivial fix. I'm good with log_info for now and we can work out later to
 have it in a status line.

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs