Re: [tor-bugs] #26940 [Core Tor/Tor]: Privcount blinding and encryption: doc fixes

[Tor Bug Tracker & Wiki]

#26940: Privcount blinding and encryption: doc fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:  .1
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  teor |Sponsor:
 |  SponsorV
-+-
Changes (by nickm):

 * actualpoints:   => .1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26940 [Core Tor/Tor]: Privcount blinding and encryption: doc fixes

[Tor Bug Tracker & Wiki]

#26940: Privcount blinding and encryption: doc fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.6.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  teor |Sponsor:
 |  SponsorV
-+-
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Merged, with typos fixed!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26940 [Core Tor/Tor]: Privcount blinding and encryption: doc fixes

[Tor Bug Tracker & Wiki]

#26940: Privcount blinding and encryption: doc fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.6.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  teor |Sponsor:
 |  SponsorV
-+-
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Looks good to me. The new documentation is helpful for understanding the
 code.

 See my comments on the pull request, I found a few typos.

 After they're fixed, let's merge,

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26940 [Core Tor/Tor]: Privcount blinding and encryption: doc fixes

[Tor Bug Tracker & Wiki]

#26940: Privcount blinding and encryption: doc fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26940 [Core Tor/Tor]: Privcount blinding and encryption: doc fixes

[Tor Bug Tracker & Wiki]

#26940: Privcount blinding and encryption: doc fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 I've done this as the final part of my branch `ticket26939_26943_26940`;
 PR at https://github.com/nmathewson/privcount_shamir/pull/3 .

 While doing this I fixed a couple of extra bugs, one big, one small.
   * big: it was possible to create a TR whose public key would give it an
 X coordinate of zero.  If you did that, then the TR's "share" would
 actually be the un-split secret data.  Good thing we caught this before
 production!
   * small: the Rand implementation for FE didn't use the from_u64_unbiased
 method.

 If you'd like even more doctests, I'd like to do that after merging this
 branch, since it's already grown pretty large.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26940 [Core Tor/Tor]: Privcount blinding and encryption: doc fixes

[Tor Bug Tracker & Wiki]

#26940: Privcount blinding and encryption: doc fixes
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * owner:  teor => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26940 [Core Tor/Tor]: Privcount blinding and encryption: doc fixes

[Tor Bug Tracker & Wiki]

#26940: Privcount blinding and encryption: doc fixes
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust |
Parent ID:  #25669   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 I also need to fix the format of the doc comments, see:
 https://trac.torproject.org/projects/tor/ticket/26942?replyto=4#comment:4

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26940 [Core Tor/Tor]: Privcount blinding and encryption: doc fixes

[Tor Bug Tracker & Wiki]

#26940: Privcount blinding and encryption: doc fixes
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  privcount, 035-roadmap-master, 035
 Severity:  Normal   |  -triaged-in-20180711, rust
Actual Points:   |  Parent ID:  #25669
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Doc fixes from
 https://trac.torproject.org/projects/tor/ticket/25669#comment:15

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs