Re: [tor-bugs] #27081 [Core Tor/Tor]: Don't link pthreads on win32, even if it is present

[Tor Bug Tracker & Wiki]

#27081: Don't link pthreads on win32, even if it is present
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  fast-fix 029-backport 032-backport   |  Actual Points:
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by heaslr):

 Tor Browser 8 is affected.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27081 [Core Tor/Tor]: Don't link pthreads on win32, even if it is present

[Tor Bug Tracker & Wiki]

#27081: Don't link pthreads on win32, even if it is present
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  fast-fix 029-backport 032-backport   |  Actual Points:
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 ok; merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27081 [Core Tor/Tor]: Don't link pthreads on win32, even if it is present

[Tor Bug Tracker & Wiki]

#27081: Don't link pthreads on win32, even if it is present
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix 029-backport 032-backport   |  Actual Points:
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27081 [Core Tor/Tor]: Don't link pthreads on win32, even if it is present

[Tor Bug Tracker & Wiki]

#27081: Don't link pthreads on win32, even if it is present
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix 029-backport 032-backport   |  Actual Points:
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by teor):

 (Looks fine to me, but I didn't run it on Windows, or check the appveyor
 build.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27081 [Core Tor/Tor]: Don't link pthreads on win32, even if it is present

[Tor Bug Tracker & Wiki]

#27081: Don't link pthreads on win32, even if it is present
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix 029-backport 032-backport   |  Actual Points:
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27081 [Core Tor/Tor]: Don't link pthreads on win32, even if it is present

[Tor Bug Tracker & Wiki]

#27081: Don't link pthreads on win32, even if it is present
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix 029-backport 032-backport   |  Actual Points:
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 Fix in my branch `bug27081_029`; PR at
 https://github.com/torproject/tor/pull/267

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27081 [Core Tor/Tor]: Don't link pthreads on win32, even if it is present

[Tor Bug Tracker & Wiki]

#27081: Don't link pthreads on win32, even if it is present
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  fast-fix 029-backport 032-backport
 Severity:  Normal   |  033-backport 034-backport
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Some mingw setups include an -lpthread, even though we don't use pthreads
 on windows. Therefore, we should only search for the pthreads functions
 when we are not building for windows.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs