Re: [tor-bugs] #27088 [Core Tor/Tor]: Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS

[Tor Bug Tracker & Wiki]

#27088: Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-|  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328, 034-backport,|
  035-removed-20180711, fast-fix |
Parent ID:  #24629   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Looks good! I'm not sure I like passing configure options that begin with
 `--` as the first argument to `echo`. Maybe put some text that doesn't
 start with a dash first? Like `echo configuring with flags
 $CONFIGURE_FLAGS`?

 On the other hand, I think the shells that Travis uses on all its
 platforms will tolerate it, so maybe we can let that remain.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27088 [Core Tor/Tor]: Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS

[Tor Bug Tracker & Wiki]

#27088: Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-|  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328, 034-backport,|
  035-removed-20180711, fast-fix |
Parent ID:  #24629   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by asn):

 * reviewer:  nickm => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27088 [Core Tor/Tor]: Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS

[Tor Bug Tracker & Wiki]

#27088: Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-|  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328, 034-backport,|
  035-removed-20180711, fast-fix |
Parent ID:  #24629   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by asn):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27088 [Core Tor/Tor]: Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS

[Tor Bug Tracker & Wiki]

#27088: Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-|  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328, 034-backport,|
  035-removed-20180711, fast-fix |
Parent ID:  #24629   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review
 * version:   => Tor: 0.3.4.1-alpha


Comment:

 This fix will be in my #24629 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27088 [Core Tor/Tor]: Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS

[Tor Bug Tracker & Wiki]

#27088: Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  not-just-linux, tor-ci, teor-was-
 Severity:  Normal   |  assigned, 034-triage-20180328,
 |  034-removed-20180328, 034-backport,
 |  035-removed-20180711, fast-fix
Actual Points:   |  Parent ID:  #24629
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Oops, it seems we missed this one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs