Re: [tor-bugs] #27090 [Core Tor/Tor]: Travis: enable lzma and zstd in configure, if available

[Tor Bug Tracker & Wiki]

#27090: Travis: enable lzma and zstd in configure, if available
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.1.5-alpha
 Severity:  Normal   | Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-|  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328, 034-backport,|
  035-removed-20180711, fast-fix |
Parent ID:  #24629   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 The patch (e4d7f2667c6c4660ad9663a39fbdef7d3e2961cd) looks plausible to
 me.  Looking at the build logs on travis, I can confirm that Tor is
 detecting and building with zstd and lzma on OSX, and with lzma on ubuntu.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27090 [Core Tor/Tor]: Travis: enable lzma and zstd in configure, if available

[Tor Bug Tracker & Wiki]

#27090: Travis: enable lzma and zstd in configure, if available
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.1.5-alpha
 Severity:  Normal   | Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-|  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328, 034-backport,|
  035-removed-20180711, fast-fix |
Parent ID:  #24629   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by asn):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27090 [Core Tor/Tor]: Travis: enable lzma and zstd in configure, if available

[Tor Bug Tracker & Wiki]

#27090: Travis: enable lzma and zstd in configure, if available
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.1.5-alpha
 Severity:  Normal   | Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-|  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328, 034-backport,|
  035-removed-20180711, fast-fix |
Parent ID:  #24629   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:1 teor]:
 > It turns out that we were never building with zstd on macOS, because the
 package config path wasn't set.
 >
 > The fix will be in my #24629 branches.

 We were never installing the package, because "brew install" installs or
 updates.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27090 [Core Tor/Tor]: Travis: enable lzma and zstd in configure, if available

[Tor Bug Tracker & Wiki]

#27090: Travis: enable lzma and zstd in configure, if available
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.1.5-alpha
 Severity:  Normal   | Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-|  Actual Points:
  assigned, 034-triage-20180328, |
  034-removed-20180328, 034-backport,|
  035-removed-20180711, fast-fix |
Parent ID:  #24629   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review
 * version:   => Tor: 0.3.1.5-alpha


Comment:

 It turns out that we were never building with zstd on macOS, because the
 package config path wasn't set.

 The fix will be in my #24629 branches.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27090 [Core Tor/Tor]: Travis: enable lzma and zstd in configure, if available

[Tor Bug Tracker & Wiki]

#27090: Travis: enable lzma and zstd in configure, if available
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  not-just-linux, tor-ci, teor-was-
 Severity:  Normal   |  assigned, 034-triage-20180328,
 |  034-removed-20180328, 034-backport,
 |  035-removed-20180711, fast-fix
Actual Points:   |  Parent ID:  #24629
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Otherwise, we can break lzma or zstd detection without knowing it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs