Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  regression, macos, i386, |  Actual Points:  1
  034-backport, arm32, 32-bit|
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by nickm):

 * actualpoints:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by rl1987):

 * cc: rl1987 (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, 035-must, |  Actual Points:
  034-must, 035-roadmap-proposed |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  regression, macos, i386 => regression, macos, 035-must,
 034-must, 035-roadmap-proposed


Comment:

 We must check if this issue affects Linux and BSD on 0.3.4 before
 releasing 0.3.4.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by teor):

 * keywords:  regression, macos, 035-must, 034-must, 035-roadmap-proposed =>
 regression, macos, i386


Comment:

 Oops, wrong ticket for that comment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386  |  Actual Points:
Parent ID:  #26987   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by teor):

 * parent:   => #26987


Comment:

 Replying to [comment:1 nickm]:
 > Are these intermittent or consistent?

 Consistent, with exactly those numbers in the tests every time.

 I don't see the same failures on macOS x86_64, but I do occasionally see
 odd time jumps after sleep on x86_64, see #26987. Maybe they are the same
 bug.

 > I'd be okay with or without OSX i386 CI.

 Same here. Tor Browser doesn't distribute i386 builds on macOS, and
 Homebrew only supports 64-bit. (MacPorts still builds 320bit tor, though.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386  |  Actual Points:
Parent ID:  #26987   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by nickm):

 I'd like to fix this, but it's not a much-used platform.  We should
 investigate a little more, and see if it's easy to fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386  |  Actual Points:
Parent ID:  #26987   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by nickm):

 * milestone:  Tor: 0.3.5.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by teor):

 * parent:  #26987 =>
 * milestone:  Tor: 0.3.4.x-final => Tor: 0.3.5.x-final


Comment:

 Not related to #26987

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386  |  Actual Points:
Parent ID:  #27296   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by teor):

 * parent:   => #27296


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386  |  Actual Points:
Parent ID:  #27296   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by nickm):

 I've started investigating these more closely.

 One thing that would be helpful here would be to know which values
 mach_timebase_info() puts into its output on this platforms.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386  |  Actual Points:
Parent ID:  #27296   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  new => accepted


Comment:

 The first one is probably due to monotime_coarse_diff_msec32_() having
 some rounding error.  I think that should be easy to resolve.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386  |  Actual Points:
Parent ID:  #27296   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by nickm):

 I think the second one may also be due to rounding error in that function.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386, |  Actual Points:
  034-backport, arm32, 32-bit|
Parent ID:  #27296   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  regression, macos, i386 => regression, macos, i386,
 034-backport, arm32, 32-bit


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386, |  Actual Points:
  034-backport, arm32, 32-bit|
Parent ID:  #27296   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 Okay, I think I have it.  The problem was in our 32-bit
 `monotime_coarse_diff_msec32_` implementation: it wasn't precise enough,
 and it didn't try hard enough to avoid integer overflows.  One of our unit
 tests was assuming an amount of precision it just couldn't provide.

 Bugfix in branch `bug27139_034`; PR at
 https://github.com/torproject/tor/pull/334 .

 I tested this by editing the compat_time.h header so that the
 `monotime_coarse_diff_msec32()` inline function would always use the
 32-bit implementation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386, |  Actual Points:
  034-backport, arm32, 32-bit|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * parent:  #27296 =>


Comment:

 (This turns out not to have anything to do with its ostensible parent
 ticket)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386, |  Actual Points:
  034-backport, arm32, 32-bit|
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386, |  Actual Points:
  034-backport, arm32, 32-bit|
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by teor):

 I ran this branch with CC="clang -arch i386", and the necessary
 dependencies from MacPorts.

 make check and make test-network-all passed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386, |  Actual Points:
  034-backport, arm32, 32-bit|
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me!  I only tested using nickm's strategy of forcing the use
 of the 32-bit computation on 64-bit, and trust teor's evidence.

 I'm a little nervous about some of the fixed-point hackery here, but given
 that it's increasingly unlikely that 32-bit macOS will continue to be
 relevant, I guess we can fix it later if it turns out to be a problem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386, |  Actual Points:
  034-backport, arm32, 32-bit|
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:19 catalyst]:
 > I'm a little nervous about some of the fixed-point hackery here, but
 given that it's increasingly unlikely that 32-bit macOS will continue to
 be relevant, I guess we can fix it later if it turns out to be a problem.

 I downgraded macOS i386 to Maintained in our supported platforms policy:
 
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/SupportedPlatforms?action=diff&version=14

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+-
 Reporter:  teor |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  regression, macos, i386, |  Actual Points:
  034-backport, arm32, 32-bit|
Parent ID:   | Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Okay, merged to 0.3.4 and forward!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests (was: macOS i386 fails time unit testa)

[Tor Bug Tracker & Wiki]

#27139: macOS i386 fails time unit tests
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  regression, macos, i386  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs