Re: [tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface

[Tor Bug Tracker & Wiki]

#27180: Remove DetailsDocumentFields interface
-+
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Merged. Closing. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface

[Tor Bug Tracker & Wiki]

#27180: Remove DetailsDocumentFields interface
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 Yes. There are no user facing or operational changes so I don't think this
 needs a changelog entry.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface

[Tor Bug Tracker & Wiki]

#27180: Remove DetailsDocumentFields interface
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 I think it's okay to just remove it.

 In fact, regarding `OrderParameters`, I think that these shouldn't use
 `DetailsDocumentFields` anyway, because parameter values and document
 fields are not necessarily the same thing. They happen to be the same in
 this case, and in most cases that makes sense, but there might be cases
 where they are not.

 Should I merge this change then?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface

[Tor Bug Tracker & Wiki]

#27180: Remove DetailsDocumentFields interface
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * cc: metrics-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface

[Tor Bug Tracker & Wiki]

#27180: Remove DetailsDocumentFields interface
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * status:  accepted => needs_review


Comment:

 Aaah, it is also used to build the OrderParameters. Now I'm unsure if we
 would want to remove this, or go the other direction and use it for all
 parameters in the documents.

 Please review my
 
[[https://gitweb.torproject.org/user/irl/onionoo.git/commit/?h=task/27180=41c9a9ba01d920f079a9de93b913bbe6e91cb8dc|commit
 41c9a9b in my task/27180 branch]] to see what removing it looks like.
 Maybe this can help us decide which way to go.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface

[Tor Bug Tracker & Wiki]

#27180: Remove DetailsDocumentFields interface
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Or can we use it for the remaining fields, too? If not, I'm okay with
 removing this interface.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface

[Tor Bug Tracker & Wiki]

#27180: Remove DetailsDocumentFields interface
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * owner:  metrics-team => irl
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27180 [Metrics/Onionoo]: Remove DetailsDocumentFields interface

[Tor Bug Tracker & Wiki]

#27180: Remove DetailsDocumentFields interface
-+--
 Reporter:  irl  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 This interface "Provides constants for details document field names".

 In practice, it only provides 2 of them, and they're only used in one
 function that is full of other hard coded strings.

 We can remove this to reduce complexity.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs