Re: [tor-bugs] #27185 [Core Tor/Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
-+-
 Reporter:  gvanem   |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.2-alpha
 Severity:  Minor| Resolution:  fixed
 Keywords:  clang-cl warning regression? |  Actual Points:
  windows fast-fix 029-backport 032-backport |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 okay, merged to 0.2.9 and forward!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27185 [Core Tor/Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
-+-
 Reporter:  gvanem   |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.2-alpha
 Severity:  Minor| Resolution:
 Keywords:  clang-cl warning regression? |  Actual Points:
  windows fast-fix 029-backport 032-backport |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Sure! It's just a warning, but they're worth getting rid of.

 See my branch bug27185-029, the CI is here:
 https://travis-ci.org/teor2345/tor/builds/419891982

 The merge into master has conflicts due to header renames. But it's
 relatively simple, and should match my bug27185 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27185 [Core Tor/Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
-+-
 Reporter:  gvanem   |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.2-alpha
 Severity:  Minor| Resolution:
 Keywords:  clang-cl warning regression? |  Actual Points:
  windows fast-fix 029-backport 032-backport |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 LGTM; should we backport?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27185 [Core Tor/Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
-+-
 Reporter:  gvanem   |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.2-alpha
 Severity:  Minor| Resolution:
 Keywords:  clang-cl warning regression? |  Actual Points:
  windows fast-fix 029-backport 032-backport |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review
 * version:  Tor: 0.3.4.6-rc => Tor: 0.2.2.2-alpha


Comment:

 See my branch bug27185 on https://github.com/teor2345/tor.git , which
 removes the lround() declaration, and uses math.h for fabs.

 The CI is here:
 https://travis-ci.org/teor2345/tor/builds/419553907
 https://ci.appveyor.com/project/teor2345/tor/build/1.0.81

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27185 [Core Tor/Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
-+-
 Reporter:  gvanem   |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.6-rc
 Severity:  Minor| Resolution:
 Keywords:  clang-cl warning regression? |  Actual Points:
  windows fast-fix 029-backport 032-backport |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gvanem):

 Okay. Thanks, I'll wait.

 BTW. All emails from Trac (for this ticket) got trapped in the Yahoo spam-
 filter. Hence I saw these replies very late. Not sure why.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27185 [Core Tor/Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
-+-
 Reporter:  gvanem   |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.6-rc
 Severity:  Minor| Resolution:
 Keywords:  clang-cl warning regression? |  Actual Points:
  windows fast-fix 029-backport 032-backport |
  033-backport 034-backport  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * owner:  (none) => teor
 * keywords:  clang-cl warning regression? windows =>
 clang-cl warning regression? windows fast-fix 029-backport
 032-backport 033-backport 034-backport
 * status:  needs_information => assigned


Comment:

 Ok, so the suggested patch is to use tor_lround() and tor_fabs() in the
 unit tests (and anywhere outside the module that defines them.)

 I think we have a script that does these kinds of checks. We should update
 it too.

 We should also backport this change to 0.2.9 and later.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27185 [Core Tor/Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
-+-
 Reporter:  gvanem   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.6-rc
 Severity:  Minor| Resolution:
 Keywords:  clang-cl warning regression? |  Actual Points:
  windows|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gvanem):

 > Does the warning go away if we use tor_lround() instead?

 Yes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27185 [Core Tor/Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
-+-
 Reporter:  gvanem   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.4.6-rc
 Severity:  Minor| Resolution:
 Keywords:  clang-cl warning regression? |  Actual Points:
  windows|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  clang-cl warning => clang-cl warning regression? windows
 * component:  Core Tor => Core Tor/Tor
 * milestone:   => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs