Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Low   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:  fixed
 Keywords:  backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  merge_ready
 Priority:  Low   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 lgtm

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+

Comment (by Jigsaw52):

 After the CI tests run on my pull request, they failed because some of the
 tests expect the previous string. I've updated the tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:  backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * keywords:   => backport
 * milestone:  Tor: 0.3.5.x-final => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  reopened
 Priority:  Low   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by Jigsaw52):

 * status:  closed => reopened
 * resolution:  implemented =>


Comment:

 I've made some small changes to this feature:
  - Changed the wording a bit
  - Move the existing log line before the %include is handled. In case of
 error in a recursive include, this makes the messages appear in ascending
 order of recursion level, which makes more sense than the opposite.
  - Added a extra log line for each file that is actually included (the
 existing log line only shows the %include paths in the config files). This
 will show the actual included files when the %include path is a folder.

 Pull request: https://github.com/torproject/tor/pull/1886

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by Jigsaw52):

 * status:  reopened => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Low   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:  implemented
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 added a changes file and merged.  I think we'll want to tweak the wording
 over time, but having this message is a strict improvement over not having
 it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  merge_ready
 Priority:  Low   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 This seems useful. lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => needs_review
 * milestone:   => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27186 [Core Tor/Tor]: Inform users about configuration file and directory includes

[Tor Bug Tracker & Wiki]

#27186: Inform users about configuration file and directory includes
--+
 Reporter:  UntoSten  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Low   |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Minor |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 This patch makes it clearer to users what settings Tor daemon is actually
 using. I think it is pretty important.

 https://github.com/UntoSten/tor/tree/inform-about-conf-includes

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs