Re: [tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, TBA-a3, |  Actual Points:
  GeorgKoppen201902, TorBrowserTeam201903R   |
Parent ID:  #5709| Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:14 gk]:
 >
 > I think both are good points. I think I've addressed them in
 `bug_27210_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_27210_v3=f4b5f7b3b38679456d97b71904b0c59d4e4600d9)
 (together with a stupid typo).

 This looks good to me. I merged this to master with commit
 `ba9064e4b5a369b9c70201e335ef706db25f2815`.

 In the merge I fixed a conflict in `projects/orbot/build`: the patch was
 changing some lines which have been removed by #29633.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, TBA-a3, |  Actual Points:
  TorBrowserTeam201902R, GeorgKoppen201902   |
Parent ID:  #5709| Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by gk):

 * status:  needs_revision => needs_review
 * keywords:  tbb-mobile, tbb-rbm, TBA-a3, TorBrowserTeam201902,
 GeorgKoppen201902 => tbb-mobile, tbb-rbm, TBA-a3,
 TorBrowserTeam201902R, GeorgKoppen201902


Comment:

 Replying to [comment:13 boklm]:
 > Replying to [comment:11 gk]:
 > > Alright. `bug_27210_v2` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_27210_v2=de71da3ce100983cbd20f4a7ce2c0d37492e2669)
 has the patch for review.
 >
 > * in projects/android-toolchain/build, I am wondering if instead of
 installing just the architecture we need, we could install all
 architectures we support, and share the toolchain between all the
 architectures. This would save some space on the disk, but maybe also slow
 down a little the build as we would be extracting archs we don't need. The
 extracted android-toolchain archive is currently 4.8G, of which 985M is
 the arm directory.
 > * in projects/rust/build, the patch 0001-Make-sure-dl_iterate_phdr-is-
 undefined-on-Android.patch is applied twice for the android-armv7 build.

 I think both are good points. I think I've addressed them in
 `bug_27210_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_27210_v3=f4b5f7b3b38679456d97b71904b0c59d4e4600d9)
 (together with a stupid typo).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, TBA-a3, |  Actual Points:
  TorBrowserTeam201902, GeorgKoppen201902|
Parent ID:  #5709| Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, TBA-a3, TorBrowserTeam201902R,
 GeorgKoppen201902 => tbb-mobile, tbb-rbm, TBA-a3,
 TorBrowserTeam201902, GeorgKoppen201902
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:11 gk]:
 > Alright. `bug_27210_v2` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_27210_v2=de71da3ce100983cbd20f4a7ce2c0d37492e2669)
 has the patch for review.

 * in projects/android-toolchain/build, I am wondering if instead of
 installing just the architecture we need, we could install all
 architectures we support, and share the toolchain between all the
 architectures. This would save some space on the disk, but maybe also slow
 down a little the build as we would be extracting archs we don't need. The
 extracted android-toolchain archive is currently 4.8G, of which 985M is
 the arm directory.
 * in projects/rust/build, the patch 0001-Make-sure-dl_iterate_phdr-is-
 undefined-on-Android.patch is applied twice for the android-armv7 build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, TBA-a3, |  Actual Points:
  TorBrowserTeam201902R, GeorgKoppen201902   |
Parent ID:  #5709| Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by watt):

 Where did you get `--disable-rust-debug`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, TBA-a3, |  Actual Points:
  TorBrowserTeam201902R, GeorgKoppen201902   |
Parent ID:  #5709| Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TBA-a3, TorBrowserTeam201902,
 GeorgKoppen201902 => tbb-mobile, tbb-rbm, TBA-a3,
 TorBrowserTeam201902R, GeorgKoppen201902
 * status:  new => needs_review


Comment:

 Alright. `bug_27210_v2` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_27210_v2=de71da3ce100983cbd20f4a7ce2c0d37492e2669)
 has the patch for review.

 Here is a testbuild for folks with the respective hardware:

 https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-
 android-x86-multi-qa_27210.apk
 https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-
 android-x86-multi-qa_27210.apk.asc

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, TBA-a3, |  Actual Points:
  TorBrowserTeam201902, GeorgKoppen201902|
Parent ID:  #5709| Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by gk):

 Okay, that was surprisingly easy it seems. I have a patch which I'll clean
 up tomorrow for review and will post a test bundle for folks with access
 to x86 android.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, TBA-a3, |  Actual Points:
  TorBrowserTeam201902, GeorgKoppen201902|
Parent ID:  #5709| Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TBA-a3, TorBrowserTeam201902 => tbb-
 mobile, tbb-rbm, TBA-a3, TorBrowserTeam201902, GeorgKoppen201902


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, TBA-a3   |
Parent ID:  #5709| Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:  #5709| Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile => tbb-mobile, tbb-rbm, TorBrowserTeam201812
 * cc: tbb-team (removed)
 * cc: boklm, sisbell (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
-+-
 Reporter:  sysrqb   |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:  #5709| Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 #28118 is a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:  #5709 | Points:
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * parent:  #25696 => #5709


Comment:

 We don't need this for the first alpha (or any of its child tickets).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27210 [Applications/Tor Browser]: TBA - Support i386 target

[Tor Bug Tracker & Wiki]

#27210: TBA - Support i386 target
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile
Actual Points:|  Parent ID:  #25696
   Points:|   Reviewer:
  Sponsor:|
--+
 We should add support for the x86 target. As far as I can see, this
 requires a separate build.

 We may want a separate .mozconfig for this. Maybe we can keep the shared
 config lines into .mozconfig-android, and put the different targets and
 objdirs into `.mozconfig-android-x86` and `.mozconfig-android-arm`.

 {{{
 mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-arm-linux-androideabi
 ac_add_options --target=arm-linux-androideabi
 }}}

 {{{
 mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-x86-linux-androideabi
 ac_add_options --target=i386-linux-android
 }}}

 When running `mach configure` for i386, we'll need:
 `rustup target add i686-linux-android` and we'll need to install yasm
 (`apt install yasm`).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs