Re: [tor-bugs] #27400 [Applications/Tor Browser]: Backport Bug 1473872 - Target API 26

[Tor Bug Tracker & Wiki]

#27400: Backport Bug 1473872 - Target API 26
---+--
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  enhancement| Status:  closed
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-mobile, TorBrowserTeam201809R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:  Sponsor8
---+--
Changes (by pili):

 * sponsor:   => Sponsor8


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27400 [Applications/Tor Browser]: Backport Bug 1473872 - Target API 26

[Tor Bug Tracker & Wiki]

#27400: Backport Bug 1473872 - Target API 26
---+--
 Reporter:  sysrqb |  Owner:  tbb-team
 Type:  enhancement| Status:  closed
 Priority:  Very High  |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  tbb-mobile, TorBrowserTeam201809R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gk):

 * keywords:  tbb-mobile => tbb-mobile, TorBrowserTeam201809R
 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks, that got cherry-picked to `tor-browser-60.2.0esr-8.5-1` as commit
 641dea421ec41553993b92d79a98394ae541f476.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27400 [Applications/Tor Browser]: Backport Bug 1473872 - Target API 26

[Tor Bug Tracker & Wiki]

#27400: Backport Bug 1473872 - Target API 26
--+-
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  enhancement   | Status:  merge_ready
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by igt0):

 * status:  needs_review => merge_ready


Comment:

 It looks good, I tested in a API 23 and 26 device and I also didn't see
 any runtime issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27400 [Applications/Tor Browser]: Backport Bug 1473872 - Target API 26

[Tor Bug Tracker & Wiki]

#27400: Backport Bug 1473872 - Target API 26
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sysrqb):

 * status:  new => needs_review


Comment:

 Okay. After many hours of working on backporting the upstream patches, I
 decided I'd try simply increasing the target API version. I reviewed the
 upstream patches and I don't see any logical run-time changes, from what I
 see the upstream patches are all build-time (and build system) changes.
 Therefore, I don't believe this patch should cause any run-time problems.
 I've tested this, and I don't see any noticeable difference on older and
 newer API versions.

 Specifically, the upstream patches changed the linting system, and
 annotation processing. I'm relatively certain we can continue using the
 current system for now.

 Branch for review: `27400_2`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27400 [Applications/Tor Browser]: Backport Bug 1473872 - Target API 26

[Tor Bug Tracker & Wiki]

#27400: Backport Bug 1473872 - Target API 26
--+--
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sysrqb):

 Okay. This is more complicated than expected. Not only do we need to
 backport the commit from Bug 1473872, but we need Bug 1352015 and (part
 of) Bug 1444546. The largest complication is Bug 1444546 changes part of
 the build system, and I prefer not backporting a large patch if we don't
 absolutely need it right now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27400 [Applications/Tor Browser]: Backport Bug 1473872 - Target API 26

[Tor Bug Tracker & Wiki]

#27400: Backport Bug 1473872 - Target API 26
--+
 Reporter:  sysrqb|  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Very High |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 We can't upload to Google Play until this is complete.

 https://bugzilla.mozilla.org/show_bug.cgi?id=1473872

 {{{
 Your app currently targets API level 23 and must target at least API level
 26
 to ensure it is built on the latest APIs optimized for security and
 performance.
 Change your app's target API level to at least 26.
 }}}

 We missed the cut-off for the <26 requirement:

 {{{
 Google Play will require that new apps target at least Android 8.0 (API
 level
 26) from August 1, 2018, and that app updates target Android 8.0 from
 November
 1, 2018.
 }}}

 https://developer.android.com/distribute/best-practices/develop/target-sdk

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs