Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  implemented
  035-deferred-20180930  |  Actual Points:  0.1
Parent ID:  #28018   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor8-can
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:  0.1
  035-deferred-20180930  |
Parent ID:  #28018   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor8-can
-+-

Comment (by catalyst):

 Replying to [comment:13 nickm]:
 > This branch LGTM; please let me know if I should merge it now or as part
 of a larger thing.
 Please merge it when convenient.  It would help me keep divergence from
 master down on orconn-tracker.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:  0.1
  035-deferred-20180930  |
Parent ID:  #28018   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor8-can
-+-

Comment (by catalyst):

 Replying to [comment:12 teor]:
 > Does this branch fix #27448 as well?
 I think it doesn't.  It seems like #27448 is mostly independent, other
 than the bootstrap code was getting incorrect information from
 `router_have_consensus_path()`.

 Therefore, I think #27448 shouldn't be a child ticket, so we can close
 this independently.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:  0.1
  035-deferred-20180930  |
Parent ID:  #28018   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor8-can
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 This branch LGTM; please let me know if I should merge it now or as part
 of a larger thing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:  0.1
  035-deferred-20180930  |
Parent ID:  #28018   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor8-can
-+-

Comment (by teor):

 Does this branch fix #27448 as well?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:  0.1
  035-deferred-20180930  |
Parent ID:  #28018   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor8-can
-+-
Changes (by dgoulet):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:  0.1
  035-deferred-20180930  |
Parent ID:  #28018   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by catalyst):

 * status:  assigned => needs_review
 * actualpoints:   => 0.1


Comment:

 Pull request at https://github.com/torproject/tor/pull/555

 This contains prerequisite refactoring for #27167.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:
  035-deferred-20180930  |
Parent ID:  #28018   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-

Comment (by catalyst):

 WIP patch is on branch https://github.com/tlyu/tor/tree/orconn-tracker
 which is mainly for #27167 work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:
  035-deferred-20180930  |
Parent ID:  #28018   | Points:  0.1
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by catalyst):

 * points:   => 0.1
 * parent:   => #28018


Comment:

 Turning this into a table lookup and removing the dependency on
 nodelist.h.  It often gave the wrong answer about whether tor was limited
 to internal paths only.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:
  035-deferred-20180930  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by catalyst):

 * owner:  (none) => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
+
 Reporter:  catalyst|  Owner:  (none)
 Type:  enhancement | Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  s8-bootstrap, tor-spec  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  Sponsor8-can
+
Changes (by teor):

 * keywords:  s8-bootstrap, tor-spec, 034-backport, 034-must =>
 s8-bootstrap, tor-spec


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:  (none)
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:
  034-backport, 034-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by teor):

 * owner:  teor => (none)


Comment:

 I just talked with catalyst on IRC. We can change the
 bootstrap_status_to_string() messages.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:  teor
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:
  034-backport, 034-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-

Comment (by catalyst):

 Replying to [comment:1 teor]:
 > This issue is caused (or made much worse) by #27236, which makes the
 chutney bridge and onion service networks work again after changes in
 0.3.4.
 >
 > If we remove the relevant code, then most of the chutney networks will
 stop working.
 >
 > Instead, let's fix the log message so it correctly reports that:
 > * there are exits in the consensus, but they don't have descriptors, or
 > * there are no exits in the consensus

 I'm not sure I understand. Does chutney require that the bootstrap log
 messages distinguish between having exits and not having exits? Is there
 some place other than the bootstrap status messages where it makes sense
 to report this information?

 I think it might make sense to report this somewhere else. In practice,
 barring catastrophe, don't we expect the live Tor network to always have
 exits? Maybe the distinction is only important for test networks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
-+-
 Reporter:  catalyst |  Owner:  teor
 Type:  enhancement  | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-bootstrap, tor-spec,  |  Actual Points:
  034-backport, 034-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by teor):

 * status:  new => assigned
 * keywords:  s8-bootstrap, tor-spec => s8-bootstrap, tor-spec,
 034-backport, 034-must
 * owner:  (none) => teor


Comment:

 This issue is caused (or made much worse) by #27236, which makes the
 chutney bridge and onion service networks work again after changes in
 0.3.4.

 If we remove the relevant code, then most of the chutney networks will
 stop working.

 Instead, let's fix the log message so it correctly reports that:
 * there are exits in the consensus, but they don't have descriptors, or
 * there are no exits in the consensus

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #27402 [Core Tor/Tor]: stop reporting "internal paths" during bootstrap

[Tor Bug Tracker & Wiki]

#27402: stop reporting "internal paths" during bootstrap
--+
 Reporter:  catalyst  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  s8-bootstrap, tor-spec
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:  Sponsor8-can  |
--+
 `bootstrap_status_to_string()` can report "internal paths" when the
 consensus actually contains exits, because it's conditional on
 `router_have_consensus_path()` which checks descriptors.  In the cold
 cache case, there are likely no existing descriptors, so tor will give the
 misleading impression that the consensus lacks exits (when it's actually
 more likely that it simply hasn't gotten around to downloading enough
 descriptors yet).

 Removing the code that handles these conditions also simplifies
 `bootstrap_status_to_string()`.

 This probably needs a tor-spec update.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs