Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, TorBrowserTeam201909R  |  Actual Points:  5
Parent ID:  #30429   | Points:  4
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by acat):

 * actualpoints:   => 5


Comment:

 I don't remember exactly, since the first patch was done 3 months ago. If
 we include the regressions and addressing the review comments that had to
 be done later I would say something like 5.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, TorBrowserTeam201909R  |  Actual Points:
Parent ID:  #30429   | Points:  4
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by pili):

 hi acat, could you set the "Actual Points" field with (more or less) how
 long it took you to complete this, that way we can see whether our
 estimates are accurate.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, TorBrowserTeam201909R  |  Actual Points:
Parent ID:  #30429   | Points:  4
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks for the digging and the fixups. Very nice work! I cherry-picked the
 Torbutton commit onto `master` (commit
 d796dd27d12850bd176a85e160002755bfccfab2) and the other ones onto `tor-
 browser-68.1.0esr-9.0-2` (commits
 b4e8db514df16856b567be1e13cb9af11a7de6e5
 535d41fd820d5b94caf43f3e403dc74b3566c837
 915d521a2fae009509a229bdaeb1d3a95a17b8c1
 e1ad91f3031dd08a0591d0f9d472cb49e015ad75
 5d0ffb6cea1e3eca56884f087120f2b40aa2926b).

 I've opened a new ticket to do The Right Thing with respect to our
 onboarding that is we need a new one fitting to the new Firefox reality
 instead of backing out patches and hacking around the breakage: #31660.

 FWIW: I think `doCommand()` is not working anymore due to the following
 change:
 {{{
 -   oncommand="SecurityLevelButton.onCommand(this, event);"
 +   onmousedown="SecurityLevelButton.onCommand();"
 }}}
 There is no `oncommand` handler anymore but an `onmousedown` one which
 presumably fires, too, if one clicks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201909R  |  Actual Points:
Parent ID:  #30429   | Points:  4
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by acat):

 * status:  needs_revision => needs_review
 * keywords:  ff68-esr, TorBrowserTeam201909 => ff68-esr,
 TorBrowserTeam201909R


Comment:

 Addressed comments in https://github.com/acatarineu/torbutton/commit/28822
 and https://github.com/acatarineu/tor-browser/commits/28822+1 (last 5
 commits).

 Replying to [comment:6 gk]:


 > Okay, I took the commits from your `30429+9` and here are my comments:
 >
 > ea5f8c2c9ccc0130944f05a6e31ebb2a9322041c - I think it's mostly good. Two
 things:
 > {{{
 > +const {Services}
 > }}}
 > I think we settled for space between name and braces in Torbutton? Would
 be good
 > here as well.

 Fixed.

 > {{{
 > +@$(MAKE) -C ../extensions/onboarding/locales chrome AB_CD=$*
 > }}}
 > It's really just one level up here, right? While all the other items are
 two
 > levels up?

 We could change it to

 {{{
 +   @$(MAKE) -C ../../browser/extensions/onboarding/locales chrome
 AB_CD=$*
 }}}
 but I think it's the same as the current one, since the file is already in
 browser `browser/locales/Makefile.in`.

 > 1c9eb3993c5b505c0894b13634b09690bfb97791 - not okay (not sure about the
 changed `onboarding-overlay-button` but we'll see I guess while testing)

 I changed the css to match the old patch, since the `onboarding-overlay-
 attention-dot` was not showing properly.

 > The images are the wrong ones. We want to have those from #30560.

 Fixed.

 > 6f05a139b387c072a63bfae3a086aee2cee95875 - okay
 > e19e128476f48278911656db735739f0526f12ce - not okay
 > {{{
 > -/* The primary button gets the same color as the customize button. */
 > }}}
 > in `browser/themes/shared/UITour.inc.css` is missing

 Fixed.



 > 742fccfcbb7a19ba9daee44335e9962639773d13 - not okay
 > {{{
 > -  OnboardingTelemetry:
 "resource://onboarding/modules/OnboardingTelemetry.jsm",
 > }}}
 > in `browser/extensions/onboarding/bootstrap.js` is missing

 Fixed.

 > aeb0b6678e61fd282825610ca29a225eb0991281 - I think this is okay, but are
 we affected by https://bugzilla.mozilla.org/show_bug.cgi?id=1498378?

 We are, nice catch. Reverted that one too.

 > Additionally, upon further testing it seems to me that the details part
 of the circuit level and the security settings is not working as expected.
 While clicking on the former opens the DDG .onion, no tour through the
 display shows up trying to make the menu behind the security settings
 button visible by clicking on the option does not do anything either.

 It seems there were several recent patches which did not like the
 onboarding. The security settings not opening is a regression due to
 #31322 and then #31251. The first one prevents UITour-lib.js from loading,
 and the second one makes `window.document.getElementById("security-level-
 button").doCommand()` not open the security level anymore (not sure why).

 The circuit path problem seems to be a regression caused by the FPI
 permissions patches. I tried reverting `Bug 1330467 - part 1. Don't strip
 first party domain from permissions key; r=johannh,Ehsan` and it works. It
 also works if you disable `firstparty.isolate`.

 The problem is that the permission check in [https://searchfox.org
 /mozilla-
 
central/rev/9bb55ae4d808fc48afcf93f99da6a685265b86c6/browser/components/uitour/UITourChild.jsm#91
 UITourChild.jsm] returns `false` after that patch is applied. I think this
 is because the `uitour` permission for the DDG onion page is not being
 loaded in the content process (where this is called). These are loaded in
 [https://searchfox.org/mozilla-
 
central/rev/9bb55ae4d808fc48afcf93f99da6a685265b86c6/dom/ipc/ContentParent.cpp#5450
 ContentParent.cpp] (for the principal). Before the FPI permission patch
 (or when disabling `firstparty.isolate`, this is called with key
 `https://3g2upl4pq6kufc4m.onion`, which loads the permission properly.
 After the patch it's called with key
 `https://3g2upl4pq6kufc4m.onion^firstPartyDomain=3g2upl4pq6kufc4m.onion`,
 which apparently does not work. This issue does not occur with `about:tor`
 `uitour` permission: this is always loaded because
 `nsPermissionManager::GetKeyForOrigin` returns empty keys for origins not
 

Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201909  |  Actual Points:
Parent ID:  #30429  | Points:  4
 Reviewer:  |Sponsor:
|  Sponsor44-can
+--
Changes (by pili):

 * points:   => 4


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201908  |  Actual Points:
Parent ID:  #30429  | Points:
 Reviewer:  |Sponsor:
|  Sponsor44-can
+--

Comment (by gk):

 Additionally, upon further testing it seems to me that the details part of
 the circuit level and the security settings is not working as expected.
 While clicking on the former opens the DDG .onion, no tour through the
 display shows up trying to make the menu behind the security settings
 button visible by clicking on the option does not do anything either.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201908  |  Actual Points:
Parent ID:  #30429  | Points:
 Reviewer:  |Sponsor:
|  Sponsor44-can
+--

Comment (by gk):

 Oh, and while rebasing I saw we have
 {{{
 # UITour
 # DuckDuckGo .onion (used for circuit display onboarding).
 origin  uitour  1   https://3g2upl4pq6kufc4m.onion
 origin  uitour  1   about:home
 origin  uitour  1   about:newtab
 origin  uitour  1   about:tor
 }}}
 I guess `about:home` and `about:newtab` can go now (at least that's my
 expression after re-looking at the webextension converting commit?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201908  |  Actual Points:
Parent ID:  #30429  | Points:
 Reviewer:  |Sponsor:
|  Sponsor44-can
+--
Changes (by gk):

 * keywords:  ff68-esr, TorBrowserTeam201908R => ff68-esr,
 TorBrowserTeam201908
 * status:  needs_review => needs_revision


Comment:

 Okay, I took the commits from your `30429+9` and here are my comments:

 ea5f8c2c9ccc0130944f05a6e31ebb2a9322041c - I think it's mostly good. Two
 things:
 {{{
 +const {Services}
 }}}
 I think we settled for space between name and braces in Torbutton? Would
 be good
 here as well.
 {{{
 +   @$(MAKE) -C ../extensions/onboarding/locales chrome AB_CD=$*
 }}}
 It's really just one level up here, right? While all the other items are
 two
 levels up?

 1c9eb3993c5b505c0894b13634b09690bfb97791 - not okay (not sure about the
 changed `onboarding-overlay-button` but we'll see I guess while testing)

 The images are the wrong ones. We want to have those from #30560.

 6f05a139b387c072a63bfae3a086aee2cee95875 - okay
 e19e128476f48278911656db735739f0526f12ce - not okay
 {{{
 -/* The primary button gets the same color as the customize button. */
 }}}
 in `browser/themes/shared/UITour.inc.css` is missing

 742fccfcbb7a19ba9daee44335e9962639773d13 - not okay
 {{{
 -  OnboardingTelemetry:
 "resource://onboarding/modules/OnboardingTelemetry.jsm",
 }}}
 in `browser/extensions/onboarding/bootstrap.js` is missing

 aeb0b6678e61fd282825610ca29a225eb0991281 - I think this is okay, but are
 we affected by https://bugzilla.mozilla.org/show_bug.cgi?id=1498378?

 I'll take the patches, though, for `tor-browser-68.1.0esr-9.0-1`, so
 please provide fixups for the issues above based on that one. (I am about
 to rebase and push it to `tor-browser`).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
-+-
 Reporter:  mcs  |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201908R  |  Actual Points:
Parent ID:  #30429   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by gk):

 * parent:   => #30429


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
+--
 Reporter:  mcs |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff68-esr TorBrowserTeam201906R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by acat):

 * keywords:  ff68-esr => ff68-esr TorBrowserTeam201906R
 * status:  new => needs_review


Comment:

 Following mcs suggestion, I resurrected the onboarding system addon. Then
 I cherry picked the original Tor onboarding commits and finally converted
 the bootstrapped extension into a webextension + experimental API, which
 is how it was done for other extensions (e.g. `formautofill`).

 Implemented in 6 last commits of https://github.com/acatarineu/tor-
 browser/commits/28822 (based on current `30429` branch).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68

[Tor Bug Tracker & Wiki]

#28822: re-implement desktop onboarding for ESR 68
--+--
 Reporter:  mcs   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff68-esr
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 As of Firefox 64, the onboarding extension which we used to implement Tor
 Browser onboarding has been removed. See:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1462415
 https://bugzilla.mozilla.org/show_bug.cgi?id=1457565

 More research is required, but it looks like Firefox's new onboarding
 experience is integrated into their "activity stream" interface (aka new
 tab page).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs