Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  goptlib  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by dcf):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Merged in [https://gitweb.torproject.org/pluggable-
 
transports/goptlib.git/commit/?h=v1.1.0=350ea810838a99d9fc9bf7e3523fcc5635691eed
 350ea810838a99d9fc9bf7e3523fcc5635691eed] and tagged
 [https://gitweb.torproject.org/pluggable-
 transports/goptlib.git/tag/?h=v1.1.0 v1.1.0].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by dcf):

 * status:  merge_ready => needs_review


Comment:

 attachment:Bug-28940-add-support-for-LOG.2.patch has some minor changes.
 The first is that I changed "log level" to "log severity" to match the
 terminology of the spec.

 The second change is to better conform with the letter of the spec
 regarding the value of `SEVERITY=`. But the way the spec is worded may be
 an oversight, so I want to check. Formerly I defined the log severity
 constants as plain strings. This was safe because the function escaped the
 severity string, so no matter what garbage the caller provided, it would
 not violate the global "any US-ASCII character but NUL or NL".

 But while the spec specifies quoting for `MESSAGE=`, it
 [https://gitweb.torproject.org/torspec.git/tree/pt-
 spec.txt?id=d890052d5525a09829c798ab0ad6dcdcede1a8ef#n599 does not
 actually say] that `SEVERITY=` may be quoted. That is, while this
 certainly conforms:
 {{{
 LOG SEVERITY=debug MESSAGE="hello world"
 }}}
 this may not conform:
 {{{
 LOG SEVERITY="debug" MESSAGE="hello world"
 }}}
 But if we don't quote the severity string, then we need to prevent callers
 from providing garbage values for it. I took some inspiration from
 [https://github.com/ahf/goptlib/commit/6815c6e0bcb5547e9d4328b8d7a3a10746094b1b
 #diff-308aaa719425f4333033c97cfb3b9868R10 ahf's patch]. I made the log
 severity constants be instances of an unexported struct type; i.e., it's
 not possible to create additional instances of the style from outside the
 package. In short it looks like this:
 {{{
 // Unexported type to prevent external callers from inventing new
 severities.
 type logSeverity struct {
 string
 }

 // Severity levels for the Log function.
 var (
 LogSeverityError   = logSeverity{"error"}
 LogSeverityWarning = logSeverity{"warning"}
 LogSeverityNotice  = logSeverity{"notice"}
 LogSeverityInfo= logSeverity{"info"}
 LogSeverityDebug   = logSeverity{"debug"}
 )
 }}}
 And the body of `Log` changed from
 {{{
 line("LOG", "SEVERITY="+encodeCString(severity),
 "MESSAGE="+encodeCString(message))
 }}}
 to
 {{{
 line("LOG", "SEVERITY="+severity.string,
 "MESSAGE="+encodeCString(message))
 }}}
 So the question is, is this strict enumeration necessary, or is the spec
 meant to allow quoting of `SEVERITY=`? It's allowed by tor; but should we
 specify it? As it stands, an implementation would be totally justified in
 parsing a LOG line with a regex, something like: `^LOG
 SEVERITY=(error|warning|notice|info|debug)
 MESSAGE=(\w+|"(\\[0-9]{1,3}|\\n|\\t|\\r|\\"||[^\\])*")$`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by dcf):

 * Attachment "Bug-28940-add-support-for-LOG.2.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-

Comment (by dcf):

 Replying to [comment:10 ahf]:
 > I lifted out the logger and the STATUS API into a `goptlibext` package
 at https://github.com/ahf/goptlibext

 Would it help if I exposed the [https://gitweb.torproject.org/pluggable-
 transports/goptlib.git/tree/pt.go?h=v1.0.0#n262 pt.line function]? It's
 what's used internally to provide all the line-oriented output for other
 functions like `pt.Cmethod` and `pt.ProxyDone`. Or is writing to
 `pt.Stdout` good enough for your purposes?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Let's get your LOG support into `goptlib`. It looks good.

 I lifted out the logger and the STATUS API into a `goptlibext` package at
 https://github.com/ahf/goptlibext

 Let's move it over to Gitlab once the instance is up and running this or
 next week.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by dcf):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:8 ahf]:
 > Let's do this as an extension and keep `goptlib` for the low level
 details. `goptlibext` could be the name.

 I definitely want a basic `Log` function in goptlib itself. A higher-level
 interface, using `log.Logger` for example, is a good candidate for a
 separate library that builds on goptlib, I agree.

 Here's an implementation of `Log` along the lines of what I was thinking.
 The [attachment:0001-Bug-28940-add-support-for-LOG.patch full patch]
 includes more documentation and tests.
 {{{
 // Severity levels for the Log function.
 const (
 LogLevelError   = "error"
 LogLevelWarning = "warning"
 LogLevelNotice  = "notice"
 LogLevelInfo= "info"
 LogLevelDebug   = "debug"
 )

 // Encode a string according to the CString rules of section 2.1.1 in
 // control-spec.txt.
 //
 // We additionally need to ensure that whatever we return passes
 argIsSafe,
 // because strings encoded by this function are printed verbatim by Log.
 func encodeCString(s string) string {
 result := bytes.NewBuffer([]byte{})
 result.WriteByte('"')
 for _, c := range []byte(s) {
 if c == 32 || c == 33 || (35 <= c && c <= 91) || (93 <= c
 && c <= 126) {
 result.WriteByte(c)
 } else {
 fmt.Fprintf(result, "\\%03o", c)
 }
 }
 result.WriteByte('"')
 return result.String()
 }

 // Emit a LOG message with the given severity (one of LogLevelError,
 // LogLevelWarning, LogLevelNotice, LogLevelInfo, or LogLevelDebug).
 func Log(severity, message string) {
 // " contains the log message which can be a String or
 CString..."
 // encodeCString always makes the string safe to emit; i.e., it
 // satisfies argIsSafe.
 line("LOG", "SEVERITY="+encodeCString(severity),
 "MESSAGE="+encodeCString(message))
 }
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by dcf):

 * Attachment "0001-Bug-28940-add-support-for-LOG.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by dcf):

 * Attachment "0001-Bug-28940-add-support-for-LOG.patch" removed.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by dcf):

 * Attachment "0001-Bug-28940-add-support-for-LOG.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-

Comment (by ahf):

 Let's do this as an extension and keep `goptlib` for the low level
 details. `goptlibext` could be the name.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by ahf):

 * parent:  #28180 =>


Comment:

 Remove parent.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:  #28180   | Points:  0.3
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by ahf):

 * points:   => 0.3


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:  #28180   | Points:
 Reviewer:   |Sponsor:  Sponsor19
-+-

Comment (by ahf):

 Just to address the spec concerns: Yes, they are not committed yet and I'm
 they are still open for discussion to some extend I think. The last week
 here we had some other bugs unrelated to all of this that had higher
 priority, but David and I will return to this in the new year.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:  #28180   | Points:
 Reviewer:   |Sponsor:  Sponsor19
-+-
Changes (by ahf):

 * sponsor:   => Sponsor19


Comment:

 Neat! Thanks for the early review. I'll try to revise the patches and link
 a branch here once I've fixed the things you have asked for.

 It will most likely be in early January though!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:  #28180   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by dcf):

 Please also add examples of using the new feature to dummy-client and
 dummy-server, and to the long block comment at the top of pt.go. (Just one
 or two examples is fine, doesn't have to be comprehensive.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:  #28180   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dcf):

 * status:  assigned => needs_revision


Comment:

 Thanks for making this branch, ahf.

 First off: I'm really confused about the format of the LOG message. The
 discussion at #21879 and #28181 doesn't seem to have been updated after
 decisions got made on IRC. In addition to LOG, there's also STATUS? It
 would be nice if the format were in a spec, or at least in textual form in
 a ticket somewhere. Especially with regard to what byte values are allowed
 and which must be escaped, and how.

 Here's some quick review.
  *
 https://github.com/ahf/goptlib/commit/2d4cadf91f7da4fb43d8c1e85bb3c851fb660b0c
 (removing advice on how to spy on the stdout output stream) is
 inappropriate. The LOG feature does not replace this feature. While
 debugging, you might want to see for example CMETHOD line that won't just
 be logged verbatim by tor or whatever the controlling program is. And we
 won't be able to rely on the LOG feature for a long time yet.
  * I do not want goptlib to expose a `log.Logger` interface. That is a
 high-level application matter, not something for a low-level library like
 goptlib. If an application needs a `log.Logger`-compatible interface, it
 can write its own wrapper. I feel that there should be exactly one new
 exported function:\\
 {{{
 func Log(severity int, message string)
 }}}
plus appropriate constants for severities. This is a tiny new feature;
 it doesn't need a new source file.
  * Don't use names like `kvline_escape_value`. Use camel-case names as
 https://golang.org/doc/effective_go.html#mixed-caps
  * I don't want a full-fledged key–value encoding library if we don't need
 it. I would rather have `Log` defined as something like\\
 {{{
 line("LOG", "SEVERITY=" + encodeValue(severity), "MESSAGE=" +
 encodeValue(message))
 }}}
In the `encodeValue` helper function, don't do a check like
 `kvline_value_needs_escape`. Just escape everything always.
  * No need to
 [https://github.com/ahf/goptlib/commit/c70bebb95b2a9585a31013bbee74fecc593802ea
 #diff-8ab1b4d8f6dfb248d21e27a7fcfee762R29 call bytes.Buffer.Grow]. It will
 grow automatically as you write to it.
  * In the test code, please also test:
* Values containing `'\0'` (should panic?)
* Values containing bytes >= `'\x80'` (e.g. UTF-8) (should panic?)
* Values containing `'='`
* Empty string
  Unfortunately, per https://spec.torproject.org/pt-spec Section 3.3, we
 are limited to US-ASCII minus `'\x00'` and `'\n'` in ''all'' PT output
 lines, so we need to test what happens when that is violated, even if the
 KV quoted string output allows other values.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+--
 Reporter:  dcf  |  Owner:  dcf
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  goptlib  |  Actual Points:
Parent ID:  #28180   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by dcf):

 * owner:  asn => dcf
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28940 [Obfuscation/Pluggable transport]: Add support for LOG to goptlib

[Tor Bug Tracker & Wiki]

#28940: Add support for LOG to goptlib
-+-
 Reporter:  dcf  |  Owner:  asn
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Obfuscation/Pluggable transport  |Version:
 Severity:  Normal   |   Keywords:  goptlib
Actual Points:   |  Parent ID:  #28180
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 see:
  * #28179 (code changes)
  * #28181 (pt-spec changes) ''[doesn't seem to be committed yet?]''

 ahf made a branch here:
 https://github.com/ahf/goptlib/commits/features/logging

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs