Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, TBA-a3, tbb-8.5-must-|  Actual Points:
  alpha, TorBrowserTeam201904R   |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 I think we are done here. We can open follow-up issues if needed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201903R, tbb-8.5 |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:30 sisbell]:
 > I have a commit that breaks apart the install and config directories. I
 upgraded to use org.torproject:tor-android-binary:0.3.5.8-rc
 >
 >
 
https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/575d9fd9f9727bf947ddac671034ae517799725b
 >
 > I know there is some discussion around which version of tor-android-
 binary to use. If we need to drop to earlier version of tor for tor-
 browser-build, I think we can handle this through a patch, while still
 maintaining the newer support for Android Q.

 0.3.5.8 is fine. We should give it a try in the next alpha (I was just not
 convinced that we should use a tor -rc in our browser instead of an actual
 stable release).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201903R, tbb-8.5 |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 I have a commit that breaks apart the install and config directories. I
 upgraded to use org.torproject:tor-android-binary:0.3.5.8-rc

 
https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/575d9fd9f9727bf947ddac671034ae517799725b

 I know there is some discussion around which version of tor-android-binary
 to use. If we need to drop to earlier version of tor for tor-browser-
 build, I think we can handle this through a patch, while still maintaining
 the newer support for Android Q.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201903R, tbb-8.5 |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by n8fr8):

 We have an initial release out for testing that hopefully addresses the
 Android Q issue:

 https://github.com/n8fr8/tor-android/releases/tag/tor-android-binary-
 tor-0.3.5.8-rc

 and a build of Orbot, as well, based on this:
 https://github.com/n8fr8/orbot/releases/tag/16.0.6-BETA-1-tor-0.3.5.8

 There is a new gradle dependency published as well:
 org.torproject:tor-android-binary:0.3.5.8-rc

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201903R, tbb-8.5 |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 I submitted a new issue with TOPL, since this has an impact:

 https://github.com/thaliproject/Tor_Onion_Proxy_Library/issues/85

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201903R, tbb-8.5 |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:26 eighthave]:
 > Turns out I was wrong about Android Q fully blocking daemons.  It is
 just they can't be executed from the /data partition.  They can be named
 with .so and included as a library, then directly executed from the
 system-managed unpack location.

 I gathered this from the links you posted. It looks like we can't copy
 libraries from the apk to the writable /data/data directory anymore. We
 will need to have the system unpack the libraries for us with the
 extractNativeLibs=true property in the manifest and then execute from the
 read-only /data/app directory.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201903R, tbb-8.5 |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by eighthave):

 Turns out I was wrong about Android Q fully blocking daemons.  It is just
 they can't be executed from the /data partition.  They can be named with
 .so and included as a library, then directly executed from the system-
 managed unpack location.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201903R, tbb-8.5 |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:24 eighthave]:
 > One small but important thing to do with this merging is to make
 TorService be an actual Android `Service`.  That will help with the
 lifecycle issues a lot, and is the official Android interface for doing
 something like a UNIX daemon.  I did some quick prototyping, this
 basically means writing a thin Java and JNI shim layer where the Java code
 defines the subclass of `android.app.Service` and the JNI layer maps the
 tor daemon start/stop to the Java class.
 I think this work wouldn't be done in TorService directly. It would be
 done in

 https://github.com/thaliproject/Tor_Onion_Proxy_Library

 The AndroidOnionProxyManager (extends OnionProxyManager) would be where
 the control of Tor is done. It manages the lifecycle events of the tor
 process. Stop is handled through the control connection, while start does
 all of the exec commands that we want to eliminate. So you can just fork
 TOPL and submit a PR. If there are any changes that need to bubble up, we
 can make those in TorService (tor-android-service)

 We have to do something like this for Android Q anyway, since running
 daemons is now fully blocked:
 > *
 
https://www.reddit.com/r/androiddev/comments/b2inbu/psa_android_q_blocks_executing_binaries_in_your/
 > * https://android-
 review.googlesource.com/c/platform/system/sepolicy/+/804149
 >
 It looks like this would also hit tor-android-binary dependency that we
 are using.

 > I have some cycles allocated from Guardian Project to work on this kind
 of thing, so I'm wondering how best to integrate into sisbell's work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201903R, tbb-8.5 |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by eighthave):

 One small but important thing to do with this merging is to make
 TorService be an actual Android `Service`.  That will help with the
 lifecycle issues a lot, and is the official Android interface for doing
 something like a UNIX daemon.  I did some quick prototyping, this
 basically means writing a thin Java and JNI shim layer where the Java code
 defines the subclass of `android.app.Service` and the JNI layer maps the
 tor daemon start/stop to the Java class.  We have to do something like
 this for Android Q anyway, since running daemons is now fully blocked:
 *
 
https://www.reddit.com/r/androiddev/comments/b2inbu/psa_android_q_blocks_executing_binaries_in_your/
 * https://android-
 review.googlesource.com/c/platform/system/sepolicy/+/804149

 I have some cycles allocated from Guardian Project to work on this kind of
 thing, so I'm wondering how best to integrate into sisbell's work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201903R, tbb-8.5 |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_information => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902R  |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 sysrqb: how are you building `tor-android-service`? I can successfully
 build it using sisbell's `android-0224` branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902R  |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by eighthave):

 * cc: hans@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902R  |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 Replying to [comment:17 sysrqb]:
 > {{{
 >  1:10.64 Warning:
 com.msopentech.thali.toronionproxy.OnionProxyManagerEventHandler: can't
 find superclass or interface net.freehaven.tor.control.EventHandler
 >  1:10.64 Warning: org.torproject.android.service.TorEventHandler: can't
 find superclass or interface net.freehaven.tor.control.EventHandler
 >  1:10.94 Warning:
 com.msopentech.thali.toronionproxy.BaseEventBroadcaster: can't find
 referenced class org.slf4j.Logger
 >  1:10.94 Warning:
 com.msopentech.thali.toronionproxy.BaseEventBroadcaster: can't find
 referenced class org.slf4j.Logger
 > [...]
 >  1:10.95 Warning: com.msopentech.thali.toronionproxy.OnionProxyContext:
 can't find referenced class org.slf4j.Logger
 >  1:10.95 Warning: com.msopentech.thali.toronionproxy.OnionProxyContext:
 can't find referenced class org.slf4j.LoggerFactory
 > [...]
 >  1:11.22 Warning: org.torproject.android.service.TorService: can't find
 referenced class
 com.msopentech.thali.android.toronionproxy.AndroidOnionProxyManager
 >  1:11.22 Warning: org.torproject.android.service.TorService: can't find
 referenced class
 com.msopentech.thali.android.toronionproxy.AndroidOnionProxyManager
 >  1:11.22 Warning: org.torproject.android.service.TorService: can't find
 referenced class
 com.msopentech.thali.android.toronionproxy.AndroidOnionProxyManager
 > [...]
 >  1:12.85 Warning: there were 83 unresolved references to classes or
 interfaces.
 >  1:12.87  You may need to add missing library jars or update
 their versions.
 >  1:12.87  If your code works fine without the missing classes,
 you can suppress
 >  1:12.87  the warnings with '-dontwarn' options.
 > }}}

 To be clear, it is the latter Warnings causing the build failure (83
 unresolved references to classes).

 {{{
 Warning: Exception while processing task java.io.IOException: Please
 correct the above warnings first.
 
:app:transformClassesAndResourcesWithProguardForOfficialWithGeckoBinariesNoMinApiPhotonDebug
 FAILED

 FAILURE: Build failed with an exception.

 * What went wrong:
 Execution failed for task
 
':app:transformClassesAndResourcesWithProguardForOfficialWithGeckoBinariesNoMinApiPhotonDebug'.
 > Job failed, see logs for details

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902R  |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 Have you seen these build errors. They're obviously coming form proguard,
 but i haven't started comparing Orbot's proguard file(s) with tor-android-
 service's yet.

 {{{
  1:10.37 Note: the configuration refers to the unknown class
 'com.google.android.gms.common.annotation.KeepName'
  1:10.37 Note: the configuration refers to the unknown class
 'com.google.android.gms.common.annotation.KeepName'
  1:10.38 Note: the configuration refers to the unknown class
 'okhttp3.internal.publicsuffix.PublicSuffixDatabase'
 [...]
  1:10.64 Warning:
 com.msopentech.thali.toronionproxy.OnionProxyManagerEventHandler: can't
 find superclass or interface net.freehaven.tor.control.EventHandler
  1:10.64 Warning: org.torproject.android.service.TorEventHandler: can't
 find superclass or interface net.freehaven.tor.control.EventHandler
  1:10.94 Warning: com.msopentech.thali.toronionproxy.BaseEventBroadcaster:
 can't find referenced class org.slf4j.Logger
  1:10.94 Warning: com.msopentech.thali.toronionproxy.BaseEventBroadcaster:
 can't find referenced class org.slf4j.Logger
 [...]
  1:10.95 Warning: com.msopentech.thali.toronionproxy.OnionProxyContext:
 can't find referenced class org.slf4j.Logger
  1:10.95 Warning: com.msopentech.thali.toronionproxy.OnionProxyContext:
 can't find referenced class org.slf4j.LoggerFactory
 [...]
  1:11.22 Warning: org.torproject.android.service.TorService: can't find
 referenced class
 com.msopentech.thali.android.toronionproxy.AndroidOnionProxyManager
  1:11.22 Warning: org.torproject.android.service.TorService: can't find
 referenced class
 com.msopentech.thali.android.toronionproxy.AndroidOnionProxyManager
  1:11.22 Warning: org.torproject.android.service.TorService: can't find
 referenced class
 com.msopentech.thali.android.toronionproxy.AndroidOnionProxyManager
 [...]
  1:11.40 Note: com.google.android.exoplayer2.DefaultRenderersFactory:
 can't find dynamically referenced class
 com.google.android.exoplayer2.ext.vp9.LibvpxVideoRenderer
 [...]
  1:12.84 Note: there were 16 references to unknown classes.
  1:12.84   You should check your configuration for typos.
  1:12.84
 (http://proguard.sourceforge.net/manual/troubleshooting.html#unknownclass)
  1:12.84 Note: there were 11 unkept descriptor classes in kept class
 members.
  1:12.84   You should consider explicitly keeping the mentioned
 classes
  1:12.84   (using '-keep').
  1:12.84
 (http://proguard.sourceforge.net/manual/troubleshooting.html#descriptorclass)
  1:12.84 Note: there were 1 library classes explicitly being kept.
  1:12.84   You don't need to keep library classes; they are already
 left unchanged.
  1:12.85
 (http://proguard.sourceforge.net/manual/troubleshooting.html#libraryclass)
  1:12.85 Note: there were 12 unresolved dynamic references to classes or
 interfaces.
  1:12.85   You should check if you need to specify additional program
 jars.
  1:12.85
 (http://proguard.sourceforge.net/manual/troubleshooting.html#dynamicalclass)
  1:12.85 Warning: there were 83 unresolved references to classes or
 interfaces.
  1:12.87  You may need to add missing library jars or update their
 versions.
  1:12.87  If your code works fine without the missing classes, you
 can suppress
  1:12.87  the warnings with '-dontwarn' options.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902R  |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 Replying to [comment:15 sisbell]:
 > Replying to [comment:14 sysrqb]:
 > > Shane, can you expand on why this is better?
 https://github.com/sisbell/tor-android-service/issues/12
 >
 > In tor-browser-build, we will replace these jars/libs with the ones that
 are generated as part of the build. The developer who wants to use tor-
 android-service in their own project will have these libraries already
 provided in the libs folder. This keeps a consistent approach. I'm still
 exploring whether these dependent libraries should be treated as provided,
 meaning they won't be packaged in the resulting aar.
 >
 > Ideally, in the future, I'd like to get the TOPL artifacts officially
 deployed to a maven repo and pull these down as dependencies during a
 regular developer build. The tor-browser-build would pull down the
 dependencies as part of the build process as well.


 Ah, so this is simply a stop-gap until they're available from a maven
 repo? That's fine. And if tor-browser-build will build these independently
 and (presumably) overwrite the vendored files, then I'm okay with that
 too, thanks for explaining.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902R  |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:14 sysrqb]:
 > Shane, can you expand on why this is better? https://github.com/sisbell
 /tor-android-service/issues/12

 In tor-browser-build, we will replace these jars/libs with the ones that
 are generated as part of the build. The developer who wants to use tor-
 android-service in their own project will have these libraries already
 provided in the libs folder. This keeps a consistent approach. I'm still
 exploring whether these dependent libraries should be treated as provided,
 meaning they won't be packaged in the resulting aar.

 Ideally, in the future, I'd like to get the TOPL artifacts officially
 deployed to a maven repo and pull these down as dependencies during a
 regular developer build. The tor-browser-build would pull down the
 dependencies as part of the build process as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902R  |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 Shane, can you expand on why this is better? https://github.com/sisbell
 /tor-android-service/issues/12

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902R  |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:12 gk]:
 > Replying to [comment:11 sisbell]:
 > > Replying to [comment:10 gk]:
 > > > sisbell: What exactly should we review here? Could you point me/us
 to the relevant branches/commits?
 > >
 > > The pull request has been merged to TOPL.  I was thinking if everyone
 is in agreement we can close out this ticket.
 > >
 > > sysrqb has commented on the merge commits in the parent ticket (see
 #27609).
 >
 > Okay. How does that relate to the changes mentioned in comment:4? Are
 they not needed anymore or are they prepared for review somewhere else?
 Or...?

 * My version of Tor_Onion_Proxy_Library and
 Tor_Onion_Proxy_Library_Android are no longer needed as they have been
 merged to the TOPL project:
 https://github.com/thaliproject/Tor_Onion_Proxy_Library/pull/68

 sysrqb made some additional comments after the merge, which we can make
 into new PR as needed.
 https://trac.torproject.org/projects/tor/ticket/27609#comment:28

 * tor-android-service is still needed. I'm maintaining this on github, we
 can move over to new repo once we decide on location.

 * My fork of orbot was just used for testing and can be tossed

 I've opened tickets related to creating tor-browser-build for TOPL, tor-
 android-service and integration into Orbot and Firefox projects.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902R  |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:11 sisbell]:
 > Replying to [comment:10 gk]:
 > > sisbell: What exactly should we review here? Could you point me/us to
 the relevant branches/commits?
 >
 > The pull request has been merged to TOPL.  I was thinking if everyone is
 in agreement we can close out this ticket.
 >
 > sysrqb has commented on the merge commits in the parent ticket (see
 #27609).

 Okay. How does that relate to the changes mentioned in comment:4? Are they
 not needed anymore or are they prepared for review somewhere else? Or...?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902R  |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:10 gk]:
 > sisbell: What exactly should we review here? Could you point me/us to
 the relevant branches/commits?

 The pull request has been merged to TOPL.  I was thinking if everyone is
 in agreement we can close out this ticket.

 sysrqb has commented on the merge commits in the parent ticket (see
 #27609).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902R  |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 sisbell: What exactly should we review here? Could you point me/us to the
 relevant branches/commits?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902   |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902   |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 The pull request has been merged over:
 
https://github.com/thaliproject/Tor_Onion_Proxy_Library/commit/f8124f40e44985938b5d59f8eccf76c56ac72761

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201902   |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * cc: n8fr8 (added)


Comment:

 Adding nathan, in case he wants to burn some cycles reviewing some of
 this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 I have everything integrated. There are four parts of the project
 currently.

 1) https://github.com/sisbell/Tor_Onion_Proxy_Library
 This is a fork of TOPL with the changes we need for integration with
 OrbotService. I've submitted a pull request. Yaron has some requested
 changes, but they are relatively minor so I'll get this resubmitted this
 week.

 2) https://github.com/sisbell/Tor_Onion_Proxy_Library_Android
 This contains the TOPL android code. Once the changes are merged from (1)
 we can do away with this repo. This project is dependent on (1) and pulls
 it down as part of the build through jitpack

 3) https://github.com/sisbell/tor-android-service
 This contains the merged TOPL and OrbotService code. This project is
 dependent on (2) and pulls it down as part of the build.

 4) https://github.com/sisbell/orbot
 This is a fork of Orbot. I removed the orbotservice code and added the
 dependency on (3). There are no code changes so tor-android-service is
 100% compatible with the current Orbot UI/app implementation.

 {{{
 implementation 'com.github.sisbell:tor-android-
 service:d4deab617b450401b9d5a3aa811ee6cdacaee303'
 }}}
 This repo is just for testing. We will use whatever is going to be
 included in the browser.

 For testing, you can just checkout (4) and import into Android Studio. All
 dependencies are already handled.

 I still need to

  1. Fix changes suggested in the pull request
  1. Add back in code for cookies and hidden services databases.
  1. Do more integration testing to make sure I didn't miss anything
  1. Start tor-browser-build

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 I added 10 issues to the TOPL issue tracker that outline the specific
 changes we need (issues !#49-58)

 https://github.com/thaliproject/Tor_Onion_Proxy_Library/issues

 With the exception of !#56,[ticket:57 #57,]I have these implemented and
 verified working with a modified version of OrbotService (main app will
 not need changes). Next step is to break the current work into each of
 their respective bug/commits. Then I will submit a pull request to TOPL.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 I've made the following changes to TOPL

  * Add custom torrc location through OnionProxyContext
  * Added an EventBroadcaster. Orbot will pass in an implementation so that
 TOPL broadcasts the same events as Orbot currently broadcasts.
  * Added the following methods to OnionProxyManager: killTorProcess,
 reloadTorConfig, getTorPid, newIdentity, disableNetwork, setExitNodes
  * Added resolvConf to TorConfig class
  * Added a new TorConfigBuilder class which included parsing and loading
 of bridges from file

 These changes make TOPL support the base features that Orbot needs.

 Changes to Orbot:

  * Moved over functionality to TOPL as part of integration (see above)
  * Use TOPL for tor installation and bootstrapping.
  * Created EventBroadcaster implementation (previously from code in
 TorService)
  * Rewrite DBs (in progress)

 TorService was 2K file, now its below 500 lines so a lot more manageable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, TBA-a3,  |  Actual Points:
  TorBrowserTeam201901   |
Parent ID:  #27609   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 I've done an initial (ugly) merging of TOPL and orbotservice so have
 enough to identify the specifics.

 Changes to TOPL

  * The !OnionProxyManager should be able to set the !EventHandler, rather
 than use the default one. Need to add a field to the !OnionProxyManager
 allowing us to pass in the custom !EventHandler that we will use.

  * Currently only supports configuring one hidden service. Add support for
 multiple hidden services through !OnionProxyManager.publishHiddenService

  * Add fields to the !TorConfig builder: ServerDNSResolvConfFile,
 !ExitNodes, Bridge, NEWNYM, Socks5ProxyUsername, Socks5ProxyPassword,
 !ProxyAuthenticator, !ClientTransportPlugin, !ReachableAddresses,
 !ExcludeNodes, !EntryNodes, !AutomapHostsOnResolve, DNSPort,
 HTTPTunnelPort

  * Add support for writing DNS File (resolv.conf)

  * Add support for loading bridges from resource file

 Changes to OrbotService
 * TorEventHandler - Orbot delegates sending of Android broadcasts to the
 TorService. We can decouple this by sending the broadcasts directly. This
 interface integrates with the same one that TOPL uses and can be
 configured through the OnionProxyManager with the fix defined above. [Easy
 fix]

 * TorService - this is a 2K line uber class.
   - Dozen or so broadcast messages that the main app will display to user.
 Need to replicate these where is makes sense
   - HiddenService Content DB - writes out to torrc. Break into its own
 class (possibly auto-generate)
   - Client Cookie DB - writes out to torrc. Break into its own class
 (possibly auto-generate)
   - VPN - we can port this directly
   - Clean circuits - a pending intent through a notification on service
 startup (NEWNYM)
   - Create Notifications for Network connectivity - this exists in TOPL
 but does not create notif
   - Start/Stop tor - we can use TOPL OnionProxyManager.start and
 OnionProxyManager.stop method to replace this feature
   - Tor Installer - we can use the one from TOPL
   - Handle events sent to service: ACTION_START, ACTION_STATUS,
 CMD_SIGNAL_HUP, CMD_NEWNYM, CMD_VPN, CMD_VPN_CLEAR, CMD_SET_EXIT
   - Various torrc config params that mirror TOPL
   - Loads Bridges from resource file

 Most of the work is simply taking everything from the Content DB and prefs
 and adding fields to torrc. The DB need to be rewritten. This should all
 be done in a separate package/set of classes, not in the TorService class.

 The new TorService will:
 * delegate to TorConfig package when generating torrc from prefs/DB
 * delegate to the OnionProxyManager for the start/stop of tor.
 * delegate to the AndroidResourceInstaller (TOPL) for installing tor
 * delegate to TOPL Config for loading bridges
 * handle incoming events AND outgoing notifications.
 * handle VPN configuration

 Integration:
 TOPL will be an android library. OrbotService will use TOPL. We can create
 patches for both projects and then integrate into tor-browser-build. The
 main Orbot app shouldn't require any changes as we can support the
 existing interfaces and broadcasts.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-+-
 Reporter:  sisbell  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-mobile, TBA-a3,
 Severity:  Normal   |  TorBrowserTeam201901
Actual Points:   |  Parent ID:  #27609
   Points:   |   Reviewer:
  Sponsor:   |
-+-


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs