Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:  6
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor2
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Squashed and merged the child.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:  6
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * actualpoints:   => 6


Comment:

 Child ticket #29527 needs to be merged after this get merged, so perhaps
 we can close this one after #29527 gets merged as well? Or I can remove
 the child ticket?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor2
-+-

Comment (by nickm):

 LGTM; merging!  Please set actual points and take whatever action is
 appropriate with the child ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * status:  needs_revision => merge_ready


Comment:

 Pushed fixups for the review. Let me know if you want anything else, or
 you want me to open tickets for something.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor2
-+-
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 I've added a couple of comments on the PR.  Most will probably not be
 things that need to change.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor2
-+-
Changes (by mikeperry):

 * status:  needs_review => merge_ready


Comment:

 Looks great now!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor2
-+-
Changes (by mikeperry):

 * priority:  Medium => Very High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Thanks for review. I pushed fixups which hope work for you.

 Check them out, and if they work for you, I will squash the whole thing
 into the final thing to be merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor2
-+-
Changes (by mikeperry):

 * status:  needs_review => needs_revision


Comment:

 asn: this looks great! I have some minor comment change requests in the
 review on the PR. Code looks really good though. Such improved much
 simplified!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:  mikeperry|Sponsor:
 |  Sponsor2
-+-
Changes (by dgoulet):

 * reviewer:   => mikeperry
 * milestone:   => Tor: 0.4.1.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-
Changes (by asn):

 * status:  new => needs_review


Comment:

 Hey Mike, please check my branch `bug29298`:
 https://github.com/torproject/tor/pull/705

 It implements the above! I still consider it a draft because I want to
 take a second good look to make sure I'm not screwing something up.

 But I think it looks pretty OK.

 I also have another branch that does some validation of histograms before
 registering them, but I decided to not fold it in to make it as light as
 possible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-

Comment (by asn):

 Replying to [comment:5 mikeperry]:
 > Replying to [comment:4 asn]:
 > > Spec branch pushed in https://github.com/asn-d6/torspec/tree/bug29298
 .
 > >
 > > Mike do you like it?
 >
 > We should provide arrays with the example: https://github.com/mikeperry-
 tor/torspec/tree/bug29298
 >

 Nice! That looks real good!

 > There's also the question as to if the infinity bin should be forced to
 have Infinity-1 as its left endpoint, or if we should allow this
 discontinuity as we have there..

 Yep, that would be an **alternative**. Let's consider it:

 {{{
 Alternative #1:

   Tokens+
  10 |++
   9 |||   +-+
   8 |||   | |
   7 ||| +-+ |
   6 ++ Bin+-+ | ++---+
   5 || #1 | | | ||   |
 | Bin|| Bin | Bin |  Bin #4 |Bin |Bin #6 |
 | #0 || #2  | #3  | |#5  | (infinity bin)|
 ||| | | ||   |
 ||| | | ||   |
   0 +++-+-+-++---+
 0   100  200   350   500  1000   ∞   ∞
 microseconds

 }}}

 Positives:
 - The final bin is now well defined since it makes sense to always return
 infinite delay.
 Negatives:
 - There will need to be special rules for the next-to-last bin which is
 now from 1000 -> ∞, so we still don't get a proper object.
 - We are now adding another bin to the histogram that was not explicitly
 added by the histogram designer, which might be confusing.

 Personally, I prefered the approach that is in the spec above because it's
 kinda easier to grasp and explain.

 **Another alternative**, would be to leave all the edges of the histogram
 to be specified by the histogram designer, including the rightmost one. If
 the designer wanted an infinity bin they could add an infinity value to
 that edge to make one. I think that would also be a clean solution, but it
 would be a bit of a hassle to apply the special rules (e.g. token removal,
 etc.) of the infinity bin in this solution since the designer would
 basically have to decide whether they want the rules or not, and that
 might complicate the "API".

 **For now**, I'd go with the one we specified in the spec above, see how
 that works out, and potentially iterate on the future as researchers use
 it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-

Comment (by mikeperry):

 Replying to [comment:4 asn]:
 > Spec branch pushed in https://github.com/asn-d6/torspec/tree/bug29298 .
 >
 > Mike do you like it?

 We should provide arrays with the example: https://github.com/mikeperry-
 tor/torspec/tree/bug29298

 There's also the question as to if the infinity bin should be forced to
 have Infinity-1 as its left endpoint, or if we should allow this
 discontinuity as we have there..

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-

Comment (by asn):

 Spec branch pushed in https://github.com/asn-d6/torspec/tree/bug29298 .

 Mike do you like it?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-

Comment (by asn):

 Also related to #29122 which revealed the underlying issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  wtf-pad 041-proposed network-team-   |  Actual Points:
  roadmap-2019-Q1Q2  |
Parent ID:  #28631   | Points:  5
 Reviewer:   |Sponsor:
 |  Sponsor2
-+-
Changes (by gaba):

 * keywords:  wtf-pad 041-proposed => wtf-pad 041-proposed network-team-
 roadmap-2019-Q1Q2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
--+--
 Reporter:  mikeperry |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  wtf-pad 041-proposed  |  Actual Points:
Parent ID:  #28631| Points:  5
 Reviewer:|Sponsor:  Sponsor2
--+--
Changes (by asn):

 * parent:   => #28631


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29298 [Core Tor/Tor]: Explicitly specify histogram bin endpoints/widths

[Tor Bug Tracker & Wiki]

#29298: Explicitly specify histogram bin endpoints/widths
--+--
 Reporter:  mikeperry |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  wtf-pad 041-proposed
Actual Points:|  Parent ID:
   Points:  5 |   Reviewer:
  Sponsor:  Sponsor2  |
--+--
 George has convinced me that we should explicitly specify the bin labels
 of our histograms rather than rely on a formula and lots of special cases
 for short histogram lengths.

 The most straight-forward thing is to let researchers specify a list of
 bin labels.. It might be more compact to encode if this list is a list of
 widths, but that may just be an encoding decision for the consensus. We
 should probably choose simplest possible representation here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs