Re: [tor-bugs] #29984 [Core Tor/Tor]: Controller protocol parser can't find empty initial line

[Tor Bug Tracker & Wiki]

#29984: Controller protocol parser can't find empty initial line
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:  .1
Parent ID:  #30091| Points:
 Reviewer:  catalyst  |Sponsor:  Sponsor31-can
--+
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Parent merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29984 [Core Tor/Tor]: Controller protocol parser can't find empty initial line

[Tor Bug Tracker & Wiki]

#29984: Controller protocol parser can't find empty initial line
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #30091| Points:
 Reviewer:  catalyst  |Sponsor:  Sponsor31-can
--+
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Covered by parent pull request

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29984 [Core Tor/Tor]: Controller protocol parser can't find empty initial line

[Tor Bug Tracker & Wiki]

#29984: Controller protocol parser can't find empty initial line
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:  #30091| Points:
 Reviewer:  catalyst  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  assigned => needs_review
 * reviewer:   => catalyst
 * parent:   => #30091


Comment:

 (this is part of #30091. I argue for 'no backport' since it isn't hurting
 anything for now.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29984 [Core Tor/Tor]: Controller protocol parser can't find empty initial line

[Tor Bug Tracker & Wiki]

#29984: Controller protocol parser can't find empty initial line
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .1
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * actualpoints:   => .1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #29984 [Core Tor/Tor]: Controller protocol parser can't find empty initial line

[Tor Bug Tracker & Wiki]

#29984: Controller protocol parser can't find empty initial line
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+
Description changed by nickm:

Old description:

> We've apparently run into this in a few places before: The code in
> control.c that extracts the command from the command line will discard
> the rest of the line too, if the line is empty.
>
> This means that the control.c code can't distinguish these cases:
> {{{
> FOO A
> B
> C
> .
> }}}
> and
> {{{
> FOO
> A
> B
> C
> }}}

New description:

 We've apparently run into this in a few places before: The code in
 control.c that extracts the command from the command line will discard the
 rest of the line too, if the line is empty.

 This means that the control.c code can't distinguish these cases:
 {{{
 +FOO A
 B
 C
 .
 }}}
 and
 {{{
 +FOO
 A
 B
 C
 }}}

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #29984 [Core Tor/Tor]: Controller protocol parser can't find empty initial line

[Tor Bug Tracker & Wiki]

#29984: Controller protocol parser can't find empty initial line
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 We've apparently run into this in a few places before: The code in
 control.c that extracts the command from the command line will discard the
 rest of the line too, if the line is empty.

 This means that the control.c code can't distinguish these cases:
 {{{
 FOO A
 B
 C
 .
 }}}
 and
 {{{
 FOO
 A
 B
 C
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs