Re: [tor-bugs] #30112 [Core Tor/Tor]: Fix outdated comments in dirserv_read_measured_bandwidths()

[Tor Bug Tracker & Wiki]

#30112: Fix outdated comments in dirserv_read_measured_bandwidths()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  doc, comment, technical-debt, tor-   |  Actual Points:  0.1
  bwauth |
Parent ID:   | Points:  0.1
 Reviewer:  mikeperry|Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks for the review; merged to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30112 [Core Tor/Tor]: Fix outdated comments in dirserv_read_measured_bandwidths()

[Tor Bug Tracker & Wiki]

#30112: Fix outdated comments in dirserv_read_measured_bandwidths()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  doc, comment, technical-debt, tor-   |  Actual Points:  0.1
  bwauth |
Parent ID:   | Points:  0.1
 Reviewer:  mikeperry|Sponsor:
-+-
Changes (by mikeperry):

 * status:  needs_review => merge_ready


Comment:

 Yay updated comments. Looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30112 [Core Tor/Tor]: Fix outdated comments in dirserv_read_measured_bandwidths()

[Tor Bug Tracker & Wiki]

#30112: Fix outdated comments in dirserv_read_measured_bandwidths()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  doc, comment, technical-debt, tor-   |  Actual Points:  0.1
  bwauth |
Parent ID:   | Points:  0.1
 Reviewer:  mikeperry|Sponsor:
-+-
Changes (by asn):

 * reviewer:   => mikeperry


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30112 [Core Tor/Tor]: Fix outdated comments in dirserv_read_measured_bandwidths()

[Tor Bug Tracker & Wiki]

#30112: Fix outdated comments in dirserv_read_measured_bandwidths()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  doc, comment, technical-debt, tor-   |  Actual Points:  0.1
  bwauth |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  doc, comment => doc, comment, technical-debt, tor-bwauth
 * status:  assigned => needs_review


Comment:

 See my pull request:
 https://github.com/torproject/tor/pull/922

 I don't think there is much point in backporting these comments to 0.4.0.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #30112 [Core Tor/Tor]: Fix outdated comments in dirserv_read_measured_bandwidths()

[Tor Bug Tracker & Wiki]

#30112: Fix outdated comments in dirserv_read_measured_bandwidths()
--+
 Reporter:  teor  |  Owner:  teor
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.5.1-alpha
 Severity:  Normal|   Keywords:  doc, comment
Actual Points:  0.1   |  Parent ID:
   Points:  0.1   |   Reviewer:
  Sponsor:|
--+
 We refactored the function to use tor_getdelim(), but didn't remove the
 comments about fgets().

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs