[tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
--+--
 Reporter:  tom   |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Here's the set of patches, in order, for the esr60 backport:

 https://hg.mozilla.org/try/rev/744a475c948ee8c987d43a6348deca5e9a4a5a61
 https://hg.mozilla.org/try/rev/feeb219584667f53e2c6cd2ddcfcaa89fb6ee243
 https://hg.mozilla.org/try/rev/a550c321f24c823efcb2e8033e6c802f9cd6e44b
 https://hg.mozilla.org/try/rev/a5d945dd5b7070c810b93eddd0232d646b73fc2d
 https://hg.mozilla.org/try/rev/b58bfc0bdc2451715ec895fbd06f40061fa301f9
 https://hg.mozilla.org/try/rev/1b23145ed904be055bf0efe1000e03ec50c02cb3
 https://hg.mozilla.org/try/rev/0b1eef9eeb06668fc06b3b4d877daaf957c3c1da

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:   => tbb-fingerprinting-resolution, TorBrowserTeam201905


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 That's not working for me. I think the reason is that there is no
 `Services.locale.appLocaleAsLangTag` on esr60 and hence this breaks early
 on. You'll see something like
 {{{
 TypeError: Services.locale.appLocaleAsLangTag is undefined[Learn More]
 RFPHelper.jsm:189:5
 }}}
 in the browser console.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 Whoops, you're right. Looks like an easy fix though.

 Here's a new set (only changed patch 2):

 https://hg.mozilla.org/try/rev/744a475c948ee8c987d43a6348deca5e9a4a5a61
 https://hg.mozilla.org/try/rev/d929994f46ebb041a623d98aecdeac98266db6c9
 ​https://hg.mozilla.org/try/rev/a550c321f24c823efcb2e8033e6c802f9cd6e44b
 ​https://hg.mozilla.org/try/rev/a5d945dd5b7070c810b93eddd0232d646b73fc2d
 ​https://hg.mozilla.org/try/rev/b58bfc0bdc2451715ec895fbd06f40061fa301f9
 ​https://hg.mozilla.org/try/rev/1b23145ed904be055bf0efe1000e03ec50c02cb3
 ​https://hg.mozilla.org/try/rev/0b1eef9eeb06668fc06b3b4d877daaf957c3c1da

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-fingerprinting-resolution, TorBrowserTeam201905 =>
 tbb-fingerprinting-resolution, TorBrowserTeam201905R,
 GeorgKoppen201905
 * status:  new => needs_review


Comment:

 Okay, I have those patches another try and played with it. Nice work, tjr!
 `bug_30372_v2` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/log/?h=bug_30372_v2) has backport of the seven patches to Tor
 Browser up for review.

 tjr: One thing I noticed with letterboxing active: if I open e.g. the find
 bar then letterboxing does not take that into account (e.g. before the
 height was 600px and after the find bar showed up it's just 563px). That
 seems like a bug to me (not sure if that's already tracked somewhere or
 not).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by Thorin):

 The findbar is only toggled on/off per tab, whereas the letterboxing is
 set per window (and all the tabs in that window)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 https://bugzilla.mozilla.org/show_bug.cgi?id=1546832 is for the Find Bar.
 It is not fixed yet; but I don't think it's a blocker for putting this in
 Nightly...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 Also; there were some non-functional changes on the latest patch;
 https://phabricator.services.mozilla.com/D29759?download=true may be good
 to take just to stay in sync with upstream - it could avoid a conflict if
 I manage find time to fix 1546832

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:7 tom]:
 > Also; there were some non-functional changes on the latest patch;
 https://phabricator.services.mozilla.com/D29759?download=true may be good
 to take just to stay in sync with upstream - it could avoid a conflict if
 I manage find time to fix 1546832

 Sounds good. I updated `bug_30372_v2` with the backport
 (https://gitweb.torproject.org/user/gk/tor-
 
browser.git/commit/?h=bug_30372_v2&id=d5412b0b31227973660d5532e6d0a8228b580cf3).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by acat):

 I think there's something wrong with
 https://d3kxowhw4s8amj.cloudfront.net/file/data/3mrddyqn42twqubxslh3/PHID-
 FILE-j4tddtqktkpxt66evkb5/D29759.diff. The `defaultRounding` function was
 deleted but I don't see that change in
 https://phabricator.services.mozilla.com/D29759?download=true. Also,
 `onst` instead of `const` :).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by acat):

 Sorry, I meant https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_30372_v2&id=d5412b0b31227973660d5532e6d0a8228b580cf3
 instead of
 https://d3kxowhw4s8amj.cloudfront.net/file/data/3mrddyqn42twqubxslh3/PHID-
 FILE-j4tddtqktkpxt66evkb5/D29759.diff.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by tom):

 The last patch in the series I posted above has landed as
 https://hg.mozilla.org/mozilla-central/rev/6d2d7856e468 so the last two
 patches in that branch can be dropped in favor of this single one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:9 acat]:
 > I think there's something wrong with
 https://d3kxowhw4s8amj.cloudfront.net/file/data/3mrddyqn42twqubxslh3/PHID-
 FILE-j4tddtqktkpxt66evkb5/D29759.diff. The `defaultRounding` function was
 deleted but I don't see that change in
 https://phabricator.services.mozilla.com/D29759?download=true. Also,
 `onst` instead of `const` :).

 Ugh, the `onst` :(. I've fixed that in the new banch `bug_30372_v3`
 (https://gitweb.torproject.org/user/gk/tor-
 browser.git/log/?h=bug_30372_v3), following tom's advice to drop the last
 two patches in favor of the one new one. Regarding `defaultRounding` it
 got added in

 https://hg.mozilla.org/try/rev/0b1eef9eeb06668fc06b3b4d877daaf957c3c1da

 . However, the patch tom pointed to to keep us in sync is probably from a
 later state where `defaultRounding` was already gone. I adapted the patch
 for our esr60.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by acat):

 Looks good to me now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30372 [Applications/Tor Browser]: Backport Letterboxing

[Tor Bug Tracker & Wiki]

#30372: Backport Letterboxing
-+-
 Reporter:  tom  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-fingerprinting-resolution,   |  Actual Points:
  TorBrowserTeam201905R, GeorgKoppen201905   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks. Pushed to `tor-browser-60.6.1esr-9.0-1` as commits
 0958b375400c51ddd1c61cda14acae686697729b
 7f3ce3ef4cf86690864a4abd7ca58a9e5dbb087f
 69e7b6d159f3d7ec4d8e0987afe1925ade94c0f6
 06bed4d6845f681755c1e51db9497aeeaa5cd259
 610ad333716499f5f9cf704a1dd97e07d276f572
 003019c16626dc515d5fe9defb999be1ab8ad397
 166a752ab22ef1415c250eff37e1ada3f2f24915
 .

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs