Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  network-team-roadmap-july  |  Actual Points:  .2
Parent ID:  #29746 | Points:  1.5
 Reviewer:  teor   |Sponsor:  Sponsor31-can
---+---
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Merged

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-july  |  Actual Points:  .2
Parent ID:  #29746 | Points:  1.5
 Reviewer:  teor   |Sponsor:  Sponsor31-can
---+---

Comment (by nickm):

 Replying to [comment:9 catalyst]:
 > The Makefile should provide a way to pass command line options in to
 practracker from the environment, so CI won't have to run practracker by
 bypassing the Makefile. This can be useful if we want to run with less-
 friendly options during cron builds, for example.

 Created #31309 for this issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-july  |  Actual Points:  .2
Parent ID:  #29746 | Points:  1.5
 Reviewer:  teor   |Sponsor:  Sponsor31-can
---+---
Changes (by nickm):

 * parent:   => #29746


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-july  |  Actual Points:  .2
Parent ID: | Points:  1.5
 Reviewer:  teor   |Sponsor:  Sponsor31-can
---+---

Comment (by nickm):

 The abovementioned branch now also contains fixes for #31202 (refactoring)
 and #31263 (integration tests).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-july  |  Actual Points:  .2
Parent ID: | Points:  1.5
 Reviewer:  catalyst   |Sponsor:  Sponsor31-can
---+---

Comment (by catalyst):

 Minor comments:

 typo in commit summary `Pracktracker: give the number of new errors
 found.`

 The Makefile should provide a way to pass command line options in to
 practracker from the environment, so CI won't have to run practracker by
 bypassing the Makefile. This can be useful if we want to run with less-
 friendly options during cron builds, for example.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-july  |  Actual Points:  .2
Parent ID: | Points:  1.5
 Reviewer:  catalyst   |Sponsor:  Sponsor31-can
---+---

Comment (by catalyst):

 Overall these look good. I'd like to do a bit of manual testing to make
 sure the changes work as advertised.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-july  |  Actual Points:  .2
Parent ID: | Points:  1.5
 Reviewer: |Sponsor:  Sponsor31-can
---+---
Changes (by gaba):

 * cc: nickm, teor (added)
 * keywords:   => network-team-roadmap-july


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .2
Parent ID:| Points:  1.5
 Reviewer:|Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => .2


Comment:

 See my branch `practracker_fixes` with PR at
 https://github.com/torproject/tor/pull/1177 . It includes fixes for the
 issues above, and for the issues in #29746.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  1.5
 Reviewer:|Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  1.5
 Reviewer:|Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * points:   => 1.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by catalyst):

 Replying to [comment:1 teor]:
 > Practracker failures are a bad and confusing experience for new
 contributors (and researchers).
 I agree.
 >
 > Maybe it should be off by default? Or warn unless you set an env var
 that makes it fail?
 I think maybe the stricter options should only run on cron builds? As
 could the option that warns about exceptions that either could be lowered
 or deleted.

 I think we might still want to have a (small?) tolerance that practracker
 will use when run from `make check`. But maybe we also want reviewers to
 look at small regressions in practices that are within the tolerances but
 that show up as warnings in the pull requests?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by teor):

 Practracker failures are a bad and confusing experience for new
 contributors (and researchers).

 Maybe it should be off by default? Or warn unless you set an env var that
 makes it fail?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #30752 [Core Tor/Tor]: Practracker: usability improvements from May retrospective

[Tor Bug Tracker & Wiki]

#30752: Practracker: usability improvements from May retrospective
---+
 Reporter:  nickm  |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 We talked about a few possible improvements to practracker in our May
 retrospective a couple of weeks back.  Here are the suggestions we came up
 with.

 1. Practracker should have tolerances in its exceptions.  For example, if
 an exception allows a function to be 150 lines long, then we should not
 cause an error until the function is (say) 155 lines long.  If the
 function is 151-154 lines long, that should just be a warning.

 These tolerances could be percentage-based, or just flat numbers.

 There should be an option that makes all warnings fatal.

 2. There should be an option to list unused exceptions, and exceptions
 that are larger than they need to be.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs