Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201911  |  Actual Points:
Parent ID:  #32069| Points:  2
 Reviewer:|Sponsor:
--+
Changes (by pili):

 * points:   => 2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201910  |  Actual Points:
Parent ID:  #32069| Points:
 Reviewer:|Sponsor:
--+

Comment (by eighthave):

 Yeah, there are two other repos:
 * tor-android-binary from my fork: https://gitlab.com/eighthave/tor-
 android.git
 * _jni-api_ branch from my fork: https://gitlab.com/eighthave/tor.git

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201910  |  Actual Points:
Parent ID:  #32069| Points:
 Reviewer:|Sponsor:
--+

Comment (by sisbell):

 Where is the org.torproject.jni.TorService class located? Is this in a
 different repo?

 Replying to [comment:11 eighthave]:
 > I just pushed the rough work to my dev fork's ''master'' branch. This is
 not buildable yet, except on my machine, but I'll keep updating it there
 as I get things nailed down.
 > https://gitlab.com/eighthave/orbot/tree/master
 >
 >
 > Also, this has a couple small steps towards separating out the VPN code:
 > https://github.com/guardianproject/orbot/pull/277

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201910  |  Actual Points:
Parent ID:  #32069| Points:
 Reviewer:|Sponsor:
--+

Comment (by eighthave):

 I just pushed the rough work to my dev fork's ''master'' branch. This is
 not buildable yet, except on my machine, but I'll keep updating it there
 as I get things nailed down.
 https://gitlab.com/eighthave/orbot/tree/master


 Also, this has a couple small steps towards separating out the VPN code:
 https://github.com/guardianproject/orbot/pull/277

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201910  |  Actual Points:
Parent ID:  #32069| Points:
 Reviewer:|Sponsor:
--+

Comment (by eighthave):

 FYI, I have native TorService integrated in Orbot at a crude level, so
 once I push that somewhere public, you'll be able to see the scope of the
 changes I'm making.  That will happen this week.  I'll be upstreaming the
 streamlining changes first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201910  |  Actual Points:
Parent ID:  #32069| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * keywords:  TorBrowserTeam201910R => TorBrowserTeam201910
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:8 sisbell]:
 > It looks like we should hold off until the work is done in the new tor
 service. There are a bunch more changes in Orbot since this time so I
 suspect that latest version of Orbot wouldn't be compatible with these
 changes (although tor-browser would be compatible).

 Works for me. Removing the review keyword and setting the ticket into
 `needs_revision`.

 > Replying to [comment:6 gk]:
 > > sisbell: I guess the patch in comment:1 is still up-to-date? And,
 please add the respective review keyword to your tickets when done
 otherwise we might easily lose track of them. It's TorBrowserTeamMMR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201910R |  Actual Points:
Parent ID:  #32069| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 It looks like we should hold off until the work is done in the new tor
 service. There are a bunch more changes in Orbot since this time so I
 suspect that latest version of Orbot wouldn't be compatible with these
 changes (although tor-browser would be compatible).

 Replying to [comment:6 gk]:
 > sisbell: I guess the patch in comment:1 is still up-to-date? And, please
 add the respective review keyword to your tickets when done otherwise we
 might easily lose track of them. It's TorBrowserTeamMMR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201910R |  Actual Points:
Parent ID:  #32069| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Ah, nvm regarding my first question, I am seeing comment:4 now (the other
 part holds, though).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201910R |  Actual Points:
Parent ID:  #32069| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:  TorBrowserTeam201910 => TorBrowserTeam201910R


Comment:

 sisbell: I guess the patch in comment:1 is still up-to-date? And, please
 add the respective review keyword to your tickets when done otherwise we
 might easily lose track of them. It's TorBrowserTeamMMR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201910  |  Actual Points:
Parent ID:  #32069| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 Replying to [comment:2 eighthave]:
 > Does Tor Browser need anything from the VPN side?  Or is it just there
 as a remnant from ripping the code out of Orbot?

 VPN is not needed for Tor Browser, its just moving out the VPN code so
 that we can make it an independent module that needn't be built as part of
 the tor browser build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201910  |  Actual Points:
Parent ID:  #32069| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sisbell):

 * keywords:  TorBrowserTeam201906 => TorBrowserTeam201910
 * parent:  #31042 => #32069


Comment:

 https://github.com/sisbell/tor-android-
 service/commit/03dc6cd426eba5ce43d800356e92a5e89cb65161

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201906  |  Actual Points:
Parent ID:  #31042| Points:
 Reviewer:|Sponsor:
--+--
Changes (by eighthave):

 * cc: hans@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201906  |  Actual Points:
Parent ID:  #31042| Points:
 Reviewer:|Sponsor:
--+--

Comment (by eighthave):

 Does Tor Browser need anything from the VPN side?  Or is it just there as
 a remnant from ripping the code out of Orbot?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201906  |  Actual Points:
Parent ID:  #31042| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sisbell):

 * status:  new => needs_review


Comment:

 Changes: https://github.com/sisbell/tor-android-service/commits/0628

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31043 [Applications/Tor Browser]: Separate VPN Classes into their own module

[Tor Bug Tracker & Wiki]

#31043: Separate VPN Classes into their own module
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
  |  TorBrowserTeam201906
Actual Points:|  Parent ID:  #31042
   Points:|   Reviewer:
  Sponsor:|
--+
 The VPN and TorService code isn't correctly layered. It has some
 interdependence.

 By breaking out the code, it should be easier to maintain. Its also easier
 to strip out the VPN for Tor Browser, while maintaining it for Orbot.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs