Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-11-05 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.4-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  consider-backport-after-0423 029-backport  |
  035-backport 040-backport 041-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.2.9.x-final


Comment:

 Merged to 0.2.9 and later.
 Merged #31107, #31466, #30916, #31408, #31837, and #31897 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-10-22 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  consider-backport-after-0423 029-backport  |
  035-backport 040-backport 041-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.0.x-final


Comment:

 Backported to 0.4.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-10-01 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  consider-backport-after-0423 029-backport  |
  035-backport 040-backport 041-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * keywords:
 tor-relay, tor-channel 042-must consider-backport-after-0433
 029-backport? 035-backport 040-backport 041-backport BugSmashFund
 =>
 tor-relay, tor-channel 042-must consider-backport-after-0423
 029-backport 035-backport 040-backport 041-backport BugSmashFund


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-25 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  consider-backport-after-0433 029-backport? |
  035-backport 040-backport 041-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by asn):

 * keywords:
 tor-relay, tor-channel 042-must consider-backport-after-0433
 029-backport? 035-backport 040-backport 041-backport BugSmashFund asn-
 merge
 =>
 tor-relay, tor-channel 042-must consider-backport-after-0433
 029-backport? 035-backport 040-backport 041-backport BugSmashFund
 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.1.x-final


Comment:

 Merged. Leaving open for backports.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-23 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  consider-backport-after-0433 029-backport? |
  035-backport 040-backport 041-backport |
  BugSmashFund asn-merge |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 tor-relay, tor-channel 042-must consider-backport-after-0433
 029-backport? 035-backport 040-backport 041-backport BugSmashFund
 =>
 tor-relay, tor-channel 042-must consider-backport-after-0433
 029-backport? 035-backport 040-backport 041-backport BugSmashFund asn-
 merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-23 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.4.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  consider-backport-after-0433 029-backport? |
  035-backport 040-backport 041-backport |
  BugSmashFund   |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => merge_ready
 * keywords:
 tor-relay, tor-channel 042-must 029-backport? 035-backport
 040-backport 041-backport BugSmashFund
 =>
 tor-relay, tor-channel 042-must consider-backport-after-0433
 029-backport? 035-backport 040-backport 041-backport BugSmashFund
 * version:   => Tor: 0.2.4.4-alpha


Comment:

 Looks fine to me, and looks like a low-risk backport

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-23 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  029-backport? 035-backport 040-backport|
  041-backport BugSmashFund  |
Parent ID:   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-17 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  029-backport? 035-backport 040-backport|
  041-backport BugSmashFund  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 (practracker failure fixed)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-17 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  029-backport? 035-backport 040-backport|
  041-backport BugSmashFund  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 (oops. There is a practracker failure on master.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-17 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  029-backport? 035-backport 040-backport|
  041-backport BugSmashFund  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 CI has passed

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-17 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  029-backport? 035-backport 040-backport|
  041-backport BugSmashFund  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 The right solution here is to make this `tor_fragile_assert()` into a
 protocol warning, since it happens when somebody else is violating the
 protocol.  It is not a security issue or a crash after all. (Hooray!)

 0.2.9 fix: bug31107_029. PR at https://github.com/torproject/tor/pull/1330

 The merge forward is clean; these branches are for CI.

 0.3.5 fix: bug31107_035. PR at https://github.com/torproject/tor/pull/1331
 0.4.0 fix: bug31107_040. PR at https://github.com/torproject/tor/pull/1332
 0.4.1 fix: bug31107_041. PR at https://github.com/torproject/tor/pull/1333
 0.4.2 fix: bug31107_master. PR at
 https://github.com/torproject/tor/pull/1334

 I'll put this in needs_review once CI is passing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-17 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:  .1
  029-backport? 035-backport 040-backport|
  041-backport BugSmashFund  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * actualpoints:   => .1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-17 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:
  029-backport? 035-backport 040-backport|
  041-backport BugSmashFund  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Okay, here is a better diagnosis.

 The problem is that cell_command_is_var_length() looks at the link
 protocol version when deciding whether a cell is variable-length.  That's
 cool, but it does mean that CELL_VERSIONS is not necessarily a variable-
 length cell.  So if somebody sends a VERSIONS cell on a v1 connection,
 we'll hit this warning.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-17 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:
  029-backport? 035-backport 040-backport|
  041-backport BugSmashFund  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Ohhh, wait.  It doesn't actually work that way.  I need to reconsider.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-17 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  High |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel 042-must  |  Actual Points:
  029-backport? 035-backport 040-backport|
  041-backport BugSmashFund  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-relay, tor-channel security 042-must =>
 tor-relay, tor-channel 042-must 029-backport? 035-backport
 040-backport 041-backport BugSmashFund
 * priority:  Very High => High


Comment:

 Okay, this is a bug, and an old one.  It looks like our logic in
 connection_or_process_cells_from_inbuf() is wrong in the way that it
 handles variable-length cells.

 Basically, what it is doing right now it this:
 {{{
 try to fetch var_cell_t from buffer.
 if (we got a var_cell_t) {
give it to the channel layer.
return
 }
 see whether we have more than 512/514 bytes on the buffer
 if (we do) {
package it as a cell_t
give it to the channel layer
return;
 }
 wait for more data
 }}}

 See the problem?  If we have a pending incomplete variable-length cell of
 more than 512/514 bytes, it will get mis-packaged as a regular fixed-
 length cell.

 What fun!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-17 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel security  |  Actual Points:
  042-must   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-relay, tor-channel security crash 042-must => tor-relay,
 tor-channel security 042-must


Comment:

 Okay.  Fortunately, this isn't a crash: tor_fragile_assert() just logs a
 stack trace like this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-16 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Very High|  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel security  |  Actual Points:
  crash 042-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-10 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel security  |  Actual Points:
  crash 042-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-relay, tor-channel security crash => tor-relay, tor-
 channel security crash 042-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-05 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel security  |  Actual Points:
  crash  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 See also #31221 and #31136

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-09-05 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
-+-
 Reporter:  dgoulet  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, tor-channel security  |  Actual Points:
  crash  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-relay, tor-channel => tor-relay, tor-channel security
   crash


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-07-13 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
+
 Reporter:  dgoulet |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-relay, tor-channel  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by jk):

 Experienced same error - details below:

  16:06:35 [NYX_NOTICE] BUG: Unexpected exception from ConnectionTracker:
 'getpwnam(): name not found: _tor-instance1' [314 duplicates hidden]
  15:53:43 [WARN] Bug: /usr/bin/tor(+0x55ec4) [0x4e2ec4] (on Tor
 0.3.5.8 )
  15:53:43 [WARN] Bug: /usr/bin/tor(connection_handle_read+0x960)
 [0x4dc564] (on Tor 0.3.5.8 )
  15:53:43 [WARN] Bug: /usr/bin/tor(+0x8c554) [0x519554] (on Tor
 0.3.5.8 )
  15:53:43 [WARN] Bug: /usr/bin/tor(channel_tls_handle_cell+0x4a8)
 [0x4f1b1c] (on Tor 0.3.5.8 )
  15:53:43 [WARN] Bug: /usr/bin/tor(tor_bug_occurred_+0xb4) [0x687a78]
 (on Tor 0.3.5.8 )
  15:53:43 [WARN] Bug: /usr/bin/tor(log_backtrace_impl+0x4c) [0x68c8c4]
 (on Tor 0.3.5.8 )
  15:53:43 [WARN] Bug: Line unexpectedly reached at channel_tls_handle_cell
 at ../src/core/or/channeltls.c:. Stack trace: (on Tor 0.3.5.8)
  15:53:43 [WARN] tor_bug_occurred_(): Bug:
 ../src/core/or/channeltls.c:: channel_tls_handle_cell: This line
 should not have been reached. (Future instances of this warning will be
 silenced.) (on Tor 0.3.5.8 )

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31107 [Core Tor/Tor]: channel: channel_tls_handle_cell() CELL_VERSIONS code reached

2019-07-08 Thread Tor Bug Tracker & Wiki 
#31107: channel: channel_tls_handle_cell() CELL_VERSIONS code reached
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-relay, tor-channel
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Relay operator reported this 2 days ago:

 https://lists.torproject.org/pipermail/tor-relays/2019-July/017486.html

 This code has been reached in `channel_tls_handle_cell()`:

 {{{
 case CELL_VERSIONS:
   tor_fragile_assert();
   break;
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs