Re: [tor-bugs] #31322 [Applications/Tor Browser]: Fix about:tor assertion failure in esr68 linux debug builds

[Tor Bug Tracker & Wiki]

#31322: Fix about:tor assertion failure in esr68 linux debug builds
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good, thanks! Merged to `master` (commit
 f4530dc77da1a2c204674be33797d399c2bf597c)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31322 [Applications/Tor Browser]: Fix about:tor assertion failure in esr68 linux debug builds

[Tor Bug Tracker & Wiki]

#31322: Fix about:tor assertion failure in esr68 linux debug builds
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by cypherpunks):

 About about: pages: https://bugzilla.mozilla.org/show_bug.cgi?id=1430748

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31322 [Applications/Tor Browser]: Fix about:tor assertion failure in esr68 linux debug builds

[Tor Bug Tracker & Wiki]

#31322: Fix about:tor assertion failure in esr68 linux debug builds
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by acat):

 I filed #31395, I think it's good to remove the inline script + unsafe-
 inline in the CSP, but not a security issue in this context.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31322 [Applications/Tor Browser]: Fix about:tor assertion failure in esr68 linux debug builds

[Tor Bug Tracker & Wiki]

#31322: Fix about:tor assertion failure in esr68 linux debug builds
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-

Comment (by mcs):

 r=brade,r=mcs

 We did not test this but it looks good.
 Kathy and I don't know enough about the security implications of using
 `unsafe-inline`; do we need to file a new ticket about removing the need
 for that option?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31322 [Applications/Tor Browser]: Fix about:tor assertion failure in esr68 linux debug builds

[Tor Bug Tracker & Wiki]

#31322: Fix about:tor assertion failure in esr68 linux debug builds
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor44-can
-+-
Changes (by acat):

 * keywords:  ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201908 =>
 ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201908R
 * status:  new => needs_review


Comment:

 Patch in https://github.com/acatarineu/torbutton/commit/31322

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31322 [Applications/Tor Browser]: Fix about:tor assertion failure in esr68 linux debug builds

[Tor Bug Tracker & Wiki]

#31322: Fix about:tor assertion failure in esr68 linux debug builds
-+-
 Reporter:  acat |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201908   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  ff68-esr => ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201908


Comment:

 Let's put it into our alpha-must category. The earlier we fix it the
 better, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31322 [Applications/Tor Browser]: Fix about:tor assertion failure in esr68 linux debug builds

[Tor Bug Tracker & Wiki]

#31322: Fix about:tor assertion failure in esr68 linux debug builds
--+--
 Reporter:  acat  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff68-esr
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 I found this assertion failure when testing #30429 in linux, debug build.
 It happens when loading `about:tor`:

 `Assertion failure: foundDefaultSrc (about: page must contain a CSP
 including default-src), at /home/user/tor/tor-
 browser/dom/base/Document.cpp:5179`

 We should investigate this, but not sure if it's `tbb-9.0-must-nightly`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs