Re: [tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 FWIW we fixed #30662 here as well while we were at it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good to me. Cherry-picked onto `tor-browser-68.1.0esr-9.0-2` (commit
 fa3095e61aacd345601435a0e91ee2b44e1a9b07 and
 e11a1889ae871a9ced871346f5f9eb3e0a9ab6d3).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * status:  needs_revision => needs_review
 * keywords:  ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909 =>
 ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R


Comment:

 >Note that the English title of the about:tor page is About Tor. I think
 we should use that in the preferences UI rather than Tor Browser Home but
 of course other people may have different opinions. For me, Tor Browser
 Home introduces a new term without much benefit.

 Thanks! I think it makes a lot of sense, going that route for now. Patch
 for review: https://github.com/acatarineu/tor-browser/commits/31575+2.

 I also changed [https://github.com/acatarineu/tor-browser/commit/31575+2
 #diff-a400b1ceb12ef6e65579411ba4a8867aR20 this] so that the default
 `about:tor` does not appear as `Custom URL` in `about:preferences`, but as
 `About Tor` (`about:home` also redirects to `about:tor`, but that's not
 the default value for `browser.startup.homepage`).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * cc: antonela, pili (added)


Comment:

 Replying to [comment:8 acat]:
 > Sorry, it still remains to change `Firefox Home` string to `Tor Browser
 Home` and localize it. I was not sure whether to do that separately later,
 but I think it's worth it doing it here, so setting it as revision_needed
 and will do that change too.

 Note that the English title of the about:tor page is `About Tor`. I think
 we should use that in the preferences UI rather than `Tor Browser Home`
 but of course other people may have different opinions. For me, `Tor
 Browser Home` introduces a new term without much benefit.

 Cc: Antonela and Pili in case they have smart things to say ;)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * keywords:  ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R =>
 ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909
 * status:  needs_review => needs_revision


Comment:

 Sorry, it still remains to change `Firefox Home` string to `Tor Browser
 Home` and localize it. I was not sure whether to do that separately later,
 but I think it's worth it doing it here, so setting it as revision_needed
 and will do that change too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * keywords:  ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909 =>
 ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R
 * status:  needs_revision => needs_review


Comment:

 Patch for review in https://github.com/acatarineu/tor-
 browser/commits/31575+1 (two commits).

 Now choosing "Firefox Home" for newtab or home in `about:preferences` will
 load `about:tor` instead of Firefox newtab. For newtab the default will be
 `about:blank`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R =>
 ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909
 * status:  needs_information => needs_revision


Comment:

 If we's go that route then we should rip the code out not comment it
 because the latter makes it harder to figure out what part is actually a
 comment and what part is just code we don't use due to a patch. Let's use
 commenting just for comments.

 So, marking that as `needs revision` either way.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:3 acat]:
 > Patch for review in https://github.com/acatarineu/tor-
 browser/commits/31575 (two commits).
 >
 > I investigated a bit where these requests where coming from, and all are
 from the newtab ActivityStream. The first ones (containing cfr-fxa) are
 done in [https://searchfox.org/mozilla-
 
esr68/rev/5c4a430c9101024114854f47926fdfacc5502294/browser/components/newtab/lib/ASRouter.jsm#238
 ASRouter.jsm], which calls [https://searchfox.org/mozilla-
 
esr68/rev/5c4a430c9101024114854f47926fdfacc5502294/services/settings/RemoteSettingsClient.jsm#254
 RemoteSettingsClient.jsm] and that does a bunch of fetches to sync. The
 snippets ones are coming from [https://searchfox.org/mozilla-
 
esr68/rev/5c4a430c9101024114854f47926fdfacc5502294/browser/components/newtab/lib/ASRouter.jsm#170
 ASRouter.jsm].
 >
 > There are a bunch of `browser.newtabpage.activity-stream.*` prefs that
 probably we could use to disable these, but I opted for the simple
 solution of just not loading the `AboutNewTab.jsm` at all. That means it's
 not possible anymore to change the newtab page, so I also removed that
 option from the UI in the patch.

 Hrm. I am not sure we should strip users from easily adjusting their new
 tab experience. Would we solve this bug by just flipping the prefs? I
 guess that would still fix #30846 as well? What about #30662?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by acat):

 If the approach is ok, I think this would also fix #30846 and #30662.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909R  |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * keywords:  ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909 =>
 ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909R
 * status:  new => needs_review


Comment:

 Patch for review in https://github.com/acatarineu/tor-
 browser/commits/31575 (two commits).

 I investigated a bit where these requests where coming from, and all are
 from the newtab ActivityStream. The first ones (containing cfr-fxa) are
 done in [https://searchfox.org/mozilla-
 
esr68/rev/5c4a430c9101024114854f47926fdfacc5502294/browser/components/newtab/lib/ASRouter.jsm#238
 ASRouter.jsm], which calls [https://searchfox.org/mozilla-
 
esr68/rev/5c4a430c9101024114854f47926fdfacc5502294/services/settings/RemoteSettingsClient.jsm#254
 RemoteSettingsClient.jsm] and that does a bunch of fetches to sync. The
 snippets ones are coming from [https://searchfox.org/mozilla-
 
esr68/rev/5c4a430c9101024114854f47926fdfacc5502294/browser/components/newtab/lib/ASRouter.jsm#170
 ASRouter.jsm].

 There are a bunch of `browser.newtabpage.activity-stream.*` prefs that
 probably we could use to disable these, but I opted for the simple
 solution of just not loading the `AboutNewTab.jsm` at all. That means it's
 not possible anymore to change the newtab page, so I also removed that
 option from the UI in the patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,|  Actual Points:
  TorBrowserTeam201909   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by pili):

 * points:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31575 [Applications/Tor Browser]: Firefox is phoning home during start-up in Tor Browser based on ESR 68

[Tor Bug Tracker & Wiki]

#31575: Firefox is phoning home during start-up in Tor Browser based on ESR 68
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  ff68-esr, tbb-9.0-must-
 Severity:  Normal   |  alpha, TorBrowserTeam201909
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Starting up one can see a bunch of requests going to Mozilla owned
 domains:
 {{{
 
https://firefox.settings.services.mozilla.com/v1/buckets/monitor/collections/changes/records?collection
 =cfr-fxa=main
 https://firefox.settings.services.mozilla.com/v1/buckets/main/collections
 /cfr-fxa?_expected=1562598365297
 https://firefox.settings.services.mozilla.com/v1/buckets/main/collections
 /cfr-fxa/records?_expected=1562598365297&_sort=-last_modified
 https://content-signature-2.cdn.mozilla.net/chains/remote-settings
 .content-signature.mozilla.org-2019-10-02-18-15-08.chain

 https://snippets.cdn.mozilla.net/us-
 west/bundles/bundle_8afc759e26e7da7a6283552f250fdf0a5602f4f3.json
 }}}
 We should figure out what we should do with those requests/underlying
 functionality.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs