Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:  0.5
  TorBrowserTeam201910R tbb-9.0-must |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 It looks like this worked. I tested it on my device.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:  0.5
  TorBrowserTeam201910R tbb-9.0-must |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 This looks good to me, too. Applied to `master` (commit
 9d744c6adc5ee3608e519c5db49528cd6ee6fe54).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:  0.5
  TorBrowserTeam201910R tbb-9.0-must |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  needs_review => merge_ready


Comment:

 Okay, I think this'll work. Let's use it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:  0.5
  TorBrowserTeam201910R tbb-9.0-must |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * actualpoints:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:
  TorBrowserTeam201910R tbb-9.0-must |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * status:  needs_revision => needs_review
 * keywords:  tbb-mobile, tbb-parity, TorBrowserTeam201910 tbb-9.0-must =>
 tbb-mobile, tbb-parity, TorBrowserTeam201910R tbb-9.0-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:
  TorBrowserTeam201910 tbb-9.0-must  |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by acat):

 In the first version which I didn't push I was doing a similar thing,
 reusing the function `read_setting_from_prefs`. I think I switched to just
 checking the security level because I thought in any case it would be
 possible to set these prefs to `true` without user wanting, and that it
 would not be very likely that a user which did not change the security
 level slider would have set `ion`, `baselinejit` and `native_regexp`
 manually to `false`.

 But I think the one you suggest is probably better here, it's on the safer
 side. It's true that there could be the case that a user kept level 4 and
 just flipped some of `media.webaudio.enabled`, `mathml.disabled`,
 `gfx.font_rendering.opentype_svg.enabled` or `svg.disabled`, in which case
 with the this fix we would wrongly keep `ion`, `baselinejit` or
 `native_regexp` to `false` (with an unnecessary performance hit). But
 given that no solution is perfect, I think it's better to prioritize
 security over performance.

 For both fixes, there's always the case that for a user who kept security
 level to 4 and disabled `ion`, `baselinejit` or `native_regexp` we will be
 wrongly enabling these. So I think in any case having some warning it's
 good, not sure where. Probably somewhere in release notes and/or blog post
 is enough.

 So here is the revised fix:
 https://github.com/acatarineu/torbutton/commit/31730+2

 I'm also checking that the slider value is 4, to rule out cases where user
 moved the security slider to < 3 but flipped some prefs in a way that
 those have the same value as level 4 (very unlikely, but...).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:
  TorBrowserTeam201910 tbb-9.0-must  |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-parity, TorBrowserTeam201910R tbb-9.0-must =>
 tbb-mobile, tbb-parity, TorBrowserTeam201910 tbb-9.0-must


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:
  TorBrowserTeam201910R tbb-9.0-must |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * keywords:  tbb-mobile, tbb-parity, TorBrowserTeam201910R, tbb-9.0-must =>
 tbb-mobile, tbb-parity, TorBrowserTeam201910R tbb-9.0-must
 * status:  needs_review => needs_revision


Comment:

 If I was smart, I would've saved the current prefs somehow before we
 overwrote them, but I didn't think about that. Unfortunately, I'm worried
 about changing these. On the one hand, custom prefs aren't recommended but
 they are allowed. If we change this without notifying the user then we
 could be putting them at risk. We should probably include a warning about
 this in the release announcement, at a minimum.

 I think we should set `kCustomPref` as `false` if all the prefs are set as
 level 4. What do you think? Can you add a function
 `isSecurityLevel(index)` that takes an index and iterates through
 `kSecuritySettings`, returns true if they match the expected value and
 false otherwise? Or something like this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:
  TorBrowserTeam201910R, tbb-9.0-must|
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-

Comment (by acat):

 Actually, I think ​https://github.com/acatarineu/torbutton/commit/31730+1
 is a bit more precise. This will preserve the user custom state if they
 did not change any of the `javascript.options.*` prefs (but some of the
 others).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:
  TorBrowserTeam201910R, tbb-9.0-must|
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * status:  new => needs_review
 * keywords:  tbb-mobile, tbb-parity, TorBrowserTeam201910, tbb-9.0-must =>
 tbb-mobile, tbb-parity, TorBrowserTeam201910R, tbb-9.0-must


Comment:

 For review: https://github.com/acatarineu/torbutton/commit/31730.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:
  TorBrowserTeam201910, tbb-9.0-must |
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: sysrqb (added)
 * points:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-parity,  |  Actual Points:
  TorBrowserTeam201910, tbb-9.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 The security level is set automatically both back and forth.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31730 [Applications/Tor Browser]: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9

[Tor Bug Tracker & Wiki]

#31730: Revert aarch64 fixup for ESR 60-based bundles with Tor Browser 9
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-mobile, tbb-parity,
 Severity:  Normal   |  TorBrowserTeam201910, tbb-9.0-must
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 We solved #31616 and #31140 by making sure the JIT prefs are not enabled
 via our security slider on aarch64.

 We need to revert that for Tor Browser 9 and make sure that the security
 level is actually reset to `low` for those users whose level got set to
 `custom` due to the workaround we deployed. (Doing the latter might
 actually not be trivial).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs