[tor-bugs] #31853 [Core Tor/Tor]: Move this_not_that.md into our coding standards document

[Tor Bug Tracker & Wiki]

#31853: Move this_not_that.md into our coding standards document
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  network-team-roadmap-november,
 Severity:  Normal   |  s31-docs
Actual Points:   |  Parent ID:  #29214
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 There seems to be some overlap between our coding standards and the advice
 in this_not_that.md.

 We should merge that advice into the coding standards.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31853 [Core Tor/Tor]: Move this_not_that.md into our coding standards document

[Tor Bug Tracker & Wiki]

#31853: Move this_not_that.md into our coding standards document
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  implemented
  s31-docs   |  Actual Points:  .1
Parent ID:  #29214   | Points:
 Reviewer:  nickm|Sponsor:
 |  Sponsor31-can
-+-
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => implemented
 * sponsor:   => Sponsor31-can
 * actualpoints:   => .1


Comment:

 I've merged your patch, then gone through and merged the remaining items
 from this-not-that.md.  Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31853 [Core Tor/Tor]: Move this_not_that.md into our coding standards document

[Tor Bug Tracker & Wiki]

#31853: Move this_not_that.md into our coding standards document
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:
  s31-docs   |
Parent ID:  #29214   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by rl1987):

 * status:  new => needs_review


Comment:

 https://github.com/torproject/tor/pull/1367

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31853 [Core Tor/Tor]: Move this_not_that.md into our coding standards document

[Tor Bug Tracker & Wiki]

#31853: Move this_not_that.md into our coding standards document
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:
  s31-docs   |
Parent ID:  #29214   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31853 [Core Tor/Tor]: Move this_not_that.md into our coding standards document

[Tor Bug Tracker & Wiki]

#31853: Move this_not_that.md into our coding standards document
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  network-team-roadmap-november,   |  Actual Points:
  s31-docs   |
Parent ID:  #29214   | Points:
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 This looks good to me, but there are still parts of this-not-that.md that
 do not seem to have made it over, like the one about reallocarray and the
 one about aton and pton.  There may be more.  We should make sure we
 aren't losing any information in this document combination.

 Also, as part of this work, we should remove doc/HACKING/this_not_that.md.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs