Re: [tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
+---
 Reporter:  Dbryrtfbcbhgf   |  Owner:  pospeselr
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-9.0, TorBrowserTeam201910R  |  Actual Points:  0.1
Parent ID:  | Points:  0.1
 Reviewer:  |Sponsor:
+---
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. Cherry-picked to `tor-browser-68.1.0esr-9.0-3` (commit
 ec6ab177fd17a27ee6c7305c5433870d8d097097) (with typo fixups etc. to avoid
 another roundtrip).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
+--
 Reporter:  Dbryrtfbcbhgf   |  Owner:  pospeselr
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-9.0, TorBrowserTeam201910R  |  Actual Points:  0.1
Parent ID:  | Points:  0.1
 Reviewer:  |Sponsor:
+--
Changes (by pospeselr):

 * points:  0.25 => 0.1
 * actualpoints:   => 0.1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
+--
 Reporter:  Dbryrtfbcbhgf   |  Owner:  pospeselr
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-9.0, TorBrowserTeam201910R  |  Actual Points:
Parent ID:  | Points:  0.25
 Reviewer:  |Sponsor:
+--
Changes (by pospeselr):

 * keywords:  tbb-9.0, TorBrowserTeam201910 => tbb-9.0,
   TorBrowserTeam201910R
 * status:  assigned => needs_review


Comment:

 Removed the caching. Protip for future me and future yous, don't cache
 things you don't control the lifetime of.

 tor-browser : https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_31920_review

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
---+---
 Reporter:  Dbryrtfbcbhgf  |  Owner:  pospeselr
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-9.0, TorBrowserTeam201910  |  Actual Points:
Parent ID: | Points:  0.25
 Reviewer: |Sponsor:
---+---
Changes (by pospeselr):

 * keywords:  tbb-9.0 => tbb-9.0, TorBrowserTeam201910
 * points:   => 0.25


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
--+---
 Reporter:  Dbryrtfbcbhgf |  Owner:  pospeselr
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-9.0   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by pospeselr):

 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
--+---
 Reporter:  Dbryrtfbcbhgf |  Owner:  pospeselr
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-9.0   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by pospeselr):

 * owner:  tbb-team => pospeselr
 * status:  needs_information => assigned


Old description:

> If I resize TorBrowser 9.0a7 to its smallest size and back to its
> original size, this causes the shield button to do nothing when clicked
> on. I made a video showing the bug occur.

New description:

 If I resize TorBrowser 9.0a7 to its smallest size and back to its original
 size, this causes the shield button to do nothing when clicked on. I made
 a video showing the bug
 occur.https://trac.torproject.org/projects/tor/ticket/31920#no4

--

Comment:

 So this is probably because I tried to be clever and cache the button
 element, rather than doing a querySelector each time it's needed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
--+---
 Reporter:  Dbryrtfbcbhgf |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-9.0   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by Dbryrtfbcbhgf):

 gk, The current stable works correctly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
--+--
 Reporter:  Dbryrtfbcbhgf |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-9.0   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => tbb-9.0


Comment:

 Dbryrtfbcbhgf: Does the current stable work for you or are you seeing the
 same issue with it? On my Linux box at least it seems it's only an alpha
 issue. It's not related to letterboxing being on/off either.

 One could test whether #31251 plays a role here as it never landed in
 stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
--+---
 Reporter:  Dbryrtfbcbhgf |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-9.0   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  new => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
--+--
 Reporter:  Dbryrtfbcbhgf |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by Thorin):

 Its the width. I think I've seen before this in Firefox as well. If the
 button/icon moves into the overflow menu (its around the 400px mark), when
 you bring it back its popup action is broken - maybe Dão Gottwald at
 Mozilla has heard of this. I just tested FF Nightly with a uMatrix button
 and that worked just fine.

 PS: As soon as you open a new window, it fixes it for all windows.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
--+--
 Reporter:  Dbryrtfbcbhgf |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by Dbryrtfbcbhgf):

 Video showing the bug occur. https://streamable.com/tw3pc

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31920 [Applications/Tor Browser]: Resizing TorBrowser 9.0a7 to its smallest size and back causes the shield button to stop working

[Tor Bug Tracker & Wiki]

#31920: Resizing TorBrowser 9.0a7 to its smallest size and back causes the 
shield
button to stop working
---+--
 Reporter:  Dbryrtfbcbhgf  |  Owner:  tbb-team
 Type:  defect | Status:  new
 Priority:  Medium |  Component:  Applications/Tor Browser
  Version: |   Severity:  Normal
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
 If I resize TorBrowser 9.0a7 to its smallest size and back to its original
 size, this causes the shield button to do nothing when clicked on. I made
 a video showing the bug occur.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs