Re: [tor-bugs] #32575 [Core Tor/Tor]: CID 1455953: Resource leak in options_act_reversible()

2019-11-24 Thread Tor Bug Tracker & Wiki
#32575: CID 1455953:  Resource leak in options_act_reversible()
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: unspecified
 Severity:  Normal| Resolution:  fixed
 Keywords:  coverity  |  Actual Points:  .1
Parent ID:| Points:  .1
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * status:  needs_review => closed
 * version:   => Tor: unspecified
 * resolution:   => fixed


Comment:

 Looks good to me.
 Merged to master.

 Merged #32575, #31939, #31548, #30344, #30258, #28970, #31091, and #32108
 together.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32575 [Core Tor/Tor]: CID 1455953: Resource leak in options_act_reversible()

2019-11-24 Thread Tor Bug Tracker & Wiki
#32575: CID 1455953:  Resource leak in options_act_reversible()
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  coverity  |  Actual Points:  .1
Parent ID:| Points:  .1
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+

Comment (by nickm):

 Closed #32594 as a duplicate of this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32575 [Core Tor/Tor]: CID 1455953: Resource leak in options_act_reversible()

2019-11-22 Thread Tor Bug Tracker & Wiki
#32575: CID 1455953:  Resource leak in options_act_reversible()
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  coverity  |  Actual Points:  .1
Parent ID:| Points:  .1
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  assigned => needs_review
 * reviewer:   => teor
 * actualpoints:   => .1


Comment:

 Branch is #32575 with PR at https://github.com/torproject/tor/pull/1557

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32575 [Core Tor/Tor]: CID 1455953: Resource leak in options_act_reversible()

2019-11-22 Thread Tor Bug Tracker & Wiki
#32575: CID 1455953:  Resource leak in options_act_reversible()
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:  coverity
Actual Points: |  Parent ID:
   Points:  .1 |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 {{{
  *** CID 1455953:  Resource leaks  (RESOURCE_LEAK)
 /src/app/config/config.c: 1983 in options_act_reversible()
 1977   tor_assert(*msg);
 1978
 1979   options_rollback_log_transaction(log_transaction);
 1980   options_rollback_listener_transaction(listener_transaction);
 1981
 1982  done:
 >>> CID 1455953:  Resource leaks  (RESOURCE_LEAK)
 >>> Variable "listener_transaction" going out of scope leaks the
 storage it points to.
 1983   return r;
 1984 }
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs