Re: [tor-bugs] #32580 [Core Tor/Tor]: Use clang's enum_extensibility attribute to check enum values

2019-11-26 Thread Tor Bug Tracker & Wiki
#32580: Use clang's enum_extensibility attribute to check enum values
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  code-correctness  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 Replying to [comment:2 nickm]:
 > That first link (https://clang.llvm.org/docs/AttributeReference.html
 #enum-extensibility) gives me an empty page. Is there a better place to
 find out what this is?

 That's really weird, I see that too. But it worked a few days ago. And
 some search engines still have it indexed :-)

 Here's the version from clang 9.0.0, the latest release:
 https://releases.llvm.org/9.0.0/tools/clang/docs/AttributeReference.html
 #enum-extensibility

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32580 [Core Tor/Tor]: Use clang's enum_extensibility attribute to check enum values

2019-11-26 Thread Tor Bug Tracker & Wiki
#32580: Use clang's enum_extensibility attribute to check enum values
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  code-correctness  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+--

Comment (by nickm):

 That first link (https://clang.llvm.org/docs/AttributeReference.html#enum-
 extensibility) gives me an empty page. Is there a better place to find out
 what this is?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32580 [Core Tor/Tor]: Use clang's enum_extensibility attribute to check enum values

2019-11-22 Thread Tor Bug Tracker & Wiki
#32580: Use clang's enum_extensibility attribute to check enum values
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  code-correctness  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 Here's how we can check for that feature in clang:
 https://clang.llvm.org/docs/LanguageExtensions.html#feature-checking-
 macros

 I think the sa,e syntax works on gcc, but we should check.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32580 [Core Tor/Tor]: Use clang's enum_extensibility attribute to check enum values

2019-11-22 Thread Tor Bug Tracker & Wiki
#32580: Use clang's enum_extensibility attribute to check enum values
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  code-correctness
Actual Points:|  Parent ID:
   Points:  1 |   Reviewer:
  Sponsor:|
--+--
 We could avoid constructing bad enum values using enum_extensibility:
 https://clang.llvm.org/docs/AttributeReference.html#enum-extensibility

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs