[tor-bugs] #32806 [Core Tor/Tor]: Move "easy" dirauth-only options to dirauth module

[Tor Bug Tracker & Wiki]

#32806: Move "easy" dirauth-only options to dirauth module
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  tor-design
Actual Points:|  Parent ID:  #32139
   Points:|   Reviewer:
  Sponsor:|
--+
 For this ticket, I'll be moving all of the easy, simple dirauth
 configuration options to the appropriate module.

 I'm defining options as "easy" if they aren't currently used anywhere
 outside the dirauth module, the config module, and the tests.

 For other dirauth-only options, I'll want to do some refactoring first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32806 [Core Tor/Tor]: Move "easy" dirauth-only options to dirauth module

[Tor Bug Tracker & Wiki]

#32806: Move "easy" dirauth-only options to dirauth module
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-design|  Actual Points:
Parent ID:  #32139| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 See branch `ticket32807` with PR at
 https://github.com/torproject/tor/pull/1619 .

 I'll put this in needs_review once CI is done.  I recommend reviewing it
 one commit at a time; the individual commits are fairly simple, but there
 are a bunch of them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32806 [Core Tor/Tor]: Move "easy" dirauth-only options to dirauth module

[Tor Bug Tracker & Wiki]

#32806: Move "easy" dirauth-only options to dirauth module
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-design|  Actual Points:  0.5
Parent ID:  #32139| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * actualpoints:   => 0.5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32806 [Core Tor/Tor]: Move "easy" dirauth-only options to dirauth module

[Tor Bug Tracker & Wiki]

#32806: Move "easy" dirauth-only options to dirauth module
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-design|  Actual Points:  0.5
Parent ID:  #32139| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32806 [Core Tor/Tor]: Move "easy" dirauth-only options to dirauth module

[Tor Bug Tracker & Wiki]

#32806: Move "easy" dirauth-only options to dirauth module
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-design, 043-can  |  Actual Points:  0.5
Parent ID:  #32139   | Points:
 Reviewer:  teor |Sponsor:
-+
Changes (by teor):

 * status:  needs_review => needs_revision
 * type:  defect => enhancement


Comment:

 Looks good, there's a bit of unused code you can delete if you like, and a
 comment that got a little mangled.
 Feel free to merge after fixing those issues.

 What's the plan to test these changes?
 There are some unit tests and chutney tests, but the coverage isn't great.

 Should we run the code on moria1 before merging? Or shortly after merging?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32806 [Core Tor/Tor]: Move "easy" dirauth-only options to dirauth module

[Tor Bug Tracker & Wiki]

#32806: Move "easy" dirauth-only options to dirauth module
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-design, 043-can  |  Actual Points:  0.5
Parent ID:  #32139   | Points:
 Reviewer:  teor |Sponsor:
-+

Comment (by nickm):

 yeah -- moria has to be the testing plan here; we usually get good testing
 there during our alpha series once we merge dirauth stuff.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32806 [Core Tor/Tor]: Move "easy" dirauth-only options to dirauth module

[Tor Bug Tracker & Wiki]

#32806: Move "easy" dirauth-only options to dirauth module
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  tor-design, 043-can  |  Actual Points:  0.5
Parent ID:  #32139   | Points:
 Reviewer:  teor |Sponsor:
-+
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => implemented


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs