Re: [tor-bugs] #32845 [Core Tor/Tor]: Add UTF-8 validation unit tests

[Tor Bug Tracker & Wiki]

#32845: Add UTF-8 validation unit tests
+--
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  043-should, utf-8, Unicode  |  Actual Points:  0.1
Parent ID:  | Points:  0.2
 Reviewer:  nickm   |Sponsor:
+--
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Whoops; should have closed when I merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32845 [Core Tor/Tor]: Add UTF-8 validation unit tests

[Tor Bug Tracker & Wiki]

#32845: Add UTF-8 validation unit tests
+--
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  043-should, utf-8, Unicode  |  Actual Points:  0.1
Parent ID:  | Points:  0.2
 Reviewer:  nickm   |Sponsor:
+--
Changes (by nickm):

 * reviewer:   => nickm


Comment:

 LGTM; squashed and merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32845 [Core Tor/Tor]: Add UTF-8 validation unit tests

[Tor Bug Tracker & Wiki]

#32845: Add UTF-8 validation unit tests
+--
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  043-should, utf-8, Unicode  |  Actual Points:  0.1
Parent ID:  | Points:  0.2
 Reviewer:  |Sponsor:
+--
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32845 [Core Tor/Tor]: Add UTF-8 validation unit tests

[Tor Bug Tracker & Wiki]

#32845: Add UTF-8 validation unit tests
+--
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:  Tor:
|  0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  043-should, utf-8, Unicode  |  Actual Points:  0.1
Parent ID:  | Points:  0.2
 Reviewer:  |Sponsor:
+--
Changes (by teor):

 * actualpoints:   => 0.1


Comment:

 Please review and merge my PR:
 * master: https://github.com/torproject/tor/pull/1641

 I also added some additional error-checking for the string pointer and
 length.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32845 [Core Tor/Tor]: Add UTF-8 validation unit tests

[Tor Bug Tracker & Wiki]

#32845: Add UTF-8 validation unit tests
--+
 Reporter:  teor  |  Owner:  teor
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  043-should, utf-8, Unicode
Actual Points:|  Parent ID:
   Points:  0.2   |   Reviewer:
  Sponsor:|
--+
 We should add unit tests for the following UTF-8 sequences. Their validity
 varies between different programming languages. We should go with the
 common case (if it matches the standard).

 Invalid:
 surrogate nullsurrog threehigh
 EDA081 3000EDA081 EDBFBF

 fourhigh fivebyte sixbyte sixhigh
 F490BFBF FB80808080 FD80808080 FDBFBFBFBF

 Valid:
 fourbyte fourbyte2
 F0908D88 F0BFBFBF

 Valid in the Unicode standard, invalid in torrcs and directory documents:
 nullbyte
 3031320033

 See proposal 285 for details, and for the null byte exception:
 https://gitweb.torproject.org/torspec.git/tree/proposals/285-utf-8.txt

 Test Case Source:
 `POC||GTFO 19`, page 43
 https://www.alchemistowl.org/pocorgtfo/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs