Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  implemented
  easy 043-can   |  Actual Points:
Parent ID:  #4310| Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged to maint-0.4.3 and forward!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:11 swati]:
 > Hi catalyst, could you please add a changes file to this ticket and
 merge it?

 Thanks!  Looks good to me.  I created a changes file.

 Merge instructions: pull request including the changes file is at

 https://github.com/torproject/tor/pull/1728

 please merge that one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by swati):

 Hi catalyst, could you please add a changes files to this ticket and merge
 it?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by swati):

 Replying to [comment:7 catalyst]:
 > Looks fairly good so far.  It could use a few minor changes:
 > * Put MaxOnionQueueDelay after MaxMemInQueues (alphabetical ordering)
 > * Minor changes to introductory text for Statistics Options (see an
 earlier comment)
 > * Move RephistTrackTime to Statistics Options
 > * Add a changes file (we can do this for you if you prefer -- or see
 doc/HACKING/CodingStandards.md for instructions or
 
https://github.com/torproject/tor/blob/cb757b30a208f027ca36d7acceade61faf348009/changes/ticket32928
 for an example)

 Addressed all these suggested updates. According to teor and catalyst,
 moved [[RephistTrackTime]] to the General Options category.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by catalyst):

 Hi swati, I think I agree with teor after thinking about it some more.
 Please leave RephistTrackTime alone, or move it to General Options.  Its
 content might need improvement (to make it clear that all kinds of
 entities use it), but we can do that separately.

 Replying to [comment:8 teor]:

 > RephistTrackTime is used to clean router reputation history. This
 history is used by clients, relays, and authorities (in different ways).
 See:
 >
 https://gitweb.torproject.org/tor.git/tree/src/core/mainloop/mainloop.c#n1412
 >
 https://gitweb.torproject.org/tor.git/tree/src/core/mainloop/mainloop.c#n2008
 >
 > Authorities use it in their votes, clients and relays use it to check
 whether another relay might be up.
 >
 > So I think RephistTrackTime belongs in some sort of "common options"
 section. (Or in client options, if there isn't a common options section.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:6 nickm]:
 > Replying to [comment:4 catalyst]:
 > > Replying to [comment:1 swati]:
 > >
 > > > Created a Pull Request - https://github.com/torproject/tor/pull/1715
 for the following changes:
 > > >  - Created a new section titled **Statistics Options**. Pulled out
 all the stats-related and extra-info related options, and put them into
 this new section.
 > >
 > > Looks good!  I would suggest a few minor changes to the introductory
 text.  Change "following options describe" to "following options affect".
 Change "that Tor collects and writes" to "that Tor relays collect and
 publish".  What do you think?
 > >
 > > > Should I pull out the DownloadExtraInfo option (that is presently
 under the Client Options section) and move it under **Statistics
 Options**?
 > >
 > > I think this still belongs in the Client Options section, because it
 doesn't affect how relays report their statistics.

 I agree, the DownloadExtraInfo option works on clients and relays, so it
 should not be in a relay-only section.

 > > Also, I think RephistTrackTime might belong in the stats section,
 because it changes the length of the period that relays use to report
 their bandwidth stats.  (I'm still researching this.  Anyone else have
 ideas?)
 >
 > Everything with "Rephist" in the name should go under statistics.

 RephistTrackTime is used to clean router reputation history. This history
 is used by clients, relays, and authorities (in different ways). See:
 https://gitweb.torproject.org/tor.git/tree/src/core/mainloop/mainloop.c#n1412
 https://gitweb.torproject.org/tor.git/tree/src/core/mainloop/mainloop.c#n2008

 Authorities use it in their votes, clients and relays use it to check
 whether another relay might be up.

 So I think RephistTrackTime belongs in some sort of "common options"
 section. (Or in client options, if there isn't a common options section.)

 The bandwidth stats interval is a fixed constant, as are all stats
 intervals. We don't let people configure them, it would make metrics code
 much more complex :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Looks fairly good so far.  It could use a few minor changes:
 * Put MaxOnionQueueDelay after MaxMemInQueues (alphabetical ordering)
 * Minor changes to introductory text for Statistics Options (see an
 earlier comment)
 * Move RephistTrackTime to Statistics Options
 * Add a changes file (we can do this for you if you prefer -- or see
 doc/HACKING/CodingStandards.md for instructions or
 
https://github.com/torproject/tor/blob/cb757b30a208f027ca36d7acceade61faf348009/changes/ticket32928
 for an example)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by nickm):

 Replying to [comment:4 catalyst]:
 > Replying to [comment:1 swati]:
 >
 > > Created a Pull Request - https://github.com/torproject/tor/pull/1715
 for the following changes:
 > >  - Alphabetized the Server and Directory Server Options
 >
 > Thanks!  It looks like MaxOnionQueueDelay is out of order, but the rest
 of Server and Stats options are in order or correctly commented.  I'll
 check the Directory Server options in another comment.
 >
 > >  - Created a new section titled **Statistics Options**. Pulled out all
 the stats-related and extra-info related options, and put them into this
 new section.
 >
 > Looks good!  I would suggest a few minor changes to the introductory
 text.  Change "following options describe" to "following options affect".
 Change "that Tor collects and writes" to "that Tor relays collect and
 publish".  What do you think?
 >
 > > Should I pull out the DownloadExtraInfo option (that is presently
 under the Client Options section) and move it under **Statistics
 Options**?
 >
 > I think this still belongs in the Client Options section, because it
 doesn't affect how relays report their statistics.
 >
 > Also, I think RephistTrackTime might belong in the stats section,
 because it changes the length of the period that relays use to report
 their bandwidth stats.  (I'm still researching this.  Anyone else have
 ideas?)

 Everything with "Rephist" in the name should go under statistics.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by catalyst):

 Replying to [comment:4 catalyst]:
 > I'll check the Directory Server options in another comment.

 Looks like I got my script for checking the Directory Server options
 wrong, and it was capturing more than I expected.  The Directory Server
 options look like they're sorted correctly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by catalyst):

 Replying to [comment:1 swati]:

 > Created a Pull Request - https://github.com/torproject/tor/pull/1715 for
 the following changes:
 >  - Alphabetized the Server and Directory Server Options

 Thanks!  It looks like MaxOnionQueueDelay is out of order, but the rest of
 Server and Stats options are in order or correctly commented.  I'll check
 the Directory Server options in another comment.

 >  - Created a new section titled **Statistics Options**. Pulled out all
 the stats-related and extra-info related options, and put them into this
 new section.

 Looks good!  I would suggest a few minor changes to the introductory text.
 Change "following options describe" to "following options affect".  Change
 "that Tor collects and writes" to "that Tor relays collect and publish".
 What do you think?

 > Should I pull out the DownloadExtraInfo option (that is presently under
 the Client Options section) and move it under **Statistics Options**?

 I think this still belongs in the Client Options section, because it
 doesn't affect how relays report their statistics.

 Also, I think RephistTrackTime might belong in the stats section, because
 it changes the length of the period that relays use to report their
 bandwidth stats.  (I'm still researching this.  Anyone else have ideas?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by swati):

 * reviewer:   => catalyst


Comment:

 Please feel free to add more reviewers.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:   |Sponsor:
-+-
Changes (by swati):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:   |Sponsor:
-+-

Comment (by swati):

 Hi catalyst,

 Created a Pull Request - https://github.com/torproject/tor/pull/1715 for
 the following changes:
  - Alphabetized the Server and Directory Server Options

  - Created a new section titled **Statistics Options**. Pulled out all the
 stats-related and extra-info related options, and put them into this new
 section.

 Should I pull out the DownloadExtraInfo option (that is presently under
 the Client Options section) and move it under **Statistics Options**?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33188 [Core Tor/Tor]: Tor Manual: Alphabetize Server and Directory Server Options

[Tor Bug Tracker & Wiki]

#33188: Tor Manual: Alphabetize Server and Directory Server Options
-+-
 Reporter:  swati|  Owner:  (none)
 Type:  task | Status:  new
 Priority:  Medium   |  Component:  Core
 |  Tor/Tor
  Version:   |   Severity:  Normal
 Keywords:  documentation tor-client manpage |  Actual Points:
  easy 043-can   |
Parent ID:  #4310| Points:
 Reviewer:   |Sponsor:
-+-
 Alphabetize options in the Server Options and Directory Server Options

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs