[tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
+
 Reporter:  teor|  Owner:  teor
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  |   Keywords:  tor-ci, chutney
Actual Points:  |  Parent ID:  #33194
   Points:  0.1 |   Reviewer:
  Sponsor:  Sponsor55-must  |
+
 While we're actively changing our IPv6 code, we should make sure that the
 macOS chutney IPv6 tests pass in Travis CI.

 While I'm doing this change, I will see if there are:
 * some redundant jobs I can delete, or
 * some inactive areas that I can make fast_finish.

 I think our Rust build might be a good candidate for fast_finish, we
 haven't changed that code much in about a year. But I should check with
 the team before making this change.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, chutney  |  Actual Points:
Parent ID:  #33050   | Points:  0.1
 Reviewer:   |Sponsor:  Sponsor55-must
-+
Changes (by teor):

 * parent:  #33194 => #33050


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, chutney  |  Actual Points:
Parent ID:  #33050   | Points:  0.1
 Reviewer:   |Sponsor:  Sponsor55-must
-+

Comment (by teor):

 We have active rust patches (and bugs) from two external contributors, so
 I can't make the rust jobs fast_finish.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, chutney  |  Actual Points:
Parent ID:  #33050   | Points:  0.1
 Reviewer:   |Sponsor:  Sponsor55-must
-+

Comment (by teor):

 We need to merge the #33075 backport, before making these changes.

 We can delete the following redundant jobs:
 * Linux clang distcheck
   * I think this job was actually an 0.2.9 merge forward error

 We need to speed up the macOS chutney IPv6 job, because it runs for 23-46
 minutes:
 * run IPv4-only in Linux, and IPv6-only in macOS

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-immediately, tor-  |  Actual Points:  0.6
  ci, chutney, ipv6  |
Parent ID:  #33050   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * keywords:  tor-ci, chutney => consider-backport-immediately, tor-ci,
 chutney, ipv6
 * cc: nickm (added)
 * reviewer:   => nickm
 * status:  assigned => needs_review
 * actualpoints:   => 0.6


Comment:

 See my PRs:

 Backport require IPv6 chutney to pass, remove a redundant job, reorder
 jobs (#33194 and #33195):
 * 0.3.5: https://github.com/torproject/tor/pull/1732
 * 0.4.1: https://github.com/torproject/tor/pull/1733
 * 0.4.2: https://github.com/torproject/tor/pull/1734
 * 0.4.3: https://github.com/torproject/tor/pull/1735

 Split IPv4 and IPv6 chutney tests, and only run IPv6 on macOS (#33280 and
 #33303):
 * master: https://github.com/torproject/tor/pull/1731

 I think it's worth backporting these changes, they are travis-only, and
 should make a significant difference to CI speeds during backport merges.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-immediately, tor-  |  Actual Points:  0.6
  ci, chutney, ipv6  |
Parent ID:  #33050   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-must
-+-

Comment (by teor):

 There is also a master test branch, without #33280:
 * https://github.com/teor2345/tor/branches/all?query=33195

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-immediately, tor-  |  Actual Points:  0.6
  ci, chutney, ipv6  |
Parent ID:  #33050   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-must
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 I've left comments on https://github.com/torproject/tor/pull/1731 .

 As for backporting, I agree with backporting the travis changes, but:
 let's try them in master for a week or so before we backport, in case they
 turn out to have unforseen drawbacks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-immediately, tor-  |  Actual Points:  0.6
  ci, chutney, ipv6  |
Parent ID:  #33050   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 Thanks, I've quoted those variables, improved make's output, and improved
 the job display on Travis.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-immediately, tor-  |  Actual Points:  0.7
  ci, chutney, ipv6  |
Parent ID:  #33050   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * actualpoints:  0.6 => 0.7


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-immediately, tor-  |  Actual Points:  0.7
  ci, chutney, ipv6  |
Parent ID:  #33050   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-must
-+-

Comment (by teor):

 I just compared master and this PR:
 * https://travis-ci.org/torproject/tor/builds/650218289
 * https://travis-ci.org/torproject/tor/builds/650232465

 Both finish in about 18 minutes, the IPv6-only tests take 12 minutes on
 macOS.

 I think that's a win, because we:
 * added a slow chutney job (25-45 minutes), but made it faster (13
 minutes), and
 * deleted a redundant distcheck job (8 minutes),
 but kept the same CI wall clock run time.

 (The extra 5 minutes for the chutney job is hidden by the parallelism.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-immediately, tor-  |  Actual Points:  0.7
  ci, chutney, ipv6  |
Parent ID:  #33050   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-must
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 LGTM. Let's merge this in into master and let it cook for a little while.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0433, tor-   |  Actual Points:  0.7
  ci, chutney, ipv6  |
Parent ID:  #33050   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * keywords:  consider-backport-immediately, tor-ci, chutney, ipv6 =>
 consider-backport-after-0433, tor-ci, chutney, ipv6
 * milestone:  Tor: 0.4.4.x-final => Tor: 0.4.3.x-final


Comment:

 Merged to master, because I needed it for #4.

 I had to re-do the #33280 and #33195 merge, because the "ours" merge
 deleted some commits that were merged into 0.4.3 after the branches split
 off from master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33195 [Core Tor/Tor]: Require IPv6 tests in Travis CI

[Tor Bug Tracker & Wiki]

#33195: Require IPv6 tests in Travis CI
-+-
 Reporter:  teor |  Owner:  teor
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  consider-backport-immediately, tor-  |  Actual Points:  0.7
  ci, chutney, ipv6  |
Parent ID:  #33050   | Points:  0.1
 Reviewer:  nickm|Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * keywords:  consider-backport-after-0433, tor-ci, chutney, ipv6 =>
 consider-backport-immediately, tor-ci, chutney, ipv6
 * resolution:   => fixed
 * milestone:  Tor: 0.4.3.x-final => Tor: 0.3.5.x-final


Comment:

 Merged to 0.3.5 and later, because I need it for #33048.

 We also want to have consistent tor-chutney CI, particularly now that
 #33232 is merged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs