[tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-mobile, tbb-rbm,
 Severity:  Normal   |  tbb-parity, TorBrowserTeam202002
Actual Points:   |  Parent ID:  #28704
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Add Android Host and ABI Info to RBM.conf

 ''configure_host'': this will be used for native projects to be able to
 configure the correct host triplets for android builds

 ''abi'': This will match the names that Android uses for architectures
 within an app or library. This will be used by projects when packaging
 apks and android libraries.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-
Changes (by sysrqb):

 * status:  new => needs_review
 * reviewer:   => boklm


Comment:

 This is based on commit 9731400810fd0cd1930d097fd1e6fae9ba4f07cc from
 ticket:28704#comment:23.

 This commit seems okay to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002 => tbb-
 mobile, tbb-rbm, TorBrowserTeam202002


Comment:

 No parity involved here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-

Comment (by sisbell):

 I added in a soft link link for libtinfo5 the upgrade to debian caused a
 problem. Otheriwse, commit it the same

 {{{
 error while loading shared libraries: libtinfo.so.5: cannot open shared
 object file:
 }}}

 https://github.com/sisbell/tor-browser-build/commits/bug-33216

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002R  |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202002 => tbb-mobile, tbb-
 rbm, TorBrowserTeam202002R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002R  |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-
Changes (by eighthave):

 * cc: hans@… (removed)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202002R => tbb-mobile, tbb-
 rbm, TorBrowserTeam202002


Comment:

 Replying to [comment:3 sisbell]:
 > I added in a soft link link for libtinfo5 the upgrade to debian caused a
 problem. Otheriwse, commit it the same
 >
 > {{{
 > error while loading shared libraries: libtinfo.so.5: cannot open shared
 object file:
 > }}}
 >
 > https://github.com/sisbell/tor-browser-build/commits/bug-33216

 Where does this error happen exactly? The update to Debian Buster is
 already merged to master, and it seems we don't have the error.

 Maybe there is a better fix than linking libtinfo.so.6.1 to libtinfo.so.5.
 Anyway this seems unrelated to `Add Android Host and ABI Info to RBM.conf`
 so I think it should be done in a separate commit/ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:6 boklm]:
 > Replying to [comment:3 sisbell]:
 > > I added in a soft link link for libtinfo5 the upgrade to debian caused
 a problem. Otheriwse, commit it the same
 > >
 > > {{{
 > > error while loading shared libraries: libtinfo.so.5: cannot open
 shared object file:
 > > }}}
 > >
 > > https://github.com/sisbell/tor-browser-build/commits/bug-33216
 >
 > Where does this error happen exactly? The update to Debian Buster is
 already merged to master, and it seems we don't have the error.
 >
 > Maybe there is a better fix than linking libtinfo.so.6.1 to
 libtinfo.so.5. Anyway this seems unrelated to `Add Android Host and ABI
 Info to RBM.conf` so I think it should be done in a separate
 commit/ticket.
 Ok open another issue for this and add details.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-
Changes (by sisbell):

 * status:  needs_revision => needs_review
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202002 => tbb-mobile, tbb-
 rbm, TorBrowserTeam202003R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-

Comment (by sisbell):

 To provide some context on this issue

 For clang60 in android NDK 17, we see


 {{{
 Dynamic section at offset 0x3940a18 contains 33 entries:
   TagType Name/Value
  0x0001 (NEEDED) Shared library: [libpthread.so.0]
  0x0001 (NEEDED) Shared library: [librt.so.1]
  0x0001 (NEEDED) Shared library: [libdl.so.2]
  0x0001 (NEEDED) Shared library: [libtinfo.so.5]
  0x0001 (NEEDED) Shared library: [libz.so.1]
  0x0001 (NEEDED) Shared library: [libm.so.6]
  0x0001 (NEEDED) Shared library: [libc++.so.1]
  0x0001 (NEEDED) Shared library: [libgcc_s.so.1]
  0x0001 (NEEDED) Shared library: [libc.so.6]
 }}}

 Google changed this to optional in NDK 18 (which we haven't upgraded to).

 More info: https://github.com/android/ndk/issues/574

 We can solve this by installing libtinfo5 as a dependency. This appears to
 have not worked for tor project since the var/deps in the tor/config file
 (which did not contain the libtinfo5 dep) were not merging with the dep
 section in rbm.conf which did contain the libtinfo5 dep. At least this is
 how I'm interpreting the results based on multiple builds.

 I'll fix this by removing the soft link in rbm.conf and adding the
 libtinfo5 dep in the tor config file.

 https://github.com/sisbell/tor-browser-build/tree/bug-33216a

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-

Comment (by sisbell):

 I also added the configure_opt including CC and host info for Android into
 rbm.conf. The other projects will use it rather than specifying it in each
 file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Ok, this looks good to me, thanks. I merged it to master as commit
 `760178fda1e29256fc63013bc27d798fe3fed999`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33216 [Applications/Tor Browser]: Add Android Host and ABI Info to RBM.conf

[Tor Bug Tracker & Wiki]

#33216: Add Android Host and ABI Info to RBM.conf
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:  .5
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:
 Reviewer:  boklm|Sponsor:
-+-
Changes (by sisbell):

 * actualpoints:   => .5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs